boards: shields: Add EVAL-ADXL367-ARDZ accelerometer shield and streaming configuration #88644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Samples
github-actions
bot
requested review from
asemjonovs,
avisconti,
galak,
jeppenodgaard,
kartben,
MaureenHelm,
microbuilder,
nashif,
ozersa,
teburd,
tristan-google,
ttmut,
ubieda,
yasinustunerg and
yperess
kartben
reviewed
Apr 15, 2025
Comment on lines
8
to
10
| aliases { | ||
| accel0 = &adxl367_eval_adxl367_ardz; | ||
| }; |
There was a problem hiding this comment.
just move this to the shield's overlay so that "everyone" just benefits from this alias when using the shield.
There was a problem hiding this comment.
Is it ok now?
vladislav-pejic
force-pushed
the
shield_eval_adxl367_ardz
branch
3 times, most recently
from
49d9682 to
2e6312f
Compare
nordicjm
requested changes
Apr 15, 2025
|
I'm wondering whether this should be a device-tree property. That way multiple instances can be configured differently |
vladislav-pejic
force-pushed
the
shield_eval_adxl367_ardz
branch
2 times, most recently
from
285527c to
9230a08
Compare
nordicjm
reviewed
Apr 22, 2025
drivers/sensor/adi/adxl367/adxl367.h
Outdated
| @@ -232,6 +232,16 @@ | |||
| #define ADXL367_ACCEL_4G_LSB_PER_G 2000 | |||
| #define ADXL367_ACCEL_8G_LSB_PER_G 1000 | |||
|
|
|||
| #if CONFIG_ADXL367_FIFO_DISABLED | |||
| # define ADXL367_DEFAULT_FIFO_MODE ADXL367_FIFO_DISABLED | |||
There was a problem hiding this comment.
can we not do this weird indent and just do #define normally
Add a new shield definition for the Analog Devices EVAL-ADXL367-ARDZ accelerometer shield. This shield provides support for an ADI ADXL367 accelerometer over an Arduino SPI connector. Signed-off-by: Vladislav Pejic <[email protected]>
vladislav-pejic
force-pushed
the
shield_eval_adxl367_ardz
branch
8 times, most recently
from
5dfd2b5 to
2217b9b
Compare
Done! |
MaureenHelm
requested changes
Apr 24, 2025
Comment on lines
53
to
58
| Accelerometer FIFO Mode. If not set, default value is ADXL367_FIFO_MODE_DISABLED. | ||
| enum: | ||
| - 0 # ADXL367_FIFO_MODE_DISABLED | ||
| - 1 # ADXL367_FIFO_MODE_OLDEST_SAVED | ||
| - 2 # ADXL367_FIFO_MODE_STREAM | ||
| - 3 # ADXL367_FIFO_MODE_TRIGGERED |
There was a problem hiding this comment.
Need to explain in the description why the default value was selected
https://docs.zephyrproject.org/latest/build/dts/bindings-upstream.html#dt-bindings-default-rules
The enumeration decoding needs to be moved from comments to the description so it will be included in the rendered documentation.
vladislav-pejic
force-pushed
the
shield_eval_adxl367_ardz
branch
from
2217b9b to
2173a49
Compare
MaureenHelm
previously approved these changes
Apr 24, 2025
vladislav-pejic
force-pushed
the
shield_eval_adxl367_ardz
branch
from
2173a49 to
8c796fd
Compare
vladislav-pejic
force-pushed
the
shield_eval_adxl367_ardz
branch
2 times, most recently
from
c3780f1 to
2b4af5d
Compare
nordicjm
reviewed
Apr 25, 2025
drivers/sensor/adi/adxl367/adxl367.c
Outdated
Comment on lines
1118
to
1119
| .fifo_config.fifo_mode = \ | ||
| DT_INST_PROP_OR(inst, fifo_mode, ADXL367_FIFO_DISABLED), \ |
There was a problem hiding this comment.
end of line alignment seems off?
Add support for setting FIFO mode using DT property. Signed-off-by: Vladislav Pejic <[email protected]>
Adds adxl367 streaming configuration to accelerometer samples. Signed-off-by: Vladislav Pejic <[email protected]>
vladislav-pejic
force-pushed
the
shield_eval_adxl367_ardz
branch
from
2b4af5d to
f09dc4e
Compare
MaureenHelm
approved these changes
Apr 25, 2025
nordicjm
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new shield definition for the Analog Devices EVAL-ADXL367-ARDZ
accelerometer shield. This shield provides support for an ADI ADXL367
accelerometer over an Arduino SPI connector.
Also adds adxl367 streaming configuration to accelerometer samples.
Signed-off-by: Vladislav Pejic [email protected]