Flexio SPI loopback test failed on fast speed(16Mbps) #88877
+125
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: NXP
github-actions
bot
requested review from
butok,
dbaluta,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
manuargue,
mmahadevan108,
nordic-krch,
tbursztyka and
teburd
Raymond0225
force-pushed
the
flexIO_spi_input_freq_fix
branch
from
f852952 to
17d6aa5
Compare
JarmouniA
suggested changes
Apr 21, 2025
drivers/spi/spi_mcux_flexio.c
Outdated
| @@ -206,6 +206,24 @@ static void spi_flexio_master_init(FLEXIO_SPI_Type *base, flexio_spi_master_conf | |||
| timerConfig.timerStart = kFLEXIO_TimerStartBitEnabled; | |||
| /* Low 8-bits are used to configure baudrate. */ | |||
| timerDiv = (uint16_t)(srcClock_Hz / masterConfig->baudRate_Bps); | |||
|
|
|||
| /* Add protection if bandrate required is overflow. | |||
There was a problem hiding this comment.
Suggested change
| /* Add protection if bandrate required is overflow. | |
| /* Add protection if the required baud rate overflows. |
drivers/spi/spi_mcux_flexio.c
Outdated
| @@ -206,6 +206,24 @@ static void spi_flexio_master_init(FLEXIO_SPI_Type *base, flexio_spi_master_conf | |||
| timerConfig.timerStart = kFLEXIO_TimerStartBitEnabled; | |||
| /* Low 8-bits are used to configure baudrate. */ | |||
| timerDiv = (uint16_t)(srcClock_Hz / masterConfig->baudRate_Bps); | |||
|
|
|||
| /* Add protection if bandrate required is overflow. | |||
| * FLEXIO input freq can not meet required bandrate. Max bandrate can | |||
There was a problem hiding this comment.
Suggested change
| * FLEXIO input freq can not meet required bandrate. Max bandrate can | |
| * FLEXIO input freq cannot meet required baud rate. Max baud rate can |
| /* Add protection if bandrate required is overflow. | ||
| * FLEXIO input freq can not meet required bandrate. Max bandrate can | ||
| * not exceed 1/4 of input freq. You can raise input freq or lower | ||
| * bandrate required to remove this warning. |
There was a problem hiding this comment.
Suggested change
| * bandrate required to remove this warning. | |
| * baud rate required to remove this warning. |
Apply everywhere.
soc/nxp/imxrt/imxrt10xx/soc.c
Outdated
| @@ -215,6 +215,18 @@ __weak void clock_init(void) | |||
| CLOCK_SetDiv(kCLOCK_LpspiDiv, 0); /* Set SPI divider to 1 */ | |||
| #endif | |||
|
|
|||
| #ifdef CONFIG_MCUX_FLEXIO | |||
| /* Configure input clock to be able to reach the datasheet specified band rate. | |||
There was a problem hiding this comment.
Suggested change
| /* Configure input clock to be able to reach the datasheet specified band rate. | |
| /* Configure input clock to be able to reach the datasheet specified baud rate. |
Several reason cause loopback test failed: a) FlexIO input frequency is not correct, on RT11xx, input freq is 24M, while max bandrate can reach 1/4 of input freq, so it can only support 6Mbps. b) Flexio shift register depend on correct timer output to triggger TX and TX, if timer comparison value is not accurate, RX error happens on high band rate. This is the reason why test fails on RT1060. also fix a error on FlexIO clock ID calculation. Signed-off-by: Raymond Lei <[email protected]>
Raymond0225
force-pushed
the
flexIO_spi_input_freq_fix
branch
from
17d6aa5 to
15439f7
Compare
Raymond0225
force-pushed
the
flexIO_spi_input_freq_fix
branch
from
15439f7 to
79f39f0
Compare
Add overlay file for RT1170 EVK and simply existing flexio spi overlay file for RT1060 EVKC and RT1064 EVK. One flexio-spi interface for both slow and fast tests. Fast bandrate set to 16Mbps now. Signed-off-by: Raymond Lei <[email protected]>
Raymond0225
force-pushed
the
flexIO_spi_input_freq_fix
branch
from
79f39f0 to
457bbe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: drivers: spi_loopback: Flexio spi support for RT1060 EVKC and RT1170 EVK
fix this issue: #77992