Skip to content

Flexio SPI loopback test failed on fast speed(16Mbps) #88877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+125 −39
Open

Flexio SPI loopback test failed on fast speed(16Mbps) #88877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82ef24b
drivers: spi: nxp: flexiospi spi_loopback test failed on flexio spi
Raymond0225 Apr 18, 2025
457bbe3
test: spi_loopback: nxp: Add Flexio spi test support
Raymond0225 Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions drivers/clock_control/clock_control_mcux_ccm_rev2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,11 +225,8 @@ static int mcux_ccm_get_subsys_rate(const struct device *dev,
#endif

#ifdef CONFIG_MCUX_FLEXIO
case IMX_CCM_FLEXIO1_CLK:
clock_root = kCLOCK_Root_Flexio1;
break;
case IMX_CCM_FLEXIO2_CLK:
clock_root = kCLOCK_Root_Flexio2;
case IMX_CCM_FLEXIO_CLK:
clock_root = kCLOCK_Root_Flexio1 + instance;
break;
#endif

Expand Down
18 changes: 18 additions & 0 deletions drivers/spi/spi_mcux_flexio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,24 @@ static void spi_flexio_master_init(FLEXIO_SPI_Type *base, flexio_spi_master_conf
timerConfig.timerStart = kFLEXIO_TimerStartBitEnabled;
/* Low 8-bits are used to configure baudrate. */
timerDiv = (uint16_t)(srcClock_Hz / masterConfig->baudRate_Bps);

/* Add protection if the required band rate overflows.
* FLEXIO input freq can't meet required band rate. Max band rate can
* not exceed 1/4 of input freq. You can raise input freq or lower
* bandrate required to remove this warning.
Copy link
Collaborator

@JarmouniA JarmouniA Apr 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* bandrate required to remove this warning.
* baud rate required to remove this warning.

Apply everywhere.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not addressed

*/
if (timerDiv < 4) {
timerDiv = 4;
}
/* If timeDiv is odd, get it to even. */
timerDiv += timerDiv & 1UL;

if (masterConfig->baudRate_Bps != (srcClock_Hz / timerDiv)) {
LOG_WRN("Bandrate req:%uKbps, got:%uKbps",
(uint32_t)(masterConfig->baudRate_Bps / 1000),
(uint32_t)(srcClock_Hz / (timerDiv*1000)));
}

timerDiv = timerDiv / 2U - 1U;
/* High 8-bits are used to configure shift clock edges(transfer width). */
timerCmp = ((uint16_t)masterConfig->dataMode * 2U - 1U) << 8U;
Expand Down
12 changes: 12 additions & 0 deletions soc/nxp/imxrt/imxrt10xx/soc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,18 @@ __weak void clock_init(void)
CLOCK_SetDiv(kCLOCK_LpspiDiv, 0); /* Set SPI divider to 1 */
#endif

#ifdef CONFIG_MCUX_FLEXIO
/* Configure input clock to be able to reach the datasheet specified baud rate.
* FLEXIO can reach to 120MHz. Select USB pll(480M) as source and divide by 2.
* pre divider by default is 1 which means divide by 2.
*/
CLOCK_SetMux(kCLOCK_Flexio1Mux, 3);
CLOCK_SetDiv(kCLOCK_Flexio1Div, 1);

CLOCK_SetMux(kCLOCK_Flexio2Mux, 3);
CLOCK_SetDiv(kCLOCK_Flexio2Div, 1);
#endif

#ifdef CONFIG_DISPLAY_MCUX_ELCDIF
/* MUX selects video PLL, which is initialized to 93MHz */
CLOCK_SetMux(kCLOCK_LcdifPreMux, 2);
Expand Down
12 changes: 12 additions & 0 deletions soc/nxp/imxrt/imxrt11xx/soc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,18 @@ __weak void clock_init(void)
CLOCK_SetRootClock(kCLOCK_Root_Lpuart2, &rootCfg);
#endif

#ifdef CONFIG_MCUX_FLEXIO
/* Configure flexio1 with oscRC400M */
rootCfg.mux = kCLOCK_FLEXIO1_ClockRoot_MuxOscRc400M;
rootCfg.div = 2;
CLOCK_SetRootClock(kCLOCK_Root_Flexio1, &rootCfg);

/* Configure flexio2 using oscRC400M */
rootCfg.mux = kCLOCK_FLEXIO2_ClockRoot_MuxOscRc400M;
rootCfg.div = 2;
CLOCK_SetRootClock(kCLOCK_Root_Flexio2, &rootCfg);
#endif

#ifdef CONFIG_I2C_MCUX_LPI2C
/* Configure Lpi2c1 using Osc48MDiv2 */
rootCfg.mux = kCLOCK_LPI2C1_ClockRoot_MuxOscRc48MDiv2;
Expand Down
55 changes: 55 additions & 0 deletions tests/drivers/spi/spi_loopback/boards/mimxrt1170_evk_mimxrt1176_cm7_flexio_spi.overlay
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
/*
* Copyright 2025 NXP
*
* SPDX-License-Identifier: Apache-2.0
*/

&lpspi1 {
dmas = <&edma0 0 36>, <&edma0 1 37>;
dma-names = "rx", "tx";
status = "disabled";
};


&pinctrl {
pinmux_flexio2spi1: pinmux_flexio2spi1 {
group0 {
pinmux = <&iomuxc_gpio_ad_29_gpio9_io28>, /* cs */
<&iomuxc_gpio_ad_28_flexio2_flexio28>, /* sck */
<&iomuxc_gpio_ad_30_flexio2_flexio30>, /* sdo */
<&iomuxc_gpio_ad_31_flexio2_flexio31>; /* sdi */
drive-strength = "high";
slew-rate = "slow";

};
};
};


&flexio2 {
status = "okay";

flexio2spi1: flexio2spi1 {
compatible = "nxp,flexio-spi";
cs-gpios = <&gpio9 28 GPIO_ACTIVE_LOW>;
#address-cells = <1>;
#size-cells = <0>;
sdo-pin = <30>;
sdi-pin = <31>;
sck-pin = <28>;
pinctrl-0 = <&pinmux_flexio2spi1>;
pinctrl-names = "default";
status = "okay";

slow@0 {
compatible = "test-spi-loopback-slow";
reg = <0>;
spi-max-frequency = <500000>;
};
fast@0 {
compatible = "test-spi-loopback-fast";
reg = <0>;
spi-max-frequency = <16000000>;
};
};
};
44 changes: 11 additions & 33 deletions tests/drivers/spi/spi_loopback/overlay-mcux-flexio-spi.overlay
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,27 @@
/*
* Copyright (c) 2024, STRIM, ALC
*
* Copyright (c) 2025, NXP
* SPDX-License-Identifier: Apache-2.0
*/

/* On RT1060 EVKC, SPI loopback test, short J17-9 and J17-10
* On RT1064 EVK, SPI loopback test, short J24-9 and J24-10
*/

&pinctrl {
pinmux_flexio3spi0: pinmux_flexio3spi0 {
group0 {
pinmux =
<&iomuxc_gpio_ad_b0_03_gpio1_io03>, /* cs */
<&iomuxc_gpio_ad_b1_10_flexio3_flexio10>, /* sck */
<&iomuxc_gpio_ad_b1_01_flexio3_flexio01>, /* sdo */
<&iomuxc_gpio_ad_b1_04_flexio3_flexio04>; /* sdi */
drive-strength = "r0-6";
slew-rate = "slow";
nxp,speed = "150-mhz";
};
};
pinmux_flexio3spi1: pinmux_flexio3spi1 {
group0 {
pinmux =
<&iomuxc_gpio_ad_b0_02_gpio1_io02>, /* cs */
<&iomuxc_gpio_ad_b1_11_flexio3_flexio11>, /* sck */
<&iomuxc_gpio_ad_b1_00_flexio3_flexio00>, /* sdo */
<&iomuxc_gpio_ad_b1_05_flexio3_flexio05>; /* sdi */
<&iomuxc_gpio_ad_b1_01_flexio3_flexio01>; /* sdi */
drive-strength = "r0-6";
slew-rate = "slow";
nxp,speed = "150-mhz";
};
};

};

&flexio3 {
Expand All @@ -39,8 +32,8 @@
#address-cells = <1>;
#size-cells = <0>;
cs-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>;
sdo-pin = <1>;
sdi-pin = <4>;
sdo-pin = <0>;
sdi-pin = <1>;
sck-pin = <10>;
pinctrl-0 = <&pinmux_flexio3spi0>;
pinctrl-names = "default";
Expand All @@ -50,28 +43,13 @@
reg = <0>;
spi-max-frequency = <500000>;
};
};
flexio3_spi1: flexio3_spi1 {
compatible = "nxp,flexio-spi";
status = "okay";
#address-cells = <1>;
#size-cells = <0>;
cs-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
sdo-pin = <0>;
sdi-pin = <5>;
sck-pin = <11>;
pinctrl-0 = <&pinmux_flexio3spi1>;
pinctrl-names = "default";

fast@0 {
status = "okay";
compatible = "test-spi-loopback-fast";
reg = <0>;
spi-max-frequency = <4000000>;
spi-max-frequency = <16000000>;
};
};
};

/* pinmux_lpspi3 overlaps pinmux_flexio3spi1 */
&lpspi3 {
status = "disabled";
};
16 changes: 15 additions & 1 deletion tests/drivers/spi/spi_loopback/testcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,12 +222,26 @@ tests:
extra_args: DTC_OVERLAY_FILE="overlay-mcux-flexio-spi.overlay"
filter: CONFIG_DT_HAS_NXP_FLEXIO_ENABLED and
CONFIG_DT_HAS_NXP_FLEXIO_SPI_ENABLED
platform_allow: mimxrt1064_evk
platform_allow:
- mimxrt1064_evk
- mimxrt1060_evk/mimxrt1062/qspi
- mimxrt1060_evk@B/mimxrt1062/qspi
- mimxrt1060_evk@C/mimxrt1062/qspi

drivers.spi.mimxrt1170_evk_mimxrt1176_cm7_flexio_spi.loopback:
extra_args: DTC_OVERLAY_FILE="boards/mimxrt1170_evk_mimxrt1176_cm7_flexio_spi.overlay"
filter: CONFIG_DT_HAS_NXP_FLEXIO_ENABLED and
CONFIG_DT_HAS_NXP_FLEXIO_SPI_ENABLED
platform_allow:
- mimxrt1170_evk@A/mimxrt1176/cm7
- mimxrt1170_evk@B/mimxrt1176/cm7

drivers.spi.mimxrt1040evk_flexio_spi.loopback:
extra_args: DTC_OVERLAY_FILE="boards/mimxrt1040_evk_flexio_spi.overlay"
filter: CONFIG_DT_HAS_NXP_FLEXIO_ENABLED and
CONFIG_DT_HAS_NXP_FLEXIO_SPI_ENABLED
platform_allow: mimxrt1040_evk

drivers.spi.nrf54h_fast_8mhz:
extra_args: DTC_OVERLAY_FILE="boards/nrf54h20dk_nrf54h20_cpuapp_fast.overlay"
platform_allow:
Expand Down