[msal-node] Cache-1: Msal node cache entities #1444
Conversation
There was a problem hiding this comment.
Looks good. A couple of small comments. Also, I think it would be clearer if we named some of the classes under the entities directory (like AccessTokenCache, AppMetadataCache, etc) AccessTokenCacheEntitiy, AppMetadataEntity, etc, as it denotes that it's a singular entry vs the whole cache. We can discuss this as a group though before making the change.
|
Thanks @sangonzal, regarding the naming, I agree with you, I wasn't a fan of the name as it was too long but may be we should add it to be accurate. |
…sal-node-authority
[msal-node] Cache-4: ResponseHandler added to `msal-common`
[msal-node] Cache-3: Add NodeStorage, token generation and separate SPAresponse
[msal-node] Cache-2: Msal node cache serialization and helpers
Remove file read and write from node lib
[msal-node]Cache-6: Read and write to disk, merge cache
…/microsoft-authentication-library-for-js into msal-node-cache-entities
|
@jasonnutter Since I got a verbal ACK last time on this PR, I am merging this. If there are any comments, future PRs can attest to them. Since we have too many changes to be pushed to dev going forward, I did not want to wait. Thanks. |
This is the first PR for "Cache" supporting UnifiedSchema for
msal-node.This PR adds cache entries for the below entities:Tests added.
AccountEntityis not 100% covered, and will be added in a follow-up PR.