Remove old context propagation API #8271

PerfectSlayer · 2025-01-23T09:28:20Z

What Does This Do

This PR refactors the original AgentPropagation to:

Replace AgentPropagation.Setter by ContextSetter
Remove the AgentTracer.propagate()
Transform AgentPropagation to an helper class and rename extract() to extractContextAndGetSpanContext() to explicit it extracts everything but drops all except span context.
Refactor ApmTracingDisabledPropagator into TracingPropagator

Motivation

Clean up most of the AgentPropagation old API.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: LANGPLAT-303

internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentTracer.java

pr-commenter · 2025-01-23T10:32:55Z

Kafka / producer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context-propagation
git_commit_date	1740389515	1740475386
git_commit_sha	`2d7d791`	`6750ca1`

See matching parameters

	Baseline	Candidate
ci_job_date	1740476629	1740476629
ci_job_id	821438711	821438711
ci_pipeline_id	56849364	56849364
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce	same

pr-commenter · 2025-01-23T10:37:18Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context-propagation
git_commit_date	1740435079	1740475386
git_commit_sha	`c643643`	`6750ca1`
release_version	1.47.0-SNAPSHOT~c643643e68	1.47.0-SNAPSHOT~6750ca17fc

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1740477803	1740477803
ci_job_id	821438705	821438705
ci_pipeline_id	56849364	56849364
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-guxxpazr-project-304-concurrent-0-ihkevyz9 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-guxxpazr-project-304-concurrent-0-ihkevyz9 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 56 metrics, 6 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:AppSec	worse [+1.137ms; +6.441ms] or [+2.100%; +11.894%]	57.945ms	54.155ms

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~6750ca17fc, baseline=1.47.0-SNAPSHOT~c643643e68

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.034 s) : 0, 1033892
Total [baseline] (8.646 s) : 0, 8646423
Agent [candidate] (1.057 s) : 0, 1056921
Total [candidate] (8.721 s) : 0, 8721447
section iast
Agent [baseline] (1.169 s) : 0, 1168544
Total [baseline] (9.24 s) : 0, 9240177
Agent [candidate] (1.174 s) : 0, 1174101
Total [candidate] (9.209 s) : 0, 9208523
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1171497
Total [baseline] (9.194 s) : 0, 9194251
Agent [candidate] (1.171 s) : 0, 1170511
Total [candidate] (9.18 s) : 0, 9179909
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1175980
Total [baseline] (9.206 s) : 0, 9206090
Agent [candidate] (1.176 s) : 0, 1175566
Total [candidate] (9.224 s) : 0, 9224344

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.034 s	-
Agent	iast	1.169 s	134.652 ms (13.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.171 s	137.605 ms (13.3%)
Agent	iast_TELEMETRY_OFF	1.176 s	142.087 ms (13.7%)
Total	tracing	8.646 s	-
Total	iast	9.24 s	593.754 ms (6.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.194 s	547.828 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.206 s	559.667 ms (6.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	iast	1.174 s	117.18 ms (11.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.171 s	113.59 ms (10.7%)
Agent	iast_TELEMETRY_OFF	1.176 s	118.644 ms (11.2%)
Total	tracing	8.721 s	-
Total	iast	9.209 s	487.076 ms (5.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.18 s	458.462 ms (5.3%)
Total	iast_TELEMETRY_OFF	9.224 s	502.897 ms (5.8%)

gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~6750ca17fc, baseline=1.47.0-SNAPSHOT~c643643e68

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.296 ms) : 0, 713296
BytebuddyAgent [candidate] (730.236 ms) : 0, 730236
GlobalTracer [baseline] (238.207 ms) : 0, 238207
GlobalTracer [candidate] (242.799 ms) : 0, 242799
AppSec [baseline] (55.991 ms) : 0, 55991
AppSec [candidate] (56.105 ms) : 0, 56105
Remote Config [baseline] (699.896 µs) : 0, 700
Remote Config [candidate] (704.666 µs) : 0, 705
Telemetry [baseline] (10.876 ms) : 0, 10876
Telemetry [candidate] (11.585 ms) : 0, 11585
section iast
BytebuddyAgent [baseline] (834.492 ms) : 0, 834492
BytebuddyAgent [candidate] (839.154 ms) : 0, 839154
GlobalTracer [baseline] (229.688 ms) : 0, 229688
GlobalTracer [candidate] (229.918 ms) : 0, 229918
IAST [baseline] (22.756 ms) : 0, 22756
IAST [candidate] (22.83 ms) : 0, 22830
AppSec [baseline] (57.264 ms) : 0, 57264
AppSec [candidate] (57.546 ms) : 0, 57546
Remote Config [baseline] (615.785 µs) : 0, 616
Remote Config [candidate] (608.944 µs) : 0, 609
Telemetry [baseline] (8.815 ms) : 0, 8815
Telemetry [candidate] (8.711 ms) : 0, 8711
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.625 ms) : 0, 836625
BytebuddyAgent [candidate] (835.8 ms) : 0, 835800
GlobalTracer [baseline] (230.203 ms) : 0, 230203
GlobalTracer [candidate] (229.693 ms) : 0, 229693
IAST [baseline] (23.046 ms) : 0, 23046
IAST [candidate] (22.921 ms) : 0, 22921
AppSec [baseline] (57.256 ms) : 0, 57256
AppSec [candidate] (57.351 ms) : 0, 57351
Remote Config [baseline] (628.099 µs) : 0, 628
Remote Config [candidate] (609.258 µs) : 0, 609
Telemetry [baseline] (8.768 ms) : 0, 8768
Telemetry [candidate] (8.794 ms) : 0, 8794
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (840.583 ms) : 0, 840583
BytebuddyAgent [candidate] (839.58 ms) : 0, 839580
GlobalTracer [baseline] (231.237 ms) : 0, 231237
GlobalTracer [candidate] (230.86 ms) : 0, 230860
IAST [baseline] (25.649 ms) : 0, 25649
IAST [candidate] (22.507 ms) : 0, 22507
AppSec [baseline] (54.155 ms) : 0, 54155
AppSec [candidate] (57.945 ms) : 0, 57945
Remote Config [baseline] (614.785 µs) : 0, 615
Remote Config [candidate] (625.487 µs) : 0, 625
Telemetry [baseline] (8.594 ms) : 0, 8594
Telemetry [candidate] (8.691 ms) : 0, 8691

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~6750ca17fc, baseline=1.47.0-SNAPSHOT~c643643e68

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043839
Total [baseline] (10.381 s) : 0, 10380802
Agent [candidate] (1.04 s) : 0, 1040131
Total [candidate] (10.413 s) : 0, 10413418
section appsec
Agent [baseline] (1.181 s) : 0, 1181219
Total [baseline] (10.773 s) : 0, 10773133
Agent [candidate] (1.182 s) : 0, 1182164
Total [candidate] (10.743 s) : 0, 10743272
section iast
Agent [baseline] (1.175 s) : 0, 1175163
Total [baseline] (11.005 s) : 0, 11005134
Agent [candidate] (1.171 s) : 0, 1171481
Total [candidate] (10.967 s) : 0, 10966724
section profiling
Agent [baseline] (1.268 s) : 0, 1267860
Total [baseline] (10.833 s) : 0, 10833004
Agent [candidate] (1.256 s) : 0, 1256360
Total [candidate] (10.853 s) : 0, 10853161

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	appsec	1.181 s	137.38 ms (13.2%)
Agent	iast	1.175 s	131.325 ms (12.6%)
Agent	profiling	1.268 s	224.021 ms (21.5%)
Total	tracing	10.381 s	-
Total	appsec	10.773 s	392.331 ms (3.8%)
Total	iast	11.005 s	624.332 ms (6.0%)
Total	profiling	10.833 s	452.201 ms (4.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.04 s	-
Agent	appsec	1.182 s	142.033 ms (13.7%)
Agent	iast	1.171 s	131.35 ms (12.6%)
Agent	profiling	1.256 s	216.229 ms (20.8%)
Total	tracing	10.413 s	-
Total	appsec	10.743 s	329.854 ms (3.2%)
Total	iast	10.967 s	553.306 ms (5.3%)
Total	profiling	10.853 s	439.744 ms (4.2%)

gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~6750ca17fc, baseline=1.47.0-SNAPSHOT~c643643e68

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.909 ms) : 0, 718909
BytebuddyAgent [candidate] (717.568 ms) : 0, 717568
GlobalTracer [baseline] (239.196 ms) : 0, 239196
GlobalTracer [candidate] (239.188 ms) : 0, 239188
AppSec [baseline] (55.622 ms) : 0, 55622
AppSec [candidate] (55.327 ms) : 0, 55327
Remote Config [baseline] (699.054 µs) : 0, 699
Remote Config [candidate] (691.697 µs) : 0, 692
Telemetry [baseline] (14.367 ms) : 0, 14367
Telemetry [candidate] (12.185 ms) : 0, 12185
section appsec
BytebuddyAgent [baseline] (733.667 ms) : 0, 733667
BytebuddyAgent [candidate] (734.764 ms) : 0, 734764
GlobalTracer [baseline] (235.807 ms) : 0, 235807
GlobalTracer [candidate] (235.806 ms) : 0, 235806
AppSec [baseline] (177.258 ms) : 0, 177258
AppSec [candidate] (176.852 ms) : 0, 176852
Remote Config [baseline] (656.415 µs) : 0, 656
Remote Config [candidate] (654.849 µs) : 0, 655
Telemetry [baseline] (8.235 ms) : 0, 8235
Telemetry [candidate] (8.215 ms) : 0, 8215
IAST [baseline] (21.478 ms) : 0, 21478
IAST [candidate] (21.375 ms) : 0, 21375
section iast
BytebuddyAgent [baseline] (839.863 ms) : 0, 839863
BytebuddyAgent [candidate] (836.705 ms) : 0, 836705
GlobalTracer [baseline] (230.106 ms) : 0, 230106
GlobalTracer [candidate] (229.878 ms) : 0, 229878
AppSec [baseline] (57.606 ms) : 0, 57606
AppSec [candidate] (57.511 ms) : 0, 57511
Remote Config [baseline] (630.111 µs) : 0, 630
Remote Config [candidate] (615.154 µs) : 0, 615
Telemetry [baseline] (8.736 ms) : 0, 8736
Telemetry [candidate] (8.682 ms) : 0, 8682
IAST [baseline] (23.007 ms) : 0, 23007
IAST [candidate] (22.825 ms) : 0, 22825
section profiling
BytebuddyAgent [baseline] (714.044 ms) : 0, 714044
BytebuddyAgent [candidate] (705.973 ms) : 0, 705973
GlobalTracer [baseline] (352.066 ms) : 0, 352066
GlobalTracer [candidate] (348.717 ms) : 0, 348717
AppSec [baseline] (55.216 ms) : 0, 55216
AppSec [candidate] (54.579 ms) : 0, 54579
Remote Config [baseline] (681.75 µs) : 0, 682
Remote Config [candidate] (659.321 µs) : 0, 659
Telemetry [baseline] (8.979 ms) : 0, 8979
Telemetry [candidate] (8.951 ms) : 0, 8951
ProfilingAgent [baseline] (96.291 ms) : 0, 96291
ProfilingAgent [candidate] (95.402 ms) : 0, 95402
Profiling [baseline] (96.315 ms) : 0, 96315
Profiling [candidate] (95.426 ms) : 0, 95426

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-25T09:36:58	2025-02-25T09:44:42
git_branch	master	bbujon/context-propagation
git_commit_date	1740435079	1740475386
git_commit_sha	`c643643`	`6750ca1`
release_version	1.47.0-SNAPSHOT~c643643e68	1.47.0-SNAPSHOT~6750ca17fc
start_time	2025-02-25T09:36:44	2025-02-25T09:44:28

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1740477084	1740477084
ci_job_id	821438706	821438706
ci_pipeline_id	56849364	56849364
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-2zx7sypg-project-304-concurrent-0-88ebzt84 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-2zx7sypg-project-304-concurrent-0-88ebzt84 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 13 metrics, 16 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	worse [+43.956µs; +95.831µs] or [+2.934%; +6.396%]	unstable [-693.824op/s; +465.904op/s] or [-22.549%; +15.142%]	1.568ms	2962.963op/s	1.498ms	3076.923op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6750ca17fc, baseline=1.47.0-SNAPSHOT~c643643e68
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.012 µs) : 358, 398
.   : milestone, 378,
iast (508.479 µs) : 487, 530
.   : milestone, 508,
iast_FULL (725.754 µs) : 704, 748
.   : milestone, 726,
iast_GLOBAL (558.775 µs) : 536, 582
.   : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (509.161 µs) : 487, 532
.   : milestone, 509,
iast_INACTIVE (463.9 µs) : 443, 485
.   : milestone, 464,
iast_TELEMETRY_OFF (500.522 µs) : 477, 524
.   : milestone, 501,
tracing (460.369 µs) : 439, 482
.   : milestone, 460,
section candidate
no_agent (380.654 µs) : 361, 401
.   : milestone, 381,
iast (510.839 µs) : 489, 533
.   : milestone, 511,
iast_FULL (728.904 µs) : 707, 751
.   : milestone, 729,
iast_GLOBAL (554.429 µs) : 533, 576
.   : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (510.568 µs) : 489, 532
.   : milestone, 511,
iast_INACTIVE (459.91 µs) : 439, 481
.   : milestone, 460,
iast_TELEMETRY_OFF (497.382 µs) : 475, 519
.   : milestone, 497,
tracing (453.49 µs) : 433, 474
.   : milestone, 453,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.012 µs [358.087 µs, 397.936 µs]	-
iast	508.479 µs [486.649 µs, 530.309 µs]	130.467 µs (34.5%)
iast_FULL	725.754 µs [703.713 µs, 747.796 µs]	347.743 µs (92.0%)
iast_GLOBAL	558.775 µs [535.525 µs, 582.026 µs]	180.764 µs (47.8%)
iast_HARDCODED_SECRET_DISABLED	509.161 µs [486.711 µs, 531.612 µs]	131.15 µs (34.7%)
iast_INACTIVE	463.9 µs [442.878 µs, 484.923 µs]	85.888 µs (22.7%)
iast_TELEMETRY_OFF	500.522 µs [477.055 µs, 523.989 µs]	122.51 µs (32.4%)
tracing	460.369 µs [438.547 µs, 482.191 µs]	82.358 µs (21.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.654 µs [360.67 µs, 400.639 µs]	-
iast	510.839 µs [489.057 µs, 532.622 µs]	130.185 µs (34.2%)
iast_FULL	728.904 µs [706.915 µs, 750.892 µs]	348.249 µs (91.5%)
iast_GLOBAL	554.429 µs [532.922 µs, 575.935 µs]	173.774 µs (45.7%)
iast_HARDCODED_SECRET_DISABLED	510.568 µs [488.881 µs, 532.255 µs]	129.913 µs (34.1%)
iast_INACTIVE	459.91 µs [438.963 µs, 480.857 µs]	79.255 µs (20.8%)
iast_TELEMETRY_OFF	497.382 µs [475.274 µs, 519.49 µs]	116.728 µs (30.7%)
tracing	453.49 µs [433.046 µs, 473.934 µs]	72.836 µs (19.1%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6750ca17fc, baseline=1.47.0-SNAPSHOT~c643643e68
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.351 ms) : 1331, 1371
.   : milestone, 1351,
appsec (1.765 ms) : 1741, 1789
.   : milestone, 1765,
appsec_no_iast (1.732 ms) : 1707, 1756
.   : milestone, 1732,
code_origins (1.69 ms) : 1656, 1724
.   : milestone, 1690,
iast (1.505 ms) : 1481, 1529
.   : milestone, 1505,
profiling (1.498 ms) : 1474, 1522
.   : milestone, 1498,
tracing (1.501 ms) : 1477, 1524
.   : milestone, 1501,
section candidate
no_agent (1.366 ms) : 1347, 1386
.   : milestone, 1366,
appsec (1.756 ms) : 1732, 1779
.   : milestone, 1756,
appsec_no_iast (1.745 ms) : 1720, 1769
.   : milestone, 1745,
code_origins (1.704 ms) : 1672, 1737
.   : milestone, 1704,
iast (1.5 ms) : 1475, 1524
.   : milestone, 1500,
profiling (1.568 ms) : 1544, 1592
.   : milestone, 1568,
tracing (1.513 ms) : 1489, 1537
.   : milestone, 1513,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.331 ms, 1.371 ms]	-
appsec	1.765 ms [1.741 ms, 1.789 ms]	414.603 µs (30.7%)
appsec_no_iast	1.732 ms [1.707 ms, 1.756 ms]	381.103 µs (28.2%)
code_origins	1.69 ms [1.656 ms, 1.724 ms]	339.231 µs (25.1%)
iast	1.505 ms [1.481 ms, 1.529 ms]	154.533 µs (11.4%)
profiling	1.498 ms [1.474 ms, 1.522 ms]	147.602 µs (10.9%)
tracing	1.501 ms [1.477 ms, 1.524 ms]	149.839 µs (11.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.366 ms [1.347 ms, 1.386 ms]	-
appsec	1.756 ms [1.732 ms, 1.779 ms]	389.527 µs (28.5%)
appsec_no_iast	1.745 ms [1.72 ms, 1.769 ms]	378.355 µs (27.7%)
code_origins	1.704 ms [1.672 ms, 1.737 ms]	338.146 µs (24.7%)
iast	1.5 ms [1.475 ms, 1.524 ms]	133.225 µs (9.8%)
profiling	1.568 ms [1.544 ms, 1.592 ms]	201.838 µs (14.8%)
tracing	1.513 ms [1.489 ms, 1.537 ms]	146.57 µs (10.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context-propagation
git_commit_date	1740435079	1740475386
git_commit_sha	`c643643`	`6750ca1`
release_version	1.47.0-SNAPSHOT~c643643e68	1.47.0-SNAPSHOT~6750ca17fc

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1740477479	1740477479
ci_job_id	821438707	821438707
ci_pipeline_id	56849364	56849364
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-guxxpazr-project-304-concurrent-1-ozf812sy 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-guxxpazr-project-304-concurrent-1-ozf812sy 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6750ca17fc, baseline=1.47.0-SNAPSHOT~c643643e68
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.359 ms) : 2316, 2402
.   : milestone, 2359,
iast (2.097 ms) : 2042, 2152
.   : milestone, 2097,
iast_GLOBAL (2.147 ms) : 2092, 2203
.   : milestone, 2147,
profiling (1.968 ms) : 1924, 2011
.   : milestone, 1968,
tracing (1.936 ms) : 1893, 1978
.   : milestone, 1936,
section candidate
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.342 ms) : 2299, 2385
.   : milestone, 2342,
iast (2.109 ms) : 2053, 2164
.   : milestone, 2109,
iast_GLOBAL (2.143 ms) : 2088, 2198
.   : milestone, 2143,
profiling (1.957 ms) : 1913, 2000
.   : milestone, 1957,
tracing (1.953 ms) : 1910, 1996
.   : milestone, 1953,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.455 ms, 1.478 ms]	-
appsec	2.359 ms [2.316 ms, 2.402 ms]	892.2 µs (60.8%)
iast	2.097 ms [2.042 ms, 2.152 ms]	630.419 µs (43.0%)
iast_GLOBAL	2.147 ms [2.092 ms, 2.203 ms]	680.88 µs (46.4%)
profiling	1.968 ms [1.924 ms, 2.011 ms]	501.051 µs (34.2%)
tracing	1.936 ms [1.893 ms, 1.978 ms]	468.919 µs (32.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.456 ms, 1.479 ms]	-
appsec	2.342 ms [2.299 ms, 2.385 ms]	874.413 µs (59.6%)
iast	2.109 ms [2.053 ms, 2.164 ms]	641.119 µs (43.7%)
iast_GLOBAL	2.143 ms [2.088 ms, 2.198 ms]	675.668 µs (46.0%)
profiling	1.957 ms [1.913 ms, 2.0 ms]	489.323 µs (33.3%)
tracing	1.953 ms [1.91 ms, 1.996 ms]	485.55 µs (33.1%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6750ca17fc, baseline=1.47.0-SNAPSHOT~c643643e68
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.457 s) : 15457000, 15457000
.   : milestone, 15457000,
appsec (14.851 s) : 14851000, 14851000
.   : milestone, 14851000,
iast (18.642 s) : 18642000, 18642000
.   : milestone, 18642000,
iast_GLOBAL (18.02 s) : 18020000, 18020000
.   : milestone, 18020000,
profiling (15.641 s) : 15641000, 15641000
.   : milestone, 15641000,
tracing (15.042 s) : 15042000, 15042000
.   : milestone, 15042000,
section candidate
no_agent (15.306 s) : 15306000, 15306000
.   : milestone, 15306000,
appsec (15.142 s) : 15142000, 15142000
.   : milestone, 15142000,
iast (18.385 s) : 18385000, 18385000
.   : milestone, 18385000,
iast_GLOBAL (17.855 s) : 17855000, 17855000
.   : milestone, 17855000,
profiling (15.235 s) : 15235000, 15235000
.   : milestone, 15235000,
tracing (15.095 s) : 15095000, 15095000
.   : milestone, 15095000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.457 s [15.457 s, 15.457 s]	-
appsec	14.851 s [14.851 s, 14.851 s]	-606.0 ms (-3.9%)
iast	18.642 s [18.642 s, 18.642 s]	3.185 s (20.6%)
iast_GLOBAL	18.02 s [18.02 s, 18.02 s]	2.563 s (16.6%)
profiling	15.641 s [15.641 s, 15.641 s]	184.0 ms (1.2%)
tracing	15.042 s [15.042 s, 15.042 s]	-415.0 ms (-2.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.306 s [15.306 s, 15.306 s]	-
appsec	15.142 s [15.142 s, 15.142 s]	-164.0 ms (-1.1%)
iast	18.385 s [18.385 s, 18.385 s]	3.079 s (20.1%)
iast_GLOBAL	17.855 s [17.855 s, 17.855 s]	2.549 s (16.7%)
profiling	15.235 s [15.235 s, 15.235 s]	-71.0 ms (-0.5%)
tracing	15.095 s [15.095 s, 15.095 s]	-211.0 ms (-1.4%)

pr-commenter · 2025-01-23T10:47:24Z

Kafka / consumer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context-propagation
git_commit_date	1740389515	1740475386
git_commit_sha	`2d7d791`	`6750ca1`

See matching parameters

	Baseline	Candidate
ci_job_date	1740476588	1740476588
ci_job_id	821438713	821438713
ci_pipeline_id	56849364	56849364
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same

internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentPropagation.java

.../aws-java-sqs-2.0/src/main/java/datadog/trace/instrumentation/aws/v2/sqs/SqsInterceptor.java

dd-trace-core/src/main/java/datadog/trace/core/datastreams/DataStreamContext.java

internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/BlackHoleSpan.java

internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/ExtractedSpan.java

internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/NoopSpan.java

internal-api/src/main/java/datadog/trace/api/datastreams/DataStreamsContext.java

internal-api/src/main/java/datadog/trace/api/datastreams/NoopPathwayContext.java

internal-api/src/main/java/datadog/trace/api/datastreams/NoopDataStreamsMonitoring.java

internal-api/src/main/java/datadog/trace/api/datastreams/NoopPathwayContext.java

internal-api/src/main/java/datadog/trace/api/datastreams/NoopDataStreamsMonitoring.java

internal-api/src/main/java/datadog/trace/api/datastreams/DataStreamsContext.java

internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentPropagation.java

datadog-datadog-prod-us1 · 2025-02-12T14:32:06Z

dd-trace-core/src/main/java/datadog/trace/core/propagation/HttpCodec.java

@@ -51,8 +52,7 @@ public class HttpCodec {
  static final String CF_CONNECTING_IP_V6_KEY = "cf-connecting-ipv6";

  public interface Injector {
-    <C> void inject(
-        final DDSpanContext context, final C carrier, final AgentPropagation.Setter<C> setter);
+    <C> void inject(final DDSpanContext context, final C carrier, final CarrierSetter<C> setter);


⚪ Code Quality Violation

Suggested change

<C> void inject(final DDSpanContext context, final C carrier, final CarrierSetter<C> setter);

<C> void inject(DDSpanContext context, final C carrier, final CarrierSetter<C> setter);

Avoid declaring as final as it may not be used (...read more)

The rule "Avoid useless final type in interface method" advises against the unnecessary use of the final keyword in the method parameters of an interface. In Java, the final keyword is used to denote that a variable cannot be changed once assigned. However, in the context of an interface method, this is redundant as the value of the parameter cannot be changed within the method anyway.

The importance of this rule lies in the clarity and simplicity of code. Unnecessary use of final in this context can lead to confusion for those reading the code, as it suggests that there may be a specific reason for its use when there is not. It can also clutter the code, making it less readable.

Good coding practices to avoid this rule violation include simply not using the final keyword in the method parameters of an interface. This does not affect the functionality of the code, but it makes it cleaner and easier to understand. For example, instead of writing void process(final Object arg);, you can write void process(Object arg);. This maintains the same functionality but improves the readability of the code.

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

PerfectSlayer added the tag: do not merge Do not merge changes label Jan 23, 2025

datadog-datadog-prod-us1 bot reviewed Jan 23, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentTracer.java Outdated Show resolved Hide resolved

PerfectSlayer force-pushed the bbujon/context-propagation branch from 017e5a4 to ddb0406 Compare January 23, 2025 09:54

PerfectSlayer force-pushed the bbujon/context-propagation branch 9 times, most recently from 7ff13cb to b9bb806 Compare January 28, 2025 17:12

PerfectSlayer force-pushed the bbujon/context-propagation branch from b9bb806 to 7d1167d Compare January 30, 2025 13:21

datadog-datadog-prod-us1 bot reviewed Jan 30, 2025

View reviewed changes

PerfectSlayer force-pushed the bbujon/context-propagation branch from 7d1167d to cb598c9 Compare February 3, 2025 08:31

datadog-datadog-prod-us1 bot reviewed Feb 3, 2025

View reviewed changes

PerfectSlayer force-pushed the bbujon/context-propagation branch from cb598c9 to 3f7c076 Compare February 3, 2025 09:25

datadog-datadog-prod-us1 bot reviewed Feb 3, 2025

View reviewed changes

PerfectSlayer force-pushed the bbujon/context-propagation branch from 3f7c076 to 28914b5 Compare February 3, 2025 10:29

datadog-datadog-prod-us1 bot reviewed Feb 3, 2025

View reviewed changes

datadog-datadog-prod-us1 bot reviewed Feb 4, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/api/datastreams/DataStreamsContext.java Outdated Show resolved Hide resolved

PerfectSlayer force-pushed the bbujon/context-propagation branch 5 times, most recently from 89853f9 to db92189 Compare February 11, 2025 09:39

PerfectSlayer force-pushed the bbujon/context-propagation branch from db92189 to 3495320 Compare February 12, 2025 12:32

datadog-datadog-prod-us1 bot reviewed Feb 12, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentPropagation.java Show resolved Hide resolved

PerfectSlayer force-pushed the bbujon/context-propagation branch 2 times, most recently from f93aed6 to 7f63446 Compare February 12, 2025 14:31

datadog-datadog-prod-us1 bot reviewed Feb 12, 2025

View reviewed changes

PerfectSlayer force-pushed the bbujon/context-propagation branch 2 times, most recently from 769271d to 21f9b8b Compare February 24, 2025 11:28

PerfectSlayer added type: enhancement comp: core Tracer core and removed tag: do not merge Do not merge changes labels Feb 24, 2025

PerfectSlayer marked this pull request as ready for review February 24, 2025 12:55

PerfectSlayer requested review from a team as code owners February 24, 2025 12:55

PerfectSlayer requested review from anmarchenko and manuel-alvarez-alvarez February 24, 2025 12:55

PerfectSlayer changed the title ~~WIP - Prototyping context propagation API~~ Remove old context propagation API Feb 24, 2025

PerfectSlayer requested a review from mcculls February 24, 2025 12:57

PerfectSlayer added 2 commits February 25, 2025 10:23

feat(core): Clean up old propagation API

3414c9d

feat(core): Refactor disabled tracing propagator

6750ca1

PerfectSlayer force-pushed the bbujon/context-propagation branch from 21f9b8b to 6750ca1 Compare February 25, 2025 09:24

mcculls approved these changes Feb 28, 2025

View reviewed changes

PerfectSlayer merged commit c548516 into master Feb 28, 2025
218 checks passed

PerfectSlayer deleted the bbujon/context-propagation branch February 28, 2025 12:34

github-actions bot added this to the 1.47.0 milestone Feb 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove old context propagation API #8271

Remove old context propagation API #8271

PerfectSlayer commented Jan 23, 2025 •

edited

Loading

pr-commenter bot commented Jan 23, 2025 •

edited

Loading

pr-commenter bot commented Jan 23, 2025 •

edited

Loading

pr-commenter bot commented Jan 23, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot Feb 12, 2025

	<C> void inject(final DDSpanContext context, final C carrier, final CarrierSetter<C> setter);
	<C> void inject(DDSpanContext context, final C carrier, final CarrierSetter<C> setter);

Remove old context propagation API #8271

Remove old context propagation API #8271

Conversation

PerfectSlayer commented Jan 23, 2025 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Jan 23, 2025 • edited Loading

Kafka / producer-benchmark

Parameters

Summary

pr-commenter bot commented Jan 23, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

pr-commenter bot commented Jan 23, 2025 • edited Loading

Kafka / consumer-benchmark

Parameters

Summary

datadog-datadog-prod-us1 bot Feb 12, 2025

Choose a reason for hiding this comment

⚪ Code Quality Violation

PerfectSlayer commented Jan 23, 2025 •

edited

Loading

pr-commenter bot commented Jan 23, 2025 •

edited

Loading

pr-commenter bot commented Jan 23, 2025 •

edited

Loading

pr-commenter bot commented Jan 23, 2025 •

edited

Loading