Update metrics: appsec.waf.requests #8353

Mariovido · 2025-02-07T11:22:18Z

What Does This Do

This adds a new value to some metrics which is necessary for the consolidation of ASM Span Tags, Metrics, and Logs across all supported languages. The newly value will be implemented in the following metrics:

appsec.waf.requests:
- waf_error: If WAF has failed (except timeout)
- block_failure: If the block has failed
- rate_limited: Wheter the trace has been rate limited
- input_truncated: Wheter the data provided to the libddwaf has been truncated

Motivation

Our goal is to implement all the missing ASM Span Tags, Metrics, and Logs.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APPSEC-56676

pr-commenter · 2025-02-07T12:03:03Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mario.vidal/update_metrics_appsec_request
git_commit_date	1740640620	1740649617
git_commit_sha	`85ac63b`	`11680be`
release_version	1.47.0-SNAPSHOT~85ac63be61	1.47.0-SNAPSHOT~11680beef7

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1740652099	1740652099
ci_job_id	825461837	825461837
ci_pipeline_id	57170200	57170200
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-eucqa9x-project-304-concurrent-0-wgyyu552 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-eucqa9x-project-304-concurrent-0-wgyyu552 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~11680beef7, baseline=1.47.0-SNAPSHOT~85ac63be61

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042947
Total [baseline] (10.496 s) : 0, 10496064
Agent [candidate] (1.039 s) : 0, 1039433
Total [candidate] (10.491 s) : 0, 10490592
section appsec
Agent [baseline] (1.183 s) : 0, 1182545
Total [baseline] (10.735 s) : 0, 10734693
Agent [candidate] (1.189 s) : 0, 1189251
Total [candidate] (10.784 s) : 0, 10784287
section iast
Agent [baseline] (1.171 s) : 0, 1171151
Total [baseline] (10.988 s) : 0, 10987665
Agent [candidate] (1.172 s) : 0, 1171944
Total [candidate] (11.031 s) : 0, 11031057
section profiling
Agent [baseline] (1.261 s) : 0, 1261232
Total [baseline] (10.848 s) : 0, 10847646
Agent [candidate] (1.26 s) : 0, 1259825
Total [candidate] (10.843 s) : 0, 10843043

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	appsec	1.183 s	139.599 ms (13.4%)
Agent	iast	1.171 s	128.205 ms (12.3%)
Agent	profiling	1.261 s	218.285 ms (20.9%)
Total	tracing	10.496 s	-
Total	appsec	10.735 s	238.629 ms (2.3%)
Total	iast	10.988 s	491.602 ms (4.7%)
Total	profiling	10.848 s	351.583 ms (3.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.039 s	-
Agent	appsec	1.189 s	149.818 ms (14.4%)
Agent	iast	1.172 s	132.511 ms (12.7%)
Agent	profiling	1.26 s	220.392 ms (21.2%)
Total	tracing	10.491 s	-
Total	appsec	10.784 s	293.696 ms (2.8%)
Total	iast	11.031 s	540.465 ms (5.2%)
Total	profiling	10.843 s	352.451 ms (3.4%)

gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~11680beef7, baseline=1.47.0-SNAPSHOT~85ac63be61

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.29 ms) : 0, 720290
BytebuddyAgent [candidate] (717.094 ms) : 0, 717094
GlobalTracer [baseline] (239.113 ms) : 0, 239113
GlobalTracer [candidate] (239.119 ms) : 0, 239119
AppSec [baseline] (55.55 ms) : 0, 55550
AppSec [candidate] (55.304 ms) : 0, 55304
Remote Config [baseline] (698.081 µs) : 0, 698
Remote Config [candidate] (690.535 µs) : 0, 691
Telemetry [baseline] (12.315 ms) : 0, 12315
Telemetry [candidate] (12.34 ms) : 0, 12340
section appsec
BytebuddyAgent [baseline] (735.256 ms) : 0, 735256
BytebuddyAgent [candidate] (738.913 ms) : 0, 738913
GlobalTracer [baseline] (236.129 ms) : 0, 236129
GlobalTracer [candidate] (237.567 ms) : 0, 237567
IAST [baseline] (21.53 ms) : 0, 21530
IAST [candidate] (21.511 ms) : 0, 21511
AppSec [baseline] (176.096 ms) : 0, 176096
AppSec [candidate] (178.005 ms) : 0, 178005
Remote Config [baseline] (659.544 µs) : 0, 660
Remote Config [candidate] (661.072 µs) : 0, 661
Telemetry [baseline] (8.679 ms) : 0, 8679
Telemetry [candidate] (8.315 ms) : 0, 8315
section iast
BytebuddyAgent [baseline] (836.364 ms) : 0, 836364
BytebuddyAgent [candidate] (836.815 ms) : 0, 836815
GlobalTracer [baseline] (230.268 ms) : 0, 230268
GlobalTracer [candidate] (230.413 ms) : 0, 230413
IAST [baseline] (23.015 ms) : 0, 23015
IAST [candidate] (23.065 ms) : 0, 23065
AppSec [baseline] (57.173 ms) : 0, 57173
AppSec [candidate] (57.216 ms) : 0, 57216
Remote Config [baseline] (611.294 µs) : 0, 611
Remote Config [candidate] (614.983 µs) : 0, 615
Telemetry [baseline] (8.71 ms) : 0, 8710
Telemetry [candidate] (8.77 ms) : 0, 8770
section profiling
BytebuddyAgent [baseline] (709.205 ms) : 0, 709205
BytebuddyAgent [candidate] (708.947 ms) : 0, 708947
GlobalTracer [baseline] (350.483 ms) : 0, 350483
GlobalTracer [candidate] (350.589 ms) : 0, 350589
AppSec [baseline] (55.573 ms) : 0, 55573
AppSec [candidate] (54.287 ms) : 0, 54287
Remote Config [baseline] (676.239 µs) : 0, 676
Remote Config [candidate] (664.792 µs) : 0, 665
Telemetry [baseline] (8.946 ms) : 0, 8946
Telemetry [candidate] (9.011 ms) : 0, 9011
ProfilingAgent [baseline] (96.043 ms) : 0, 96043
ProfilingAgent [candidate] (95.905 ms) : 0, 95905
Profiling [baseline] (96.067 ms) : 0, 96067
Profiling [candidate] (95.929 ms) : 0, 95929

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~11680beef7, baseline=1.47.0-SNAPSHOT~85ac63be61

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041565
Total [baseline] (8.664 s) : 0, 8664198
Agent [candidate] (1.048 s) : 0, 1048120
Total [candidate] (8.716 s) : 0, 8715563
section iast
Agent [baseline] (1.168 s) : 0, 1168009
Total [baseline] (9.219 s) : 0, 9219286
Agent [candidate] (1.171 s) : 0, 1170617
Total [candidate] (9.231 s) : 0, 9230587
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1186174
Total [baseline] (9.258 s) : 0, 9257958
Agent [candidate] (1.178 s) : 0, 1178201
Total [candidate] (9.208 s) : 0, 9207756
section iast_TELEMETRY_OFF
Agent [baseline] (1.164 s) : 0, 1164277
Total [baseline] (9.214 s) : 0, 9214366
Agent [candidate] (1.166 s) : 0, 1166247
Total [candidate] (9.209 s) : 0, 9209081

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	iast	1.168 s	126.445 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.186 s	144.61 ms (13.9%)
Agent	iast_TELEMETRY_OFF	1.164 s	122.712 ms (11.8%)
Total	tracing	8.664 s	-
Total	iast	9.219 s	555.088 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.258 s	593.76 ms (6.9%)
Total	iast_TELEMETRY_OFF	9.214 s	550.167 ms (6.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	iast	1.171 s	122.497 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.178 s	130.08 ms (12.4%)
Agent	iast_TELEMETRY_OFF	1.166 s	118.127 ms (11.3%)
Total	tracing	8.716 s	-
Total	iast	9.231 s	515.024 ms (5.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.208 s	492.193 ms (5.6%)
Total	iast_TELEMETRY_OFF	9.209 s	493.517 ms (5.7%)

gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~11680beef7, baseline=1.47.0-SNAPSHOT~85ac63be61

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.36 ms) : 0, 718360
BytebuddyAgent [candidate] (721.804 ms) : 0, 721804
GlobalTracer [baseline] (239.074 ms) : 0, 239074
GlobalTracer [candidate] (240.897 ms) : 0, 240897
AppSec [baseline] (55.49 ms) : 0, 55490
AppSec [candidate] (56.207 ms) : 0, 56207
Remote Config [baseline] (687.998 µs) : 0, 688
Remote Config [candidate] (711.562 µs) : 0, 712
Telemetry [baseline] (13.012 ms) : 0, 13012
Telemetry [candidate] (13.442 ms) : 0, 13442
section iast
BytebuddyAgent [baseline] (834.302 ms) : 0, 834302
BytebuddyAgent [candidate] (836.108 ms) : 0, 836108
GlobalTracer [baseline] (229.436 ms) : 0, 229436
GlobalTracer [candidate] (230.198 ms) : 0, 230198
IAST [baseline] (22.776 ms) : 0, 22776
IAST [candidate] (22.838 ms) : 0, 22838
AppSec [baseline] (57.249 ms) : 0, 57249
AppSec [candidate] (57.138 ms) : 0, 57138
Remote Config [baseline] (609.603 µs) : 0, 610
Remote Config [candidate] (606.782 µs) : 0, 607
Telemetry [baseline] (8.626 ms) : 0, 8626
Telemetry [candidate] (8.754 ms) : 0, 8754
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (848.372 ms) : 0, 848372
BytebuddyAgent [candidate] (842.271 ms) : 0, 842271
GlobalTracer [baseline] (232.178 ms) : 0, 232178
GlobalTracer [candidate] (231.121 ms) : 0, 231121
IAST [baseline] (23.147 ms) : 0, 23147
IAST [candidate] (22.983 ms) : 0, 22983
AppSec [baseline] (57.663 ms) : 0, 57663
AppSec [candidate] (57.341 ms) : 0, 57341
Remote Config [baseline] (627.865 µs) : 0, 628
Remote Config [candidate] (616.904 µs) : 0, 617
Telemetry [baseline] (8.868 ms) : 0, 8868
Telemetry [candidate] (8.772 ms) : 0, 8772
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.812 ms) : 0, 831812
BytebuddyAgent [candidate] (833.549 ms) : 0, 833549
GlobalTracer [baseline] (229.417 ms) : 0, 229417
GlobalTracer [candidate] (229.365 ms) : 0, 229365
IAST [baseline] (24.439 ms) : 0, 24439
IAST [candidate] (25.513 ms) : 0, 25513
AppSec [baseline] (54.484 ms) : 0, 54484
AppSec [candidate] (53.754 ms) : 0, 53754
Remote Config [baseline] (608.947 µs) : 0, 609
Remote Config [candidate] (603.204 µs) : 0, 603
Telemetry [baseline] (8.626 ms) : 0, 8626
Telemetry [candidate] (8.562 ms) : 0, 8562

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-27T09:58:33	2025-02-27T10:06:20
git_branch	master	mario.vidal/update_metrics_appsec_request
git_commit_date	1740640620	1740649617
git_commit_sha	`85ac63b`	`11680be`
release_version	1.47.0-SNAPSHOT~85ac63be61	1.47.0-SNAPSHOT~11680beef7
start_time	2025-02-27T09:58:19	2025-02-27T10:06:06

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1740651179	1740651179
ci_job_id	825461838	825461838
ci_pipeline_id	57170200	57170200
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-soylztds-project-304-concurrent-0-iae6nh4d 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-soylztds-project-304-concurrent-0-iae6nh4d 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~11680beef7, baseline=1.47.0-SNAPSHOT~85ac63be61
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.358 ms) : 1339, 1378
.   : milestone, 1358,
appsec (1.767 ms) : 1743, 1791
.   : milestone, 1767,
appsec_no_iast (1.778 ms) : 1753, 1802
.   : milestone, 1778,
code_origins (1.699 ms) : 1666, 1731
.   : milestone, 1699,
iast (1.512 ms) : 1487, 1537
.   : milestone, 1512,
profiling (1.546 ms) : 1521, 1571
.   : milestone, 1546,
tracing (1.513 ms) : 1489, 1537
.   : milestone, 1513,
section candidate
no_agent (1.366 ms) : 1346, 1385
.   : milestone, 1366,
appsec (1.72 ms) : 1696, 1745
.   : milestone, 1720,
appsec_no_iast (1.761 ms) : 1736, 1786
.   : milestone, 1761,
code_origins (1.688 ms) : 1655, 1720
.   : milestone, 1688,
iast (1.506 ms) : 1481, 1530
.   : milestone, 1506,
profiling (1.512 ms) : 1488, 1536
.   : milestone, 1512,
tracing (1.508 ms) : 1483, 1534
.   : milestone, 1508,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.358 ms [1.339 ms, 1.378 ms]	-
appsec	1.767 ms [1.743 ms, 1.791 ms]	408.595 µs (30.1%)
appsec_no_iast	1.778 ms [1.753 ms, 1.802 ms]	419.413 µs (30.9%)
code_origins	1.699 ms [1.666 ms, 1.731 ms]	340.52 µs (25.1%)
iast	1.512 ms [1.487 ms, 1.537 ms]	153.77 µs (11.3%)
profiling	1.546 ms [1.521 ms, 1.571 ms]	187.479 µs (13.8%)
tracing	1.513 ms [1.489 ms, 1.537 ms]	154.885 µs (11.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.366 ms [1.346 ms, 1.385 ms]	-
appsec	1.72 ms [1.696 ms, 1.745 ms]	354.949 µs (26.0%)
appsec_no_iast	1.761 ms [1.736 ms, 1.786 ms]	395.705 µs (29.0%)
code_origins	1.688 ms [1.655 ms, 1.72 ms]	322.018 µs (23.6%)
iast	1.506 ms [1.481 ms, 1.53 ms]	139.964 µs (10.2%)
profiling	1.512 ms [1.488 ms, 1.536 ms]	146.162 µs (10.7%)
tracing	1.508 ms [1.483 ms, 1.534 ms]	142.905 µs (10.5%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~11680beef7, baseline=1.47.0-SNAPSHOT~85ac63be61
    dateFormat X
    axisFormat %s
section baseline
no_agent (384.325 µs) : 364, 404
.   : milestone, 384,
iast (516.666 µs) : 493, 540
.   : milestone, 517,
iast_FULL (732.404 µs) : 711, 754
.   : milestone, 732,
iast_GLOBAL (555.154 µs) : 533, 578
.   : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (517.994 µs) : 495, 541
.   : milestone, 518,
iast_INACTIVE (457.68 µs) : 436, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (506.276 µs) : 483, 530
.   : milestone, 506,
tracing (460.105 µs) : 439, 481
.   : milestone, 460,
section candidate
no_agent (378.169 µs) : 358, 398
.   : milestone, 378,
iast (513.686 µs) : 492, 536
.   : milestone, 514,
iast_FULL (732.751 µs) : 711, 755
.   : milestone, 733,
iast_GLOBAL (567.728 µs) : 544, 591
.   : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (516.878 µs) : 494, 539
.   : milestone, 517,
iast_INACTIVE (463.096 µs) : 441, 485
.   : milestone, 463,
iast_TELEMETRY_OFF (502.376 µs) : 481, 524
.   : milestone, 502,
tracing (454.671 µs) : 433, 476
.   : milestone, 455,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	384.325 µs [364.407 µs, 404.244 µs]	-
iast	516.666 µs [493.116 µs, 540.216 µs]	132.341 µs (34.4%)
iast_FULL	732.404 µs [710.546 µs, 754.263 µs]	348.079 µs (90.6%)
iast_GLOBAL	555.154 µs [532.688 µs, 577.62 µs]	170.829 µs (44.4%)
iast_HARDCODED_SECRET_DISABLED	517.994 µs [495.323 µs, 540.666 µs]	133.669 µs (34.8%)
iast_INACTIVE	457.68 µs [436.364 µs, 478.996 µs]	73.354 µs (19.1%)
iast_TELEMETRY_OFF	506.276 µs [482.703 µs, 529.848 µs]	121.95 µs (31.7%)
tracing	460.105 µs [438.853 µs, 481.356 µs]	75.779 µs (19.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.169 µs [358.276 µs, 398.062 µs]	-
iast	513.686 µs [491.864 µs, 535.507 µs]	135.517 µs (35.8%)
iast_FULL	732.751 µs [710.808 µs, 754.695 µs]	354.582 µs (93.8%)
iast_GLOBAL	567.728 µs [544.196 µs, 591.261 µs]	189.559 µs (50.1%)
iast_HARDCODED_SECRET_DISABLED	516.878 µs [494.445 µs, 539.31 µs]	138.709 µs (36.7%)
iast_INACTIVE	463.096 µs [441.443 µs, 484.749 µs]	84.927 µs (22.5%)
iast_TELEMETRY_OFF	502.376 µs [480.65 µs, 524.103 µs]	124.208 µs (32.8%)
tracing	454.671 µs [433.499 µs, 475.843 µs]	76.502 µs (20.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mario.vidal/update_metrics_appsec_request
git_commit_date	1740640620	1740649617
git_commit_sha	`85ac63b`	`11680be`
release_version	1.47.0-SNAPSHOT~85ac63be61	1.47.0-SNAPSHOT~11680beef7

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1740651653	1740651653
ci_job_id	825461839	825461839
ci_pipeline_id	57170200	57170200
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-eucqa9x-project-304-concurrent-1-8qk9ip5g 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-eucqa9x-project-304-concurrent-1-8qk9ip5g 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~11680beef7, baseline=1.47.0-SNAPSHOT~85ac63be61
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.846 s) : 14846000, 14846000
.   : milestone, 14846000,
appsec (14.807 s) : 14807000, 14807000
.   : milestone, 14807000,
iast (18.476 s) : 18476000, 18476000
.   : milestone, 18476000,
iast_GLOBAL (17.764 s) : 17764000, 17764000
.   : milestone, 17764000,
profiling (14.96 s) : 14960000, 14960000
.   : milestone, 14960000,
tracing (14.875 s) : 14875000, 14875000
.   : milestone, 14875000,
section candidate
no_agent (15.273 s) : 15273000, 15273000
.   : milestone, 15273000,
appsec (15.155 s) : 15155000, 15155000
.   : milestone, 15155000,
iast (18.502 s) : 18502000, 18502000
.   : milestone, 18502000,
iast_GLOBAL (18.016 s) : 18016000, 18016000
.   : milestone, 18016000,
profiling (15.092 s) : 15092000, 15092000
.   : milestone, 15092000,
tracing (14.969 s) : 14969000, 14969000
.   : milestone, 14969000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.846 s [14.846 s, 14.846 s]	-
appsec	14.807 s [14.807 s, 14.807 s]	-39.0 ms (-0.3%)
iast	18.476 s [18.476 s, 18.476 s]	3.63 s (24.5%)
iast_GLOBAL	17.764 s [17.764 s, 17.764 s]	2.918 s (19.7%)
profiling	14.96 s [14.96 s, 14.96 s]	114.0 ms (0.8%)
tracing	14.875 s [14.875 s, 14.875 s]	29.0 ms (0.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.273 s [15.273 s, 15.273 s]	-
appsec	15.155 s [15.155 s, 15.155 s]	-118.0 ms (-0.8%)
iast	18.502 s [18.502 s, 18.502 s]	3.229 s (21.1%)
iast_GLOBAL	18.016 s [18.016 s, 18.016 s]	2.743 s (18.0%)
profiling	15.092 s [15.092 s, 15.092 s]	-181.0 ms (-1.2%)
tracing	14.969 s [14.969 s, 14.969 s]	-304.0 ms (-2.0%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~11680beef7, baseline=1.47.0-SNAPSHOT~85ac63be61
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.363 ms) : 2320, 2407
.   : milestone, 2363,
iast (2.124 ms) : 2069, 2179
.   : milestone, 2124,
iast_GLOBAL (2.169 ms) : 2113, 2224
.   : milestone, 2169,
profiling (1.977 ms) : 1933, 2020
.   : milestone, 1977,
tracing (1.951 ms) : 1910, 1993
.   : milestone, 1951,
section candidate
no_agent (1.478 ms) : 1466, 1489
.   : milestone, 1478,
appsec (2.358 ms) : 2313, 2402
.   : milestone, 2358,
iast (2.117 ms) : 2062, 2172
.   : milestone, 2117,
iast_GLOBAL (2.165 ms) : 2111, 2220
.   : milestone, 2165,
profiling (2.433 ms) : 2199, 2667
.   : milestone, 2433,
tracing (1.952 ms) : 1910, 1994
.   : milestone, 1952,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.46 ms, 1.483 ms]	-
appsec	2.363 ms [2.32 ms, 2.407 ms]	891.956 µs (60.6%)
iast	2.124 ms [2.069 ms, 2.179 ms]	652.996 µs (44.4%)
iast_GLOBAL	2.169 ms [2.113 ms, 2.224 ms]	697.539 µs (47.4%)
profiling	1.977 ms [1.933 ms, 2.02 ms]	505.554 µs (34.4%)
tracing	1.951 ms [1.91 ms, 1.993 ms]	480.267 µs (32.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.466 ms, 1.489 ms]	-
appsec	2.358 ms [2.313 ms, 2.402 ms]	879.961 µs (59.6%)
iast	2.117 ms [2.062 ms, 2.172 ms]	639.351 µs (43.3%)
iast_GLOBAL	2.165 ms [2.111 ms, 2.22 ms]	687.679 µs (46.5%)
profiling	2.433 ms [2.199 ms, 2.667 ms]	955.311 µs (64.7%)
tracing	1.952 ms [1.91 ms, 1.994 ms]	474.392 µs (32.1%)

.circleci/config.continue.yml.j2

internal-api/src/main/java/datadog/trace/api/telemetry/TruncatedType.java

dd-java-agent/appsec/src/main/java/com/datadog/appsec/powerwaf/PowerWAFModule.java

jandro996

LGTM

# Conflicts: # dd-java-agent/appsec/src/main/java/com/datadog/appsec/powerwaf/PowerWAFModule.java

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

Mariovido added type: enhancement comp: asm waf Application Security Management (WAF) comp: telemetry Telemetry labels Feb 7, 2025

Mariovido force-pushed the mario.vidal/update_metrics_appsec_request branch 2 times, most recently from b5f81a0 to ed1d22c Compare February 11, 2025 10:23

Mariovido marked this pull request as ready for review February 17, 2025 13:30

Mariovido requested review from a team as code owners February 17, 2025 13:30

Mariovido requested review from manuel-alvarez-alvarez and ValentinZakharov February 17, 2025 13:30

sezen-datadog reviewed Feb 17, 2025

View reviewed changes

.circleci/config.continue.yml.j2 Show resolved Hide resolved

smola requested changes Feb 17, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/api/telemetry/TruncatedType.java Outdated Show resolved Hide resolved

jandro996 reviewed Feb 18, 2025

View reviewed changes

dd-java-agent/appsec/src/main/java/com/datadog/appsec/powerwaf/PowerWAFModule.java Outdated Show resolved Hide resolved

jandro996 approved these changes Feb 18, 2025

View reviewed changes

sezen-datadog self-assigned this Feb 25, 2025

sezen-datadog requested a review from smola February 25, 2025 09:35

sezen-datadog approved these changes Feb 25, 2025

View reviewed changes

sezen-datadog force-pushed the mario.vidal/update_metrics_appsec_request branch 2 times, most recently from 3bb088a to 3b00f4c Compare February 26, 2025 10:52

sezen-datadog enabled auto-merge (squash) February 26, 2025 10:53

sezen-datadog disabled auto-merge February 27, 2025 09:45

Mariovido added 8 commits February 27, 2025 10:46

Add waf_error tag to appsec.waf.requests metric

e6c7ca3

Add tag rate_limited

139680f

# Conflicts: # dd-java-agent/appsec/src/main/java/com/datadog/appsec/powerwaf/PowerWAFModule.java

Add tag block_failure

53d71eb

Add tag input_truncated

0f2c082

Update latest libddwaf-java version

84f48b4

Fix tests

52788f8

Update system-tests to d4974a9d88a10a70a8688afd08697affb5e82261

e733776

Change enum name to be more specific

941eaf6

sezen-datadog added 4 commits February 27, 2025 10:46

PR

c42e81b

PR

3fd4da7

error

4a75e65

have to skip tests on PowerWAFDataCallback

11680be

sezen-datadog force-pushed the mario.vidal/update_metrics_appsec_request branch from 3b00f4c to 11680be Compare February 27, 2025 09:46

smola approved these changes Feb 27, 2025

View reviewed changes

sezen-datadog enabled auto-merge (squash) February 27, 2025 09:50

sezen-datadog merged commit 6d2c673 into master Feb 27, 2025
216 checks passed

sezen-datadog deleted the mario.vidal/update_metrics_appsec_request branch February 27, 2025 10:33

github-actions bot added this to the 1.47.0 milestone Feb 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update metrics: appsec.waf.requests #8353

Update metrics: appsec.waf.requests #8353

Mariovido commented Feb 7, 2025 •

edited

Loading

pr-commenter bot commented Feb 7, 2025 •

edited

Loading

jandro996 left a comment

Update metrics: appsec.waf.requests #8353

Update metrics: appsec.waf.requests #8353

Conversation

Mariovido commented Feb 7, 2025 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Feb 7, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

jandro996 left a comment

Choose a reason for hiding this comment

Mariovido commented Feb 7, 2025 •

edited

Loading

pr-commenter bot commented Feb 7, 2025 •

edited

Loading