-
Notifications
You must be signed in to change notification settings - Fork 302
Exclude OrderedThreadPoolExecutor from queue-time measurements #8456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~e8d59385c4, baseline=1.47.0-SNAPSHOT~0d8268a3bf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043063
Total [baseline] (8.676 s) : 0, 8676311
Agent [candidate] (1.047 s) : 0, 1046772
Total [candidate] (8.686 s) : 0, 8685902
section iast
Agent [baseline] (1.168 s) : 0, 1168412
Total [baseline] (9.242 s) : 0, 9242256
Agent [candidate] (1.17 s) : 0, 1170445
Total [candidate] (9.238 s) : 0, 9237705
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171622
Total [baseline] (9.213 s) : 0, 9213171
Agent [candidate] (1.18 s) : 0, 1180387
Total [candidate] (9.256 s) : 0, 9255972
section iast_TELEMETRY_OFF
Agent [baseline] (1.168 s) : 0, 1168293
Total [baseline] (9.218 s) : 0, 9217573
Agent [candidate] (1.178 s) : 0, 1177777
Total [candidate] (9.242 s) : 0, 9242214
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~e8d59385c4, baseline=1.47.0-SNAPSHOT~0d8268a3bf
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.308 ms) : 0, 717308
BytebuddyAgent [candidate] (721.226 ms) : 0, 721226
GlobalTracer [baseline] (239.697 ms) : 0, 239697
GlobalTracer [candidate] (240.795 ms) : 0, 240795
AppSec [baseline] (56.011 ms) : 0, 56011
AppSec [candidate] (55.796 ms) : 0, 55796
Remote Config [baseline] (705.324 µs) : 0, 705
Remote Config [candidate] (695.035 µs) : 0, 695
Telemetry [baseline] (14.419 ms) : 0, 14419
Telemetry [candidate] (13.024 ms) : 0, 13024
section iast
BytebuddyAgent [baseline] (835.168 ms) : 0, 835168
BytebuddyAgent [candidate] (836.12 ms) : 0, 836120
GlobalTracer [baseline] (228.93 ms) : 0, 228930
GlobalTracer [candidate] (230.15 ms) : 0, 230150
IAST [baseline] (22.827 ms) : 0, 22827
IAST [candidate] (22.617 ms) : 0, 22617
AppSec [baseline] (57.189 ms) : 0, 57189
AppSec [candidate] (57.026 ms) : 0, 57026
Remote Config [baseline] (600.186 µs) : 0, 600
Remote Config [candidate] (607.029 µs) : 0, 607
Telemetry [baseline] (8.751 ms) : 0, 8751
Telemetry [candidate] (8.63 ms) : 0, 8630
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.822 ms) : 0, 836822
BytebuddyAgent [candidate] (842.791 ms) : 0, 842791
GlobalTracer [baseline] (230.173 ms) : 0, 230173
GlobalTracer [candidate] (232.196 ms) : 0, 232196
IAST [baseline] (23.06 ms) : 0, 23060
IAST [candidate] (23.098 ms) : 0, 23098
AppSec [baseline] (57.157 ms) : 0, 57157
AppSec [candidate] (57.51 ms) : 0, 57510
Remote Config [baseline] (618.499 µs) : 0, 618
Remote Config [candidate] (617.668 µs) : 0, 618
Telemetry [baseline] (8.849 ms) : 0, 8849
Telemetry [candidate] (8.729 ms) : 0, 8729
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.823 ms) : 0, 835823
BytebuddyAgent [candidate] (840.712 ms) : 0, 840712
GlobalTracer [baseline] (229.704 ms) : 0, 229704
GlobalTracer [candidate] (232.291 ms) : 0, 232291
IAST [baseline] (25.225 ms) : 0, 25225
IAST [candidate] (26.317 ms) : 0, 26317
AppSec [baseline] (53.25 ms) : 0, 53250
AppSec [candidate] (53.804 ms) : 0, 53804
Remote Config [baseline] (609.244 µs) : 0, 609
Remote Config [candidate] (619.78 µs) : 0, 620
Telemetry [baseline] (8.512 ms) : 0, 8512
Telemetry [candidate] (8.667 ms) : 0, 8667
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~e8d59385c4, baseline=1.47.0-SNAPSHOT~0d8268a3bf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043986
Total [baseline] (10.386 s) : 0, 10386306
Agent [candidate] (1.04 s) : 0, 1040262
Total [candidate] (10.438 s) : 0, 10438343
section appsec
Agent [baseline] (1.18 s) : 0, 1179516
Total [baseline] (10.807 s) : 0, 10806558
Agent [candidate] (1.188 s) : 0, 1188004
Total [candidate] (10.789 s) : 0, 10788595
section iast
Agent [baseline] (1.178 s) : 0, 1177684
Total [baseline] (11.031 s) : 0, 11031099
Agent [candidate] (1.185 s) : 0, 1184568
Total [candidate] (10.986 s) : 0, 10985721
section profiling
Agent [baseline] (1.27 s) : 0, 1270284
Total [baseline] (10.878 s) : 0, 10878115
Agent [candidate] (1.272 s) : 0, 1271551
Total [candidate] (10.89 s) : 0, 10889988
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~e8d59385c4, baseline=1.47.0-SNAPSHOT~0d8268a3bf
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.435 ms) : 0, 721435
BytebuddyAgent [candidate] (717.507 ms) : 0, 717507
GlobalTracer [baseline] (240.248 ms) : 0, 240248
GlobalTracer [candidate] (239.935 ms) : 0, 239935
AppSec [baseline] (55.813 ms) : 0, 55813
AppSec [candidate] (55.43 ms) : 0, 55430
Remote Config [baseline] (692.054 µs) : 0, 692
Remote Config [candidate] (695.306 µs) : 0, 695
Telemetry [baseline] (10.819 ms) : 0, 10819
Telemetry [candidate] (11.505 ms) : 0, 11505
section appsec
BytebuddyAgent [baseline] (732.616 ms) : 0, 732616
BytebuddyAgent [candidate] (738.003 ms) : 0, 738003
GlobalTracer [baseline] (235.692 ms) : 0, 235692
GlobalTracer [candidate] (237.678 ms) : 0, 237678
IAST [baseline] (21.516 ms) : 0, 21516
IAST [candidate] (21.583 ms) : 0, 21583
AppSec [baseline] (176.6 ms) : 0, 176600
AppSec [candidate] (177.307 ms) : 0, 177307
Remote Config [baseline] (660.908 µs) : 0, 661
Remote Config [candidate] (676.274 µs) : 0, 676
Telemetry [baseline] (8.279 ms) : 0, 8279
Telemetry [candidate] (8.303 ms) : 0, 8303
section iast
BytebuddyAgent [baseline] (841.873 ms) : 0, 841873
BytebuddyAgent [candidate] (846.147 ms) : 0, 846147
GlobalTracer [baseline] (230.839 ms) : 0, 230839
GlobalTracer [candidate] (232.608 ms) : 0, 232608
IAST [baseline] (23.047 ms) : 0, 23047
IAST [candidate] (23.095 ms) : 0, 23095
AppSec [baseline] (57.409 ms) : 0, 57409
AppSec [candidate] (57.926 ms) : 0, 57926
Remote Config [baseline] (614.56 µs) : 0, 615
Remote Config [candidate] (623.998 µs) : 0, 624
Telemetry [baseline] (8.838 ms) : 0, 8838
Telemetry [candidate] (8.825 ms) : 0, 8825
section profiling
BytebuddyAgent [baseline] (714.337 ms) : 0, 714337
BytebuddyAgent [candidate] (713.591 ms) : 0, 713591
GlobalTracer [baseline] (351.906 ms) : 0, 351906
GlobalTracer [candidate] (353.805 ms) : 0, 353805
AppSec [baseline] (55.879 ms) : 0, 55879
AppSec [candidate] (54.93 ms) : 0, 54930
Remote Config [baseline] (678.333 µs) : 0, 678
Remote Config [candidate] (671.395 µs) : 0, 671
Telemetry [baseline] (9.113 ms) : 0, 9113
Telemetry [candidate] (9.039 ms) : 0, 9039
ProfilingAgent [baseline] (97.501 ms) : 0, 97501
ProfilingAgent [candidate] (97.025 ms) : 0, 97025
Profiling [baseline] (97.525 ms) : 0, 97525
Profiling [candidate] (97.05 ms) : 0, 97050
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~e8d59385c4, baseline=1.47.0-SNAPSHOT~0d8268a3bf
dateFormat X
axisFormat %s
section baseline
no_agent (1.365 ms) : 1345, 1384
. : milestone, 1365,
appsec (1.73 ms) : 1706, 1754
. : milestone, 1730,
appsec_no_iast (1.762 ms) : 1738, 1786
. : milestone, 1762,
iast (1.506 ms) : 1483, 1530
. : milestone, 1506,
profiling (1.58 ms) : 1550, 1610
. : milestone, 1580,
tracing (1.496 ms) : 1471, 1520
. : milestone, 1496,
section candidate
no_agent (1.372 ms) : 1351, 1393
. : milestone, 1372,
appsec (1.756 ms) : 1732, 1781
. : milestone, 1756,
appsec_no_iast (1.766 ms) : 1742, 1791
. : milestone, 1766,
iast (1.511 ms) : 1485, 1536
. : milestone, 1511,
profiling (1.522 ms) : 1500, 1545
. : milestone, 1522,
tracing (1.491 ms) : 1466, 1516
. : milestone, 1491,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~e8d59385c4, baseline=1.47.0-SNAPSHOT~0d8268a3bf
dateFormat X
axisFormat %s
section baseline
no_agent (378.235 µs) : 358, 398
. : milestone, 378,
iast (505.808 µs) : 483, 528
. : milestone, 506,
iast_FULL (731.763 µs) : 710, 754
. : milestone, 732,
iast_GLOBAL (561.486 µs) : 539, 584
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (512.604 µs) : 489, 536
. : milestone, 513,
iast_INACTIVE (461.51 µs) : 440, 483
. : milestone, 462,
iast_TELEMETRY_OFF (498.137 µs) : 475, 521
. : milestone, 498,
tracing (453.091 µs) : 432, 474
. : milestone, 453,
section candidate
no_agent (381.598 µs) : 362, 401
. : milestone, 382,
iast (469.158 µs) : 465, 474
. : milestone, 469,
iast_FULL (732.824 µs) : 711, 755
. : milestone, 733,
iast_GLOBAL (552.389 µs) : 531, 574
. : milestone, 552,
iast_HARDCODED_SECRET_DISABLED (513.43 µs) : 491, 536
. : milestone, 513,
iast_INACTIVE (461.71 µs) : 440, 483
. : milestone, 462,
iast_TELEMETRY_OFF (496.14 µs) : 473, 519
. : milestone, 496,
tracing (456.755 µs) : 436, 477
. : milestone, 457,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~e8d59385c4, baseline=1.47.0-SNAPSHOT~0d8268a3bf
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.361 ms) : 2318, 2405
. : milestone, 2361,
iast (2.104 ms) : 2049, 2159
. : milestone, 2104,
iast_GLOBAL (2.148 ms) : 2093, 2204
. : milestone, 2148,
profiling (1.965 ms) : 1922, 2009
. : milestone, 1965,
tracing (1.937 ms) : 1896, 1979
. : milestone, 1937,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.355 ms) : 2311, 2398
. : milestone, 2355,
iast (2.1 ms) : 2045, 2155
. : milestone, 2100,
iast_GLOBAL (2.147 ms) : 2091, 2202
. : milestone, 2147,
profiling (1.962 ms) : 1919, 2006
. : milestone, 1962,
tracing (1.938 ms) : 1896, 1981
. : milestone, 1938,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~e8d59385c4, baseline=1.47.0-SNAPSHOT~0d8268a3bf
dateFormat X
axisFormat %s
section baseline
no_agent (15.535 s) : 15535000, 15535000
. : milestone, 15535000,
appsec (15.307 s) : 15307000, 15307000
. : milestone, 15307000,
iast (19.133 s) : 19133000, 19133000
. : milestone, 19133000,
iast_GLOBAL (17.966 s) : 17966000, 17966000
. : milestone, 17966000,
profiling (15.269 s) : 15269000, 15269000
. : milestone, 15269000,
tracing (14.913 s) : 14913000, 14913000
. : milestone, 14913000,
section candidate
no_agent (15.232 s) : 15232000, 15232000
. : milestone, 15232000,
appsec (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
iast (18.952 s) : 18952000, 18952000
. : milestone, 18952000,
iast_GLOBAL (17.632 s) : 17632000, 17632000
. : milestone, 17632000,
profiling (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
tracing (14.997 s) : 14997000, 14997000
. : milestone, 14997000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like there to be an integration test, so we make sure this stays fixed.
However given the urgency, I'm fine with this change as is to start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarahchen6 is building smoke tests for the concurrency related instrumentation.
It might be worth adding this Apache Mina use-case too.
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#​8483](DataDog/dd-trace-java#8483) - [@​jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#​8462](DataDog/dd-trace-java#8462) - [@​jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#​8408](DataDog/dd-trace-java#8408) - [@​smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#​8407](DataDog/dd-trace-java#8407) - [@​smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#​8406](DataDog/dd-trace-java#8406) - [@​smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#​8347](DataDog/dd-trace-java#8347) - [@​jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#​8219](DataDog/dd-trace-java#8219) - [@​jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#​8210](DataDog/dd-trace-java#8210) - [@​jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#​8205](DataDog/dd-trace-java#8205) - [@​sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#​8376](DataDog/dd-trace-java#8376) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#​8374](DataDog/dd-trace-java#8374) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#​8354](DataDog/dd-trace-java#8354) - [@​sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#​8353](DataDog/dd-trace-java#8353) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#​8285](DataDog/dd-trace-java#8285) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#​8280](DataDog/dd-trace-java#8280) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#​8219](DataDog/dd-trace-java#8219) - [@​jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#​8361](DataDog/dd-trace-java#8361) - [@​amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#​8180](DataDog/dd-trace-java#8180) - [@​lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#​8487](DataDog/dd-trace-java#8487) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#​8484](DataDog/dd-trace-java#8484) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#​8474](DataDog/dd-trace-java#8474) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#​8467](DataDog/dd-trace-java#8467) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#​8465](DataDog/dd-trace-java#8465) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#​8451](DataDog/dd-trace-java#8451) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#​8445](DataDog/dd-trace-java#8445) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#​8444](DataDog/dd-trace-java#8444) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#​8393](DataDog/dd-trace-java#8393) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#​8377](DataDog/dd-trace-java#8377) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#​8349](DataDog/dd-trace-java#8349) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#​8345](DataDog/dd-trace-java#8345) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#​8331](DataDog/dd-trace-java#8331) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#​8326](DataDog/dd-trace-java#8326) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#​8320](DataDog/dd-trace-java#8320) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#​8318](DataDog/dd-trace-java#8318) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#​8419](DataDog/dd-trace-java#8419) - [@​mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#​8348](DataDog/dd-trace-java#8348) - [@​jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#​8473](DataDog/dd-trace-java#8473) - [@​vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#​8403](DataDog/dd-trace-java#8403) - [@​vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#​8387](DataDog/dd-trace-java#8387) - [@​piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#​8508](DataDog/dd-trace-java#8508) - [@​cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#​8468](DataDog/dd-trace-java#8468) - [@​evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#​8452](DataDog/dd-trace-java#8452) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#​8416](DataDog/dd-trace-java#8416) - [@​evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#​8370](DataDog/dd-trace-java#8370) - [@​jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#​8369](DataDog/dd-trace-java#8369) - [@​jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#​8344](DataDog/dd-trace-java#8344) - [@​jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#​8319](DataDog/dd-trace-java#8319) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#​8301](DataDog/dd-trace-java#8301) - [@​evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#​8381](DataDog/dd-trace-java#8381) - [@​sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#​8364](DataDog/dd-trace-java#8364) - [@​sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#​8463](DataDog/dd-trace-java#8463) - [@​jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#​8456](DataDog/dd-trace-java#8456) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#​8431](DataDog/dd-trace-java#8431) - [@​jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#​8420](DataDog/dd-trace-java#8420) - [@​mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#​8419](DataDog/dd-trace-java#8419) - [@​mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#​8405](DataDog/dd-trace-java#8405) - [@​jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#​8342](DataDog/dd-trace-java#8342) - [@​MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#​8428](DataDog/dd-trace-java#8428) - [@​jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#​8353](DataDog/dd-trace-java#8353) - [@​Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#​8313](DataDog/dd-trace-java#8313) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#​8460](DataDog/dd-trace-java#8460) - [@​BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#​8414](DataDog/dd-trace-java#8414) - [@​mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#​8399](DataDog/dd-trace-java#8399) - [@​mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#​8383](DataDog/dd-trace-java#8383) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#​8371](DataDog/dd-trace-java#8371) - [@​mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#​8368](DataDog/dd-trace-java#8368) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#​8358](DataDog/dd-trace-java#8358) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#​8338](DataDog/dd-trace-java#8338) - [@​mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#​8330](DataDog/dd-trace-java#8330) - [@​mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#​8324](DataDog/dd-trace-java#8324) - [@​mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#​8313](DataDog/dd-trace-java#8313) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#​8271](DataDog/dd-trace-java#8271) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#​8417](DataDog/dd-trace-java#8417) - [@​nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#​8473](DataDog/dd-trace-java#8473) - [@​vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#​7585](DataDog/dd-trace-java#7585) - [@​DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#​8468](DataDog/dd-trace-java#8468) - [@​evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#​8416](DataDog/dd-trace-java#8416) - [@​evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#​8330](DataDog/dd-trace-java#8330) - [@​mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#​8301](DataDog/dd-trace-java#8301) - [@​evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#​8468](DataDog/dd-trace-java#8468) - [@​evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#​8366](DataDog/dd-trace-java#8366) - [@​rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#​8403](DataDog/dd-trace-java#8403) - [@​vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa
What Does This Do
It excludes Apache Mina
OrderedThreadPoolExecutor
from queue-time related instrumentation.Motivation
That particular executor is 'peculiar' in a sense that it circumvents the functionality of the base class and for
getQueue()
method throwsUnsupportedOperationException
. SincegetQueue()
is essential for measuring the time a task spent in a queue the instrumented code happens to call it very often and this leads to the system being completely flooded byUnsupportedOperationException
.The main motivation is to avoid breaking the traced application because of this problem.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-11449