-
Notifications
You must be signed in to change notification settings - Fork 303
Prevent double reporting of Scalatest events when using SBT with test forking #8682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nikita-tkachenko-datadog
merged 2 commits into
master
from
nikita-tkachenko/scalatest-fork-double-reporting
Apr 8, 2025
Merged
Prevent double reporting of Scalatest events when using SBT with test forking #8682
nikita-tkachenko-datadog
merged 2 commits into
master
from
nikita-tkachenko/scalatest-fork-double-reporting
Apr 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-mohedano
approved these changes
Apr 8, 2025
7 tasks
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 67 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~63c09f48cd, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064320
Total [baseline] (10.494 s) : 0, 10493884
Agent [candidate] (1.059 s) : 0, 1059410
Total [candidate] (10.516 s) : 0, 10515940
section appsec
Agent [baseline] (1.202 s) : 0, 1202365
Total [baseline] (10.82 s) : 0, 10819510
Agent [candidate] (1.199 s) : 0, 1199108
Total [candidate] (10.783 s) : 0, 10782790
section iast
Agent [baseline] (1.184 s) : 0, 1183996
Total [baseline] (11.037 s) : 0, 11036962
Agent [candidate] (1.186 s) : 0, 1185666
Total [candidate] (11.019 s) : 0, 11018972
section profiling
Agent [baseline] (1.291 s) : 0, 1291228
Total [baseline] (10.952 s) : 0, 10951868
Agent [candidate] (1.293 s) : 0, 1292816
Total [candidate] (10.919 s) : 0, 10918705
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~63c09f48cd, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (726.638 ms) : 0, 726638
BytebuddyAgent [candidate] (722.967 ms) : 0, 722967
GlobalTracer [baseline] (241.203 ms) : 0, 241203
GlobalTracer [candidate] (239.706 ms) : 0, 239706
AppSec [baseline] (55.065 ms) : 0, 55065
AppSec [candidate] (54.625 ms) : 0, 54625
Debugger [baseline] (4.481 ms) : 0, 4481
Debugger [candidate] (4.411 ms) : 0, 4411
Remote Config [baseline] (718.993 µs) : 0, 719
Remote Config [candidate] (687.914 µs) : 0, 688
Telemetry [baseline] (15.174 ms) : 0, 15174
Telemetry [candidate] (16.129 ms) : 0, 16129
section appsec
BytebuddyAgent [baseline] (743.922 ms) : 0, 743922
BytebuddyAgent [candidate] (741.255 ms) : 0, 741255
GlobalTracer [baseline] (236.746 ms) : 0, 236746
GlobalTracer [candidate] (236.388 ms) : 0, 236388
AppSec [baseline] (176.885 ms) : 0, 176885
AppSec [candidate] (176.804 ms) : 0, 176804
Debugger [baseline] (4.272 ms) : 0, 4272
Debugger [candidate] (4.261 ms) : 0, 4261
Remote Config [baseline] (638.183 µs) : 0, 638
Remote Config [candidate] (644.329 µs) : 0, 644
Telemetry [baseline] (8.299 ms) : 0, 8299
Telemetry [candidate] (8.245 ms) : 0, 8245
IAST [baseline] (21.521 ms) : 0, 21521
IAST [candidate] (21.44 ms) : 0, 21440
section iast
BytebuddyAgent [baseline] (841.327 ms) : 0, 841327
BytebuddyAgent [candidate] (842.671 ms) : 0, 842671
GlobalTracer [baseline] (230.003 ms) : 0, 230003
GlobalTracer [candidate] (229.944 ms) : 0, 229944
AppSec [baseline] (55.967 ms) : 0, 55967
AppSec [candidate] (56.174 ms) : 0, 56174
Debugger [baseline] (4.073 ms) : 0, 4073
Debugger [candidate] (4.133 ms) : 0, 4133
Remote Config [baseline] (597.344 µs) : 0, 597
Remote Config [candidate] (591.446 µs) : 0, 591
Telemetry [baseline] (8.658 ms) : 0, 8658
Telemetry [candidate] (8.707 ms) : 0, 8707
IAST [baseline] (22.574 ms) : 0, 22574
IAST [candidate] (22.626 ms) : 0, 22626
section profiling
BytebuddyAgent [baseline] (712.134 ms) : 0, 712134
BytebuddyAgent [candidate] (713.993 ms) : 0, 713993
GlobalTracer [baseline] (359.354 ms) : 0, 359354
GlobalTracer [candidate] (360.043 ms) : 0, 360043
AppSec [baseline] (54.409 ms) : 0, 54409
AppSec [candidate] (53.411 ms) : 0, 53411
Debugger [baseline] (4.29 ms) : 0, 4290
Debugger [candidate] (4.337 ms) : 0, 4337
Remote Config [baseline] (697.289 µs) : 0, 697
Remote Config [candidate] (704.947 µs) : 0, 705
Telemetry [baseline] (9.031 ms) : 0, 9031
Telemetry [candidate] (9.02 ms) : 0, 9020
ProfilingAgent [baseline] (103.227 ms) : 0, 103227
ProfilingAgent [candidate] (103.263 ms) : 0, 103263
Profiling [baseline] (103.252 ms) : 0, 103252
Profiling [candidate] (103.289 ms) : 0, 103289
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~63c09f48cd, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063545
Total [baseline] (8.681 s) : 0, 8681069
Agent [candidate] (1.059 s) : 0, 1058763
Total [candidate] (8.703 s) : 0, 8703419
section iast
Agent [baseline] (1.186 s) : 0, 1186278
Total [baseline] (9.331 s) : 0, 9331011
Agent [candidate] (1.188 s) : 0, 1187646
Total [candidate] (9.294 s) : 0, 9294279
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1183032
Total [baseline] (9.265 s) : 0, 9264703
Agent [candidate] (1.185 s) : 0, 1185052
Total [candidate] (9.227 s) : 0, 9227054
section iast_TELEMETRY_OFF
Agent [baseline] (1.191 s) : 0, 1191050
Total [baseline] (9.293 s) : 0, 9292549
Agent [candidate] (1.196 s) : 0, 1196462
Total [candidate] (9.285 s) : 0, 9285486
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~63c09f48cd, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (728.241 ms) : 0, 728241
BytebuddyAgent [candidate] (723.503 ms) : 0, 723503
GlobalTracer [baseline] (241.786 ms) : 0, 241786
GlobalTracer [candidate] (239.867 ms) : 0, 239867
AppSec [baseline] (55.321 ms) : 0, 55321
AppSec [candidate] (54.489 ms) : 0, 54489
Debugger [baseline] (4.428 ms) : 0, 4428
Debugger [candidate] (4.423 ms) : 0, 4423
Remote Config [baseline] (684.788 µs) : 0, 685
Remote Config [candidate] (683.421 µs) : 0, 683
Telemetry [baseline] (12.138 ms) : 0, 12138
Telemetry [candidate] (14.985 ms) : 0, 14985
section iast
BytebuddyAgent [baseline] (842.614 ms) : 0, 842614
BytebuddyAgent [candidate] (842.893 ms) : 0, 842893
GlobalTracer [baseline] (230.311 ms) : 0, 230311
GlobalTracer [candidate] (231.096 ms) : 0, 231096
IAST [baseline] (22.721 ms) : 0, 22721
IAST [candidate] (22.888 ms) : 0, 22888
AppSec [baseline] (56.376 ms) : 0, 56376
AppSec [candidate] (56.467 ms) : 0, 56467
Debugger [baseline] (4.134 ms) : 0, 4134
Debugger [candidate] (4.159 ms) : 0, 4159
Remote Config [baseline] (603.44 µs) : 0, 603
Remote Config [candidate] (602.226 µs) : 0, 602
Telemetry [baseline] (8.745 ms) : 0, 8745
Telemetry [candidate] (8.757 ms) : 0, 8757
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.548 ms) : 0, 840548
BytebuddyAgent [candidate] (842.009 ms) : 0, 842009
GlobalTracer [baseline] (229.854 ms) : 0, 229854
GlobalTracer [candidate] (229.876 ms) : 0, 229876
IAST [baseline] (22.692 ms) : 0, 22692
IAST [candidate] (22.682 ms) : 0, 22682
AppSec [baseline] (55.686 ms) : 0, 55686
AppSec [candidate] (56.121 ms) : 0, 56121
Debugger [baseline] (4.097 ms) : 0, 4097
Debugger [candidate] (4.131 ms) : 0, 4131
Remote Config [baseline] (673.559 µs) : 0, 674
Remote Config [candidate] (602.57 µs) : 0, 603
Telemetry [baseline] (8.695 ms) : 0, 8695
Telemetry [candidate] (8.791 ms) : 0, 8791
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (846.623 ms) : 0, 846623
BytebuddyAgent [candidate] (851.15 ms) : 0, 851150
GlobalTracer [baseline] (231.83 ms) : 0, 231830
GlobalTracer [candidate] (232.089 ms) : 0, 232089
IAST [baseline] (22.391 ms) : 0, 22391
IAST [candidate] (22.599 ms) : 0, 22599
AppSec [baseline] (56.142 ms) : 0, 56142
AppSec [candidate] (56.264 ms) : 0, 56264
Debugger [baseline] (4.093 ms) : 0, 4093
Debugger [candidate] (4.151 ms) : 0, 4151
Remote Config [baseline] (588.437 µs) : 0, 588
Remote Config [candidate] (595.612 µs) : 0, 596
Telemetry [baseline] (8.605 ms) : 0, 8605
Telemetry [candidate] (8.66 ms) : 0, 8660
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~63c09f48cd, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section baseline
no_agent (386.119 µs) : 366, 407
. : milestone, 386,
iast (519.068 µs) : 497, 541
. : milestone, 519,
iast_FULL (735.171 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (561.76 µs) : 540, 583
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (515.784 µs) : 494, 538
. : milestone, 516,
iast_INACTIVE (463.183 µs) : 442, 484
. : milestone, 463,
iast_TELEMETRY_OFF (501.29 µs) : 480, 523
. : milestone, 501,
tracing (458.743 µs) : 438, 480
. : milestone, 459,
section candidate
no_agent (377.7 µs) : 358, 398
. : milestone, 378,
iast (523.873 µs) : 502, 546
. : milestone, 524,
iast_FULL (736.13 µs) : 714, 758
. : milestone, 736,
iast_GLOBAL (565.774 µs) : 544, 588
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (517.255 µs) : 496, 539
. : milestone, 517,
iast_INACTIVE (466.409 µs) : 445, 488
. : milestone, 466,
iast_TELEMETRY_OFF (502.072 µs) : 480, 524
. : milestone, 502,
tracing (455.726 µs) : 435, 476
. : milestone, 456,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~63c09f48cd, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section baseline
no_agent (1.369 ms) : 1349, 1388
. : milestone, 1369,
appsec (1.738 ms) : 1715, 1762
. : milestone, 1738,
appsec_no_iast (1.751 ms) : 1728, 1774
. : milestone, 1751,
code_origins (1.691 ms) : 1663, 1718
. : milestone, 1691,
iast (1.508 ms) : 1483, 1532
. : milestone, 1508,
profiling (1.558 ms) : 1533, 1583
. : milestone, 1558,
tracing (1.508 ms) : 1484, 1533
. : milestone, 1508,
section candidate
no_agent (1.365 ms) : 1344, 1385
. : milestone, 1365,
appsec (1.749 ms) : 1725, 1772
. : milestone, 1749,
appsec_no_iast (1.743 ms) : 1719, 1768
. : milestone, 1743,
code_origins (1.694 ms) : 1668, 1721
. : milestone, 1694,
iast (1.543 ms) : 1519, 1568
. : milestone, 1543,
profiling (1.527 ms) : 1504, 1550
. : milestone, 1527,
tracing (1.492 ms) : 1466, 1518
. : milestone, 1492,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~63c09f48cd, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section baseline
no_agent (14.731 s) : 14731000, 14731000
. : milestone, 14731000,
appsec (15.112 s) : 15112000, 15112000
. : milestone, 15112000,
iast (19.104 s) : 19104000, 19104000
. : milestone, 19104000,
iast_GLOBAL (18.293 s) : 18293000, 18293000
. : milestone, 18293000,
profiling (15.465 s) : 15465000, 15465000
. : milestone, 15465000,
tracing (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
section candidate
no_agent (14.924 s) : 14924000, 14924000
. : milestone, 14924000,
appsec (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
iast (19.025 s) : 19025000, 19025000
. : milestone, 19025000,
iast_GLOBAL (18.212 s) : 18212000, 18212000
. : milestone, 18212000,
profiling (15.707 s) : 15707000, 15707000
. : milestone, 15707000,
tracing (15.06 s) : 15060000, 15060000
. : milestone, 15060000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~63c09f48cd, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.389 ms) : 2341, 2436
. : milestone, 2389,
iast (2.175 ms) : 2115, 2235
. : milestone, 2175,
iast_GLOBAL (2.218 ms) : 2157, 2278
. : milestone, 2218,
profiling (2.029 ms) : 1981, 2077
. : milestone, 2029,
tracing (2.004 ms) : 1958, 2050
. : milestone, 2004,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.393 ms) : 2345, 2441
. : milestone, 2393,
iast (2.171 ms) : 2111, 2231
. : milestone, 2171,
iast_GLOBAL (2.219 ms) : 2158, 2280
. : milestone, 2219,
profiling (2.005 ms) : 1958, 2052
. : milestone, 2005,
tracing (2.0 ms) : 1953, 2046
. : milestone, 2000,
|
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Apr 11, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | org.flywaydb.flyway | plugin | misk/gradle/libs.versions.toml | gradle | minor | `11.6.0` -> `11.7.0` | | [com.squareup.okio:okio-fakefilesystem](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.10.2` -> `3.11.0` | | [com.squareup.okio:okio](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.10.2` -> `3.11.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | minor | `2.15.0` -> `2.16.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.47.3` -> `1.48.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.47.3` -> `1.48.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | --- ### Release Notes <details> <summary>square/okio (com.squareup.okio:okio-fakefilesystem)</summary> ### [`v3.11.0`](https://github.com/square/okio/blob/HEAD/CHANGELOG.md#Version-3110) *2025-04-09* - Fix: Clear the deflater's byte array reference - New: Faster implementation of `String.decodeHex()` on Kotlin/JS. - New: Declare `EXACTLY_ONCE` execution for blocks like `Closeable.use {}` and `FileSystem.read {}`. - Upgrade: \[Kotlin 2.1.20]\[kotlin\_2\_1\_20]. </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.16.0`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-2160) - \[Feat]: support `com.android.test` projects. - \[Feat]: support typesafe project accessors with opt-in. ```kotlin dependencyAnalysis { useTypesafeProjectAccessors(true) // false by default } ``` </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.48.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.48.1): 1.48.1 ### Components #### Tracer internal logging - 🐛 Remove print line causing unnecessary logs ([#​8687](DataDog/dd-trace-java#8687) - [@​sarahchen6](https://github.com/sarahchen6)) ### [`v1.48.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.48.0): 1.48.0 ### Known Bugs > \[!NOTE] > If you are experiencing issues with spamming timeout logs, please update to the [latest version](https://github.com/DataDog/dd-trace-java/releases/latest) or set [JDK_SOCKET_ENABLED](https://github.com/DataDog/dd-trace-java/blob/33fc3c9a9b7cda3beda88b8b3e5224ae2b10764a/dd-trace-api/src/main/java/datadog/trace/api/config/GeneralConfig.java#L98) to false. ### Components #### Application Security Management (IAST) - ✨ Fix vulnerability location org.jose4j.lang.HashUtil ([#​8610](DataDog/dd-trace-java#8610) - [@​jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness in oracle.ucp.util.OpaqueString ([#​8609](DataDog/dd-trace-java#8609) - [@​jandro996](https://github.com/jandro996)) - ✨ Fix weak hash false positive in oracle.security.o5logon.O5Logon ([#​8608](DataDog/dd-trace-java#8608) - [@​jandro996](https://github.com/jandro996)) - 🐛 Prevent before callsites targeting constructors in super calls ([#​8549](DataDog/dd-trace-java#8549) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Application Security Management (WAF) - ✨ Update login events public SDK to V2 ([#​8620](DataDog/dd-trace-java#8620) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Send RASP LFI capability only when AppSec is statically enabled ([#​8573](DataDog/dd-trace-java#8573) - [@​jandro996](https://github.com/jandro996)) - ✨ Improve detection of missing request end events ([#​8510](DataDog/dd-trace-java#8510) - [@​smola](https://github.com/smola)) - 🧹 Remove remote configuration for API Security sampling rate ([#​8486](DataDog/dd-trace-java#8486) - [@​smola](https://github.com/smola)) - ✨ Add setUser to user monitoring SDK ([#​8482](DataDog/dd-trace-java#8482) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add missing address for signup event ([#​8469](DataDog/dd-trace-java#8469) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Allow login events SDK to be used with appsec disabled ([#​8464](DataDog/dd-trace-java#8464) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for endpoint discovery in spring mvc ([#​8352](DataDog/dd-trace-java#8352) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ New API Security sampling algorithm ([#​8178](DataDog/dd-trace-java#8178) - [@​ValentinZakharov](https://github.com/ValentinZakharov)) #### Build & Tooling - ✨ Add buffer size customizability to JDK UDS support ([#​8629](DataDog/dd-trace-java#8629) - [@​sarahchen6](https://github.com/sarahchen6)) - ✨ Add JDK built-in support for UDS on Java 16+ ([#​8314](DataDog/dd-trace-java#8314) - [@​sarahchen6](https://github.com/sarahchen6)) #### Configuration at Runtime - 🐛 Send RASP LFI capability only when AppSec is statically enabled ([#​8573](DataDog/dd-trace-java#8573) - [@​jandro996](https://github.com/jandro996)) #### Continuous Integration Visibility - 🐛 Prevent double reporting of Scalatest events when using SBT with test forking ([#​8682](DataDog/dd-trace-java#8682) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Shutdown CI Visibility test event handlers before tracer ([#​8677](DataDog/dd-trace-java#8677) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Do not apply JUnit 4 instrumentation to MUnit runners ([#​8675](DataDog/dd-trace-java#8675), [#​8683](DataDog/dd-trace-java#8683) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Remove error log when source path resolution fails on isModified check ([#​8663](DataDog/dd-trace-java#8663) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement tests reordering for JUnit 4 ([#​8650](DataDog/dd-trace-java#8650) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Set default Attempt to Fix retries if none provided from the backend ([#​8615](DataDog/dd-trace-java#8615) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Allow to manually set PR info ([#​8566](DataDog/dd-trace-java#8566) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Test Optimization init when repo root cannot be determined ([#​8533](DataDog/dd-trace-java#8533) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add capabilities tagging ([#​8499](DataDog/dd-trace-java#8499), [#​8540](DataDog/dd-trace-java#8540) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Crash tracking - 🐛 Remove dependency on bash from crash/oome uploder scripts ([#​8652](DataDog/dd-trace-java#8652) - [@​jbachorik](https://github.com/jbachorik)) #### Data Streams Monitoring - ✨ e2e pipeline configuration when data jobs is enabled ([#​8553](DataDog/dd-trace-java#8553) - [@​kr-igor](https://github.com/kr-igor)) #### Dynamic Instrumentation - 🐛 Fix In-Product when config is empty ([#​8679](DataDog/dd-trace-java#8679) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add support for filtering shaded third-party libs ([#​8612](DataDog/dd-trace-java#8612) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add In-Product Enablement ([#​8587](DataDog/dd-trace-java#8587) - [@​jpbempel](https://github.com/jpbempel)) - ✨⚡ Reduce footprint of SourceFile tracking ([#​8524](DataDog/dd-trace-java#8524) - [@​jpbempel](https://github.com/jpbempel)) - ✨⚡ Optimize the SourceFile tracking ([#​8520](DataDog/dd-trace-java#8520) - [@​jpbempel](https://github.com/jpbempel)) #### OpenTracing - 🧹 Remove activeScope() use in OpenTracing shim ([#​8478](DataDog/dd-trace-java#8478) - [@​mcculls](https://github.com/mcculls)) #### Profiling - ✨ Add profiler env check command to AgentCLI ([#​8671](DataDog/dd-trace-java#8671) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.23.0 ([#​8668](DataDog/dd-trace-java#8668) - [@​jbachorik](https://github.com/jbachorik)) - Fix a crash related to ElfParser::loadSymbolTable ([#​191](DataDog/dd-trace-java#191)) by [@​yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#192 - Unwind String.indexOf intrinsic on AArch64 by [@​MattAlp](https://github.com/MattAlp) in DataDog/java-profiler#193 - Fix Java 24 support by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#194 - A set of fixes related to clang, aarch64 and musl pecularities of vmstructs stack unwinder by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#199 - 🐛 Remove process information from JFR recording ([#​8661](DataDog/dd-trace-java#8661) - [@​r1viollet](https://github.com/r1viollet)) - 🐛 Make TempLocationManager USER aware ([#​8605](DataDog/dd-trace-java#8605) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Extract git tags from embedded git.properties and datadog_git.properties ([#​8561](DataDog/dd-trace-java#8561) - [@​wmouchere](https://github.com/wmouchere)) #### Telemetry - 🐛 Fix appsec.rasp.error and appsec.waf.error telemetry metrics ([#​8624](DataDog/dd-trace-java#8624) - [@​jandro996](https://github.com/jandro996)) - ✨ Create metric: appsec.rasp.rule.skipped ([#​8618](DataDog/dd-trace-java#8618) - [@​jandro996](https://github.com/jandro996)) - ✨ Extract git tags from embedded git.properties and datadog_git.properties ([#​8561](DataDog/dd-trace-java#8561) - [@​wmouchere](https://github.com/wmouchere)) #### Testing - 🧹 Simplify ssi tests one-pipeline ([#​8558](DataDog/dd-trace-java#8558) - [@​robertomonteromiguel](https://github.com/robertomonteromiguel)) - ✨ Add smoke tests for java's concurrent API ([#​8438](DataDog/dd-trace-java#8438) - [@​sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - ✨ Adding Support for `TRACE_PROPAGATION_BEHAVIOR_EXTRACT` ([#​8535](DataDog/dd-trace-java#8535) - [@​mhlidd](https://github.com/mhlidd)) #### Tracer core - 🐛 Ensure shaded helpers have unique names ([#​8559](DataDog/dd-trace-java#8559) - [@​amarziali](https://github.com/amarziali)) - ✨ Support common config sources for user-provided git info ([#​8547](DataDog/dd-trace-java#8547) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Make the default config sources more robust when a security manager is installed ([#​8544](DataDog/dd-trace-java#8544) - [@​mcculls](https://github.com/mcculls)) - ✨ Support targeting services with configurations in stable configuration file ([#​8526](DataDog/dd-trace-java#8526) - [@​mtoffl01](https://github.com/mtoffl01)) - ✨ Add new parser for `DD_TAGS` and prioritizing `DD_SERVICE` ([#​8296](DataDog/dd-trace-java#8296) - [@​mhlidd](https://github.com/mhlidd)) #### Tracer internal logging - 🐛 Add missing debug log for the cloudPayloadTaggingServices config ([#​8600](DataDog/dd-trace-java#8600) - [@​ygree](https://github.com/ygree)) - ✨ Add the possibility to output the logs of the Java tracer in JSON ([#​8083](DataDog/dd-trace-java#8083) - [@​cecile75](https://github.com/cecile75)) #### Tracer public API - ✨ Introducing `DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED` Config ([#​8536](DataDog/dd-trace-java#8536) - [@​mhlidd](https://github.com/mhlidd)) - ✨ Config Consistency Round 2 ([#​8489](DataDog/dd-trace-java#8489) - [@​mhlidd](https://github.com/mhlidd)) ### Instrumentations #### - 🐛 Fix NPE in getMdcCopy of LoggingEventInstrumentation ([#​8599](DataDog/dd-trace-java#8599) - [@​ygree](https://github.com/ygree)) #### Apache Spark instrumentation - ✨ Instrument Runtime.exit() to finish spark application spans ([#​8572](DataDog/dd-trace-java#8572) - [@​paul-laffon-dd](https://github.com/paul-laffon-dd)) - ✨ Configure OpenLineage if present in Spark instrumentation ([#​8541](DataDog/dd-trace-java#8541) - [@​mobuchowski](https://github.com/mobuchowski)) #### Armeria Instrumentation - ✨ Support armeria grpc 1.32.3 ([#​8606](DataDog/dd-trace-java#8606) - [@​github-actions](https://github.com/github-actions)\[bot]) #### AWS DynamoDB Instrumentation - ✨ Create DynamoDB instrumentation + add span pointers for `updateItem` and `deleteItem` ([#​8490](DataDog/dd-trace-java#8490) - [@​nhulston](https://github.com/nhulston)) #### AWS SDK instrumentation - ✨ Add DynamoDB in DEFAULT_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES ([#​8595](DataDog/dd-trace-java#8595) - [@​joeyzhao2018](https://github.com/joeyzhao2018)) #### Azure Functions instrumentation - ✨ Enable tracer computed trace metrics by default for Azure Functions ([#​8518](DataDog/dd-trace-java#8518) - [@​duncanpharvey](https://github.com/duncanpharvey)) - 💡 Add azure-functions instrumentation ([#​8432](DataDog/dd-trace-java#8432) - [@​duncanpharvey](https://github.com/duncanpharvey)) #### Core Java language instrumentation - 🐛 Fix ForkJoinPool.execute() instrumentation on Java 21+ ([#​8560](DataDog/dd-trace-java#8560) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Eclipse Vert.x instrumentation - ✨ Add vertx postgresql client instrumentation ([#​8471](DataDog/dd-trace-java#8471) - [@​vandonr](https://github.com/vandonr) - thanks for the contribution!) #### Kafka instrumentation - ✨ Support and test kafka-clients 4 ([#​8581](DataDog/dd-trace-java#8581) - [@​amarziali](https://github.com/amarziali)) #### Kotlin instrumentation - ✨ Avoid disconnected traces when using Kotlin flowOn ([#​8651](DataDog/dd-trace-java#8651) - [@​mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🧹 Migrate OtelContext wrapper to new internal Context API ([#​8645](DataDog/dd-trace-java#8645) - [@​mcculls](https://github.com/mcculls)) #### Spring instrumentation - 🐛 Support CompletableFuture on spring webmvc controllers ([#​8659](DataDog/dd-trace-java#8659) - [@​amarziali](https://github.com/amarziali)) - ✨ Add support for endpoint discovery in spring mvc ([#​8352](DataDog/dd-trace-java#8352) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### WebSocket Instrumentation - ✨ Instrument Jetty websocket pojo ([#​8562](DataDog/dd-trace-java#8562) - [@​amarziali](https://github.com/amarziali)) - 💡 Instrument Java Websocket API (JSR356) ([#​8440](DataDog/dd-trace-java#8440) - [@​amarziali](https://github.com/amarziali)) #### All other instrumentations - ✨ Introduce cache for peer.hostname lookup ([#​8601](DataDog/dd-trace-java#8601) - [@​mcculls](https://github.com/mcculls)) - ✨ Support pekko http 1.1 ([#​8532](DataDog/dd-trace-java#8532) - [@​amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 331314f71acaced3adc75ea5d7e855c248d593fc
amarziali
pushed a commit
that referenced
this pull request
Apr 17, 2025
ValentinZakharov
added a commit
that referenced
this pull request
May 13, 2025
* Implemented WebSocket support for Netty 4.1 * Let propagate unhandled events and fix tests * Refactoring * Refactor netty test and fix instrumentation * Improved pipeline processing - now you can insert handler in any place * Fixed helper * Refactoring * WebSocket Server support for netty-4.0 * Missing handlers use cases for netty-4.1 * Fixed handlers for netty-4.0 * Tests for netty-4.0 * Refactoring * WebSocket Server support for netty-3.8 * Tests for netty-3.8 * Spotless * Fixed tests * Add profiler env check command to AgentCLI (#8671) * Remove dependency on bash from crash/oome uploder scripts (#8652) * Do not apply JUnit 4 instrumentation to MUnit runners (#8675) * Shutdown CI Visibility test event handlers before tracer (#8677) * Prevent double reporting of Scalatest events when using SBT with test forking (#8682) * Fix In-Product when config is empty (#8679) should not stop the product with empty config * Expand MUnit runners filter to catch munit.MUnitRunner in JUnit 4 instrumentation (#8683) * Remove unused TestEventsHandler methods (#8674) * Delete print line (#8686) * Exclude ProxyLeakTask exception from exception profiling (#8666) * Use jvmstat for JDKs 9+ programmatically (#8641) * Update test.retry_reason to use full name of the feature (#8689) * Allow dogstatsd port to be configurable with DD_DOGSTATSD_PORT (#8693) * configurable dogstatsd port * wait the client handshake * move netty ws client to interested modules * Added WebSocket tracing check --------- Co-authored-by: Andrea Marziali <[email protected]> Co-authored-by: Jaroslav Bachorik <[email protected]> Co-authored-by: Nikita Tkachenko <[email protected]> Co-authored-by: Jean-Philippe Bempel <[email protected]> Co-authored-by: Daniel Mohedano <[email protected]> Co-authored-by: Sarah Chen <[email protected]> Co-authored-by: Matt <[email protected]> Co-authored-by: Laplie Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Prevents double reporting of Scalatest events when using SBT with test forking.
When running an SBT build with Test/fork set to true, Scalatest reporter that we instrument is initialised both in the parent process and in the child process.
We only want to instrument the one in the child process, since the child process is where the tests are actually executed.
We distinguish the child process from the parent process by examining the "remote arguments" of the Scalatest runner: in the child process the remote arguments are not empty (as they define how to interact with the parent).
Additional Notes
I could not find a way to determine SBT + Test/fork + Scalatest case automatically, so for the time being the instrumentation has to be activated manually with the
DD_CIVISIBILITY_SCALATEST_FORK_MONITOR_ENABLED
env variable (or corresponding system property).We only have a handful of Scalatest users and if they happen to use SBT and forking we will advise them to activate the property.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]