Skip to content

Exclude ProxyLeakTask exception from exception profiling #8666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025

Conversation

jbachorik
Copy link
Contributor

@jbachorik jbachorik commented Apr 3, 2025

What Does This Do

It adds support for excluding certain exception types from exception profiling

Motivation

Some exception types are used solely for control flow or 'leak detection'. In second case, the exceptions are massively pre-allocated but very rarely thrown. Since our exception profiler works at the level of exception allocations (instrumenting all 'throw' locations would be very, very costly), such exceptions are very misleading, not helpful and are bogging down the profiler needlessly.

Additional Notes

Contributor Checklist

Jira ticket: PROF-10207

@pr-commenter
Copy link

pr-commenter bot commented Apr 3, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/proxy_leak_task
git_commit_date 1744233055 1744276013
git_commit_sha 33fc3c9 32b887c
release_version 1.49.0-SNAPSHOT~33fc3c9a9b 1.48.0-SNAPSHOT~32b887c453
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1744279957 1744279957
ci_job_id 890313637 890313637
ci_pipeline_id 61715476 61715476
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-lh2rzwsp-project-304-concurrent-2-vvrgpqvs 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-lh2rzwsp-project-304-concurrent-2-vvrgpqvs 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~32b887c453, baseline=1.49.0-SNAPSHOT~33fc3c9a9b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060587
Total [baseline] (10.49 s) : 0, 10489671
Agent [candidate] (1.066 s) : 0, 1065825
Total [candidate] (10.502 s) : 0, 10502309
section appsec
Agent [baseline] (1.2 s) : 0, 1199584
Total [baseline] (10.777 s) : 0, 10776814
Agent [candidate] (1.2 s) : 0, 1199535
Total [candidate] (10.793 s) : 0, 10793000
section iast
Agent [baseline] (1.189 s) : 0, 1188546
Total [baseline] (11.046 s) : 0, 11045761
Agent [candidate] (1.184 s) : 0, 1184452
Total [candidate] (11.013 s) : 0, 11012549
section profiling
Agent [baseline] (1.299 s) : 0, 1298771
Total [baseline] (10.947 s) : 0, 10947271
Agent [candidate] (1.29 s) : 0, 1289611
Total [candidate] (10.942 s) : 0, 10942468
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.2 s 138.998 ms (13.1%)
Agent iast 1.189 s 127.96 ms (12.1%)
Agent profiling 1.299 s 238.184 ms (22.5%)
Total tracing 10.49 s -
Total appsec 10.777 s 287.144 ms (2.7%)
Total iast 11.046 s 556.091 ms (5.3%)
Total profiling 10.947 s 457.601 ms (4.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.2 s 133.71 ms (12.5%)
Agent iast 1.184 s 118.627 ms (11.1%)
Agent profiling 1.29 s 223.787 ms (21.0%)
Total tracing 10.502 s -
Total appsec 10.793 s 290.691 ms (2.8%)
Total iast 11.013 s 510.239 ms (4.9%)
Total profiling 10.942 s 440.159 ms (4.2%)
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~32b887c453, baseline=1.49.0-SNAPSHOT~33fc3c9a9b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.274 ms) : 0, 724274
BytebuddyAgent [candidate] (727.417 ms) : 0, 727417
GlobalTracer [baseline] (240.036 ms) : 0, 240036
GlobalTracer [candidate] (242.391 ms) : 0, 242391
AppSec [baseline] (54.532 ms) : 0, 54532
AppSec [candidate] (54.878 ms) : 0, 54878
Debugger [baseline] (4.416 ms) : 0, 4416
Debugger [candidate] (4.427 ms) : 0, 4427
Remote Config [baseline] (698.313 µs) : 0, 698
Remote Config [candidate] (694.707 µs) : 0, 695
Telemetry [baseline] (15.702 ms) : 0, 15702
Telemetry [candidate] (14.947 ms) : 0, 14947
section appsec
BytebuddyAgent [baseline] (742.415 ms) : 0, 742415
BytebuddyAgent [candidate] (742.16 ms) : 0, 742160
GlobalTracer [baseline] (236.345 ms) : 0, 236345
GlobalTracer [candidate] (236.692 ms) : 0, 236692
AppSec [baseline] (176.223 ms) : 0, 176223
AppSec [candidate] (175.579 ms) : 0, 175579
Debugger [baseline] (4.29 ms) : 0, 4290
Debugger [candidate] (4.304 ms) : 0, 4304
Remote Config [baseline] (646.823 µs) : 0, 647
Remote Config [candidate] (641.865 µs) : 0, 642
Telemetry [baseline] (8.247 ms) : 0, 8247
Telemetry [candidate] (8.628 ms) : 0, 8628
IAST [baseline] (21.288 ms) : 0, 21288
IAST [candidate] (21.359 ms) : 0, 21359
section iast
BytebuddyAgent [baseline] (843.95 ms) : 0, 843950
BytebuddyAgent [candidate] (841.252 ms) : 0, 841252
GlobalTracer [baseline] (231.46 ms) : 0, 231460
GlobalTracer [candidate] (230.636 ms) : 0, 230636
AppSec [baseline] (55.9 ms) : 0, 55900
AppSec [candidate] (55.689 ms) : 0, 55689
Debugger [baseline] (4.114 ms) : 0, 4114
Debugger [candidate] (4.146 ms) : 0, 4146
Remote Config [baseline] (596.334 µs) : 0, 596
Remote Config [candidate] (572.774 µs) : 0, 573
Telemetry [baseline] (8.754 ms) : 0, 8754
Telemetry [candidate] (8.618 ms) : 0, 8618
IAST [baseline] (22.912 ms) : 0, 22912
IAST [candidate] (22.683 ms) : 0, 22683
section profiling
ProfilingAgent [baseline] (103.48 ms) : 0, 103480
ProfilingAgent [candidate] (102.694 ms) : 0, 102694
BytebuddyAgent [baseline] (717.548 ms) : 0, 717548
BytebuddyAgent [candidate] (720.155 ms) : 0, 720155
GlobalTracer [baseline] (360.864 ms) : 0, 360864
GlobalTracer [candidate] (351.435 ms) : 0, 351435
AppSec [baseline] (54.708 ms) : 0, 54708
AppSec [candidate] (52.815 ms) : 0, 52815
Debugger [baseline] (4.323 ms) : 0, 4323
Debugger [candidate] (4.243 ms) : 0, 4243
Remote Config [baseline] (701.855 µs) : 0, 702
Remote Config [candidate] (686.888 µs) : 0, 687
Telemetry [baseline] (9.062 ms) : 0, 9062
Telemetry [candidate] (8.864 ms) : 0, 8864
Profiling [baseline] (103.505 ms) : 0, 103505
Profiling [candidate] (102.72 ms) : 0, 102720
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~32b887c453, baseline=1.49.0-SNAPSHOT~33fc3c9a9b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065717
Total [baseline] (8.711 s) : 0, 8710688
Agent [candidate] (1.066 s) : 0, 1066000
Total [candidate] (8.685 s) : 0, 8685427
section iast
Agent [baseline] (1.186 s) : 0, 1186157
Total [baseline] (9.259 s) : 0, 9259272
Agent [candidate] (1.183 s) : 0, 1183463
Total [candidate] (9.252 s) : 0, 9252326
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.191 s) : 0, 1190601
Total [baseline] (9.274 s) : 0, 9273601
Agent [candidate] (1.185 s) : 0, 1184599
Total [candidate] (9.227 s) : 0, 9226587
section iast_TELEMETRY_OFF
Agent [baseline] (1.183 s) : 0, 1182909
Total [baseline] (9.289 s) : 0, 9288855
Agent [candidate] (1.198 s) : 0, 1197862
Total [candidate] (9.29 s) : 0, 9289843
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.186 s 120.441 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.191 s 124.884 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.183 s 117.192 ms (11.0%)
Total tracing 8.711 s -
Total iast 9.259 s 548.583 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.274 s 562.912 ms (6.5%)
Total iast_TELEMETRY_OFF 9.289 s 578.166 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.183 s 117.463 ms (11.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 118.599 ms (11.1%)
Agent iast_TELEMETRY_OFF 1.198 s 131.862 ms (12.4%)
Total tracing 8.685 s -
Total iast 9.252 s 566.899 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.227 s 541.16 ms (6.2%)
Total iast_TELEMETRY_OFF 9.29 s 604.416 ms (7.0%)
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~32b887c453, baseline=1.49.0-SNAPSHOT~33fc3c9a9b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (727.544 ms) : 0, 727544
BytebuddyAgent [candidate] (727.237 ms) : 0, 727237
GlobalTracer [baseline] (242.124 ms) : 0, 242124
GlobalTracer [candidate] (242.309 ms) : 0, 242309
AppSec [baseline] (55.632 ms) : 0, 55632
AppSec [candidate] (56.084 ms) : 0, 56084
Debugger [baseline] (4.463 ms) : 0, 4463
Debugger [candidate] (4.417 ms) : 0, 4417
Remote Config [baseline] (713.71 µs) : 0, 714
Remote Config [candidate] (695.742 µs) : 0, 696
Telemetry [baseline] (14.262 ms) : 0, 14262
Telemetry [candidate] (14.247 ms) : 0, 14247
section iast
BytebuddyAgent [baseline] (841.689 ms) : 0, 841689
BytebuddyAgent [candidate] (840.439 ms) : 0, 840439
GlobalTracer [baseline] (231.066 ms) : 0, 231066
GlobalTracer [candidate] (230.454 ms) : 0, 230454
IAST [baseline] (24.448 ms) : 0, 24448
IAST [candidate] (22.625 ms) : 0, 22625
AppSec [baseline] (54.736 ms) : 0, 54736
AppSec [candidate] (55.646 ms) : 0, 55646
Debugger [baseline] (4.129 ms) : 0, 4129
Debugger [candidate] (4.183 ms) : 0, 4183
Remote Config [baseline] (602.305 µs) : 0, 602
Remote Config [candidate] (606.671 µs) : 0, 607
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.688 ms) : 0, 8688
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (845.189 ms) : 0, 845189
BytebuddyAgent [candidate] (840.854 ms) : 0, 840854
GlobalTracer [baseline] (231.092 ms) : 0, 231092
GlobalTracer [candidate] (230.599 ms) : 0, 230599
IAST [baseline] (23.247 ms) : 0, 23247
IAST [candidate] (22.808 ms) : 0, 22808
AppSec [baseline] (56.663 ms) : 0, 56663
AppSec [candidate] (55.934 ms) : 0, 55934
Debugger [baseline] (4.203 ms) : 0, 4203
Debugger [candidate] (4.164 ms) : 0, 4164
Remote Config [baseline] (619.024 µs) : 0, 619
Remote Config [candidate] (601.883 µs) : 0, 602
Telemetry [baseline] (8.853 ms) : 0, 8853
Telemetry [candidate] (8.748 ms) : 0, 8748
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (840.195 ms) : 0, 840195
BytebuddyAgent [candidate] (850.436 ms) : 0, 850436
GlobalTracer [baseline] (230.291 ms) : 0, 230291
GlobalTracer [candidate] (233.36 ms) : 0, 233360
IAST [baseline] (22.35 ms) : 0, 22350
IAST [candidate] (22.761 ms) : 0, 22761
AppSec [baseline] (56.006 ms) : 0, 56006
AppSec [candidate] (56.703 ms) : 0, 56703
Debugger [baseline] (4.103 ms) : 0, 4103
Debugger [candidate] (4.198 ms) : 0, 4198
Remote Config [baseline] (595.939 µs) : 0, 596
Remote Config [candidate] (611.633 µs) : 0, 612
Telemetry [baseline] (8.579 ms) : 0, 8579
Telemetry [candidate] (8.766 ms) : 0, 8766
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-04-10T09:42:46 2025-04-10T09:50:32
git_branch master jb/proxy_leak_task
git_commit_date 1744233055 1744276013
git_commit_sha 33fc3c9 32b887c
release_version 1.49.0-SNAPSHOT~33fc3c9a9b 1.48.0-SNAPSHOT~32b887c453
start_time 2025-04-10T09:42:32 2025-04-10T09:50:18
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1744279032 1744279032
ci_job_id 890313638 890313638
ci_pipeline_id 61715476 61715476
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ctmiy-ux-project-304-concurrent-2-6f139zky 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ctmiy-ux-project-304-concurrent-2-6f139zky 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~32b887c453, baseline=1.49.0-SNAPSHOT~33fc3c9a9b
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.222 µs) : 359, 400
.   : milestone, 379,
iast (513.845 µs) : 491, 536
.   : milestone, 514,
iast_FULL (734.655 µs) : 713, 757
.   : milestone, 735,
iast_GLOBAL (563.955 µs) : 541, 586
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (513.89 µs) : 492, 536
.   : milestone, 514,
iast_INACTIVE (469.999 µs) : 448, 492
.   : milestone, 470,
iast_TELEMETRY_OFF (509.942 µs) : 487, 533
.   : milestone, 510,
tracing (453.907 µs) : 433, 474
.   : milestone, 454,
section candidate
no_agent (378.899 µs) : 359, 399
.   : milestone, 379,
iast (519.403 µs) : 498, 541
.   : milestone, 519,
iast_FULL (729.241 µs) : 707, 751
.   : milestone, 729,
iast_GLOBAL (569.808 µs) : 547, 593
.   : milestone, 570,
iast_HARDCODED_SECRET_DISABLED (511.523 µs) : 490, 533
.   : milestone, 512,
iast_INACTIVE (462.034 µs) : 441, 483
.   : milestone, 462,
iast_TELEMETRY_OFF (505.797 µs) : 484, 528
.   : milestone, 506,
tracing (465.103 µs) : 444, 486
.   : milestone, 465,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.222 µs [358.849 µs, 399.595 µs] -
iast 513.845 µs [491.198 µs, 536.493 µs] 134.624 µs (35.5%)
iast_FULL 734.655 µs [712.667 µs, 756.642 µs] 355.433 µs (93.7%)
iast_GLOBAL 563.955 µs [541.444 µs, 586.467 µs] 184.734 µs (48.7%)
iast_HARDCODED_SECRET_DISABLED 513.89 µs [491.795 µs, 535.985 µs] 134.669 µs (35.5%)
iast_INACTIVE 469.999 µs [447.828 µs, 492.171 µs] 90.778 µs (23.9%)
iast_TELEMETRY_OFF 509.942 µs [487.338 µs, 532.546 µs] 130.72 µs (34.5%)
tracing 453.907 µs [433.421 µs, 474.393 µs] 74.685 µs (19.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.899 µs [358.709 µs, 399.09 µs] -
iast 519.403 µs [497.546 µs, 541.26 µs] 140.504 µs (37.1%)
iast_FULL 729.241 µs [707.254 µs, 751.227 µs] 350.342 µs (92.5%)
iast_GLOBAL 569.808 µs [546.531 µs, 593.085 µs] 190.909 µs (50.4%)
iast_HARDCODED_SECRET_DISABLED 511.523 µs [490.138 µs, 532.908 µs] 132.624 µs (35.0%)
iast_INACTIVE 462.034 µs [440.947 µs, 483.12 µs] 83.135 µs (21.9%)
iast_TELEMETRY_OFF 505.797 µs [483.598 µs, 527.996 µs] 126.898 µs (33.5%)
tracing 465.103 µs [444.297 µs, 485.909 µs] 86.204 µs (22.8%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~32b887c453, baseline=1.49.0-SNAPSHOT~33fc3c9a9b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1325, 1364
.   : milestone, 1345,
appsec (1.739 ms) : 1715, 1763
.   : milestone, 1739,
appsec_no_iast (1.745 ms) : 1722, 1767
.   : milestone, 1745,
code_origins (1.688 ms) : 1661, 1715
.   : milestone, 1688,
iast (1.51 ms) : 1486, 1535
.   : milestone, 1510,
profiling (1.533 ms) : 1510, 1557
.   : milestone, 1533,
tracing (1.49 ms) : 1465, 1515
.   : milestone, 1490,
section candidate
no_agent (1.369 ms) : 1348, 1389
.   : milestone, 1369,
appsec (1.731 ms) : 1707, 1756
.   : milestone, 1731,
appsec_no_iast (1.724 ms) : 1700, 1748
.   : milestone, 1724,
code_origins (1.689 ms) : 1661, 1718
.   : milestone, 1689,
iast (1.527 ms) : 1503, 1551
.   : milestone, 1527,
profiling (1.53 ms) : 1506, 1553
.   : milestone, 1530,
tracing (1.493 ms) : 1468, 1517
.   : milestone, 1493,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.325 ms, 1.364 ms] -
appsec 1.739 ms [1.715 ms, 1.763 ms] 394.494 µs (29.3%)
appsec_no_iast 1.745 ms [1.722 ms, 1.767 ms] 399.989 µs (29.7%)
code_origins 1.688 ms [1.661 ms, 1.715 ms] 343.316 µs (25.5%)
iast 1.51 ms [1.486 ms, 1.535 ms] 165.702 µs (12.3%)
profiling 1.533 ms [1.51 ms, 1.557 ms] 188.801 µs (14.0%)
tracing 1.49 ms [1.465 ms, 1.515 ms] 145.467 µs (10.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.369 ms [1.348 ms, 1.389 ms] -
appsec 1.731 ms [1.707 ms, 1.756 ms] 362.383 µs (26.5%)
appsec_no_iast 1.724 ms [1.7 ms, 1.748 ms] 355.292 µs (26.0%)
code_origins 1.689 ms [1.661 ms, 1.718 ms] 320.704 µs (23.4%)
iast 1.527 ms [1.503 ms, 1.551 ms] 158.267 µs (11.6%)
profiling 1.53 ms [1.506 ms, 1.553 ms] 160.773 µs (11.7%)
tracing 1.493 ms [1.468 ms, 1.517 ms] 123.931 µs (9.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/proxy_leak_task
git_commit_date 1744233055 1744276013
git_commit_sha 33fc3c9 32b887c
release_version 1.49.0-SNAPSHOT~33fc3c9a9b 1.48.0-SNAPSHOT~32b887c453
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1744279526 1744279526
ci_job_id 890313639 890313639
ci_pipeline_id 61715476 61715476
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-kc2xlj6b-project-304-concurrent-0-wf6i0it8 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-kc2xlj6b-project-304-concurrent-0-wf6i0it8 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~32b887c453, baseline=1.49.0-SNAPSHOT~33fc3c9a9b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (2.387 ms) : 2340, 2434
.   : milestone, 2387,
iast (2.15 ms) : 2091, 2208
.   : milestone, 2150,
iast_GLOBAL (2.203 ms) : 2143, 2262
.   : milestone, 2203,
profiling (2.033 ms) : 1985, 2081
.   : milestone, 2033,
tracing (1.985 ms) : 1940, 2031
.   : milestone, 1985,
section candidate
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (2.379 ms) : 2333, 2425
.   : milestone, 2379,
iast (2.155 ms) : 2096, 2213
.   : milestone, 2155,
iast_GLOBAL (2.203 ms) : 2144, 2262
.   : milestone, 2203,
profiling (2.007 ms) : 1960, 2054
.   : milestone, 2007,
tracing (1.976 ms) : 1930, 2021
.   : milestone, 1976,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.466 ms, 1.489 ms] -
appsec 2.387 ms [2.34 ms, 2.434 ms] 909.686 µs (61.6%)
iast 2.15 ms [2.091 ms, 2.208 ms] 672.616 µs (45.5%)
iast_GLOBAL 2.203 ms [2.143 ms, 2.262 ms] 725.547 µs (49.1%)
profiling 2.033 ms [1.985 ms, 2.081 ms] 555.873 µs (37.6%)
tracing 1.985 ms [1.94 ms, 2.031 ms] 508.351 µs (34.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.464 ms, 1.487 ms] -
appsec 2.379 ms [2.333 ms, 2.425 ms] 903.464 µs (61.2%)
iast 2.155 ms [2.096 ms, 2.213 ms] 679.266 µs (46.0%)
iast_GLOBAL 2.203 ms [2.144 ms, 2.262 ms] 727.618 µs (49.3%)
profiling 2.007 ms [1.96 ms, 2.054 ms] 531.099 µs (36.0%)
tracing 1.976 ms [1.93 ms, 2.021 ms] 499.97 µs (33.9%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~32b887c453, baseline=1.49.0-SNAPSHOT~33fc3c9a9b
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.914 s) : 14914000, 14914000
.   : milestone, 14914000,
appsec (14.968 s) : 14968000, 14968000
.   : milestone, 14968000,
iast (18.905 s) : 18905000, 18905000
.   : milestone, 18905000,
iast_GLOBAL (18.204 s) : 18204000, 18204000
.   : milestone, 18204000,
profiling (14.906 s) : 14906000, 14906000
.   : milestone, 14906000,
tracing (14.954 s) : 14954000, 14954000
.   : milestone, 14954000,
section candidate
no_agent (14.959 s) : 14959000, 14959000
.   : milestone, 14959000,
appsec (14.98 s) : 14980000, 14980000
.   : milestone, 14980000,
iast (18.356 s) : 18356000, 18356000
.   : milestone, 18356000,
iast_GLOBAL (17.977 s) : 17977000, 17977000
.   : milestone, 17977000,
profiling (15.209 s) : 15209000, 15209000
.   : milestone, 15209000,
tracing (14.913 s) : 14913000, 14913000
.   : milestone, 14913000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.914 s [14.914 s, 14.914 s] -
appsec 14.968 s [14.968 s, 14.968 s] 54.0 ms (0.4%)
iast 18.905 s [18.905 s, 18.905 s] 3.991 s (26.8%)
iast_GLOBAL 18.204 s [18.204 s, 18.204 s] 3.29 s (22.1%)
profiling 14.906 s [14.906 s, 14.906 s] -8.0 ms (-0.1%)
tracing 14.954 s [14.954 s, 14.954 s] 40.0 ms (0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.959 s [14.959 s, 14.959 s] -
appsec 14.98 s [14.98 s, 14.98 s] 21.0 ms (0.1%)
iast 18.356 s [18.356 s, 18.356 s] 3.397 s (22.7%)
iast_GLOBAL 17.977 s [17.977 s, 17.977 s] 3.018 s (20.2%)
profiling 15.209 s [15.209 s, 15.209 s] 250.0 ms (1.7%)
tracing 14.913 s [14.913 s, 14.913 s] -46.0 ms (-0.3%)

@jbachorik jbachorik marked this pull request as ready for review April 3, 2025 14:32
@jbachorik jbachorik requested a review from a team as a code owner April 3, 2025 14:32
@jbachorik jbachorik merged commit c65d843 into master Apr 10, 2025
244 of 249 checks passed
@jbachorik jbachorik deleted the jb/proxy_leak_task branch April 10, 2025 11:37
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 10, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request May 7, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`3.22.2` -> `3.22.3` |
|
[com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.28.0` -> `2.28.1` |
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.48.2` -> `1.49.0` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |

---

### Release Notes

<details>
<summary>googleapis/java-logging
(com.google.cloud:google-cloud-logging)</summary>

###
[`v3.22.3`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3223-2025-05-06)

##### Bug Fixes

- **deps:** Update the Java code generator (gapic-generator-java) to
2.56.3
([844f4fa](googleapis/java-logging@844f4fa))

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.46.3
([#&#8203;1801](googleapis/java-logging#1801))
([d7aa7bc](googleapis/java-logging@d7aa7bc))
- Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0
([#&#8203;1803](googleapis/java-logging#1803))
([5967ffe](googleapis/java-logging@5967ffe))
- Update googleapis/sdk-platform-java action to v2.57.0
([#&#8203;1804](googleapis/java-logging#1804))
([e9a27ec](googleapis/java-logging@e9a27ec))

</details>

<details>
<summary>googleapis/java-datastore
(com.google.cloud:google-cloud-datastore)</summary>

###
[`v2.28.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2281-2025-05-06)

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0
([#&#8203;1841](googleapis/java-datastore#1841))
([ac393e6](googleapis/java-datastore@ac393e6))
- Update googleapis/sdk-platform-java action to v2.57.0
([#&#8203;1842](googleapis/java-datastore#1842))
([0745906](googleapis/java-datastore@0745906))

</details>

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.49.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.49.0):
1.49.0

### Components

#### Configuration at Runtime

- ✨ Add process tags as list to remote config payload
([#&#8203;8705](DataDog/dd-trace-java#8705) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Continuous Integration Visibility

- 🐛 Add span propagation for Pekko scheduled tasks
([#&#8203;8765](DataDog/dd-trace-java#8765) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Update test.retry_reason to use full name of the feature
([#&#8203;8689](DataDog/dd-trace-java#8689) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- 🧹 Remove unused TestEventsHandler methods
([#&#8203;8674](DataDog/dd-trace-java#8674) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))

#### Dynamic Instrumentation

- 🐛 Fix exclude identifiers normalization
([#&#8203;8742](DataDog/dd-trace-java#8742) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Make source file tracking asynchronous
([#&#8203;8684](DataDog/dd-trace-java#8684) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add scope filtering for symbol extraction
([#&#8203;8676](DataDog/dd-trace-java#8676) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add support for [@&#8203;key](https://github.com/key) and
[@&#8203;value](https://github.com/value) for Map filtering
([#&#8203;8669](DataDog/dd-trace-java#8669) -
[@&#8203;jpbempel](https://github.com/jpbempel))

#### Library Injection

- ✨ Add system property to force injection of the tracing
library even though multiple javaagents have been detected
([#&#8203;8697](DataDog/dd-trace-java#8697) -
[@&#8203;cecile75](https://github.com/cecile75))

#### Metrics

- ✨ Allow dogstatsd port to be configurable with
DD_DOGSTATSD_PORT
([#&#8203;8693](DataDog/dd-trace-java#8693) -
[@&#8203;randomanderson](https://github.com/randomanderson))

#### Profiling

- ✨ Bump ddprof-java to 1.25.1
([#&#8203;8750](DataDog/dd-trace-java#8750) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- 🐛 Remove cleanup-on-shutdown for temporary files
([#&#8203;8746](DataDog/dd-trace-java#8746) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨⚡ Replace a regex-based SMAP parser with a hand-crafted
one
([#&#8203;8730](DataDog/dd-trace-java#8730) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Improve error reporting on profiler startup
([#&#8203;8714](DataDog/dd-trace-java#8714) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Exclude ProxyLeakTask exception from exception profiling
([#&#8203;8666](DataDog/dd-trace-java#8666) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Use jvmstat for JDKs 9+ programmatically
([#&#8203;8641](DataDog/dd-trace-java#8641) -
[@&#8203;MattAlp](https://github.com/MattAlp))

#### Telemetry

- ✨ Allow dogstatsd port to be configurable with
DD_DOGSTATSD_PORT
([#&#8203;8693](DataDog/dd-trace-java#8693) -
[@&#8203;randomanderson](https://github.com/randomanderson))
- 🐛 Fix appsec.waf.requests telemetry metric
([#&#8203;8644](DataDog/dd-trace-java#8644) -
[@&#8203;jandro996](https://github.com/jandro996))

#### Tracer core

- ✨ Exclude jackson afterburner dynamic classes from
instrumentation
([#&#8203;8747](DataDog/dd-trace-java#8747) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Introduce Java 8 bytecode bridge for instrumentation API
([#&#8203;8736](DataDog/dd-trace-java#8736) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- ⚡🧹 Use byte-buddy classes optimized for Java8+
([#&#8203;8735](DataDog/dd-trace-java#8735) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🐛 Do not set the hibernate or datanucleus span service name when
disabled
([#&#8203;8727](DataDog/dd-trace-java#8727) -
[@&#8203;ygree](https://github.com/ygree))
- ✨ Update bytebuddy and ASM to support JDK 24
([#&#8203;8720](DataDog/dd-trace-java#8720) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))
- 🐛 Turn off JDK socket support by default
([#&#8203;8715](DataDog/dd-trace-java#8715) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🐛 Log warning when trace buffer overflow occurs
([#&#8203;8712](DataDog/dd-trace-java#8712) -
[@&#8203;ygree](https://github.com/ygree))
- ✨🧪 Introducing an internal integration name
([#&#8203;8708](DataDog/dd-trace-java#8708) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Add process tags to client stats payload
([#&#8203;8704](DataDog/dd-trace-java#8704) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Collect process tags for tracing
([#&#8203;8698](DataDog/dd-trace-java#8698) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Stable Config file: target system properties in
process_arguments and support template variables in YamlParser
([#&#8203;8690](DataDog/dd-trace-java#8690) -
[@&#8203;mtoffl01](https://github.com/mtoffl01))
- ✨⚡ Use prefix trie for proxy ignores
([#&#8203;8678](DataDog/dd-trace-java#8678) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Allow agent to be automatically injected when running aside
Log4J patch agent
([#&#8203;8648](DataDog/dd-trace-java#8648) -
[@&#8203;paullegranddc](https://github.com/paullegranddc))
- ✨ Use jvmstat for JDKs 9+ programmatically
([#&#8203;8641](DataDog/dd-trace-java#8641) -
[@&#8203;MattAlp](https://github.com/MattAlp))

#### Tracer internal logging

- 🐛 Delete print line
([#&#8203;8686](DataDog/dd-trace-java#8686) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))

### Instrumentations

#### Akka instrumentation

- 🐛 Handle reentrant scope cleanup in Akka/Pekko actor
instrumentations
([#&#8203;8722](DataDog/dd-trace-java#8722) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Apache Spark instrumentation

- ✨ Use OpenLineage root parent information to generate trace
id ([#&#8203;8726](DataDog/dd-trace-java#8726)
- [@&#8203;mobuchowski](https://github.com/mobuchowski))
- ✨ Spark job cancellation no longer marks application as
failed
([#&#8203;8701](DataDog/dd-trace-java#8701) -
[@&#8203;paul-laffon-dd](https://github.com/paul-laffon-dd))

#### JDBC instrumentation

- 💡 Add support for sybase tds jdbc driver
([#&#8203;8764](DataDog/dd-trace-java#8764) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Kotlin instrumentation

- 🐛 Take defensive copy of parent scope stack when closing nested
coroutines
([#&#8203;8749](DataDog/dd-trace-java#8749) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Reactor instrumentation

- ✨⚡ Do not inspect reactor context when not needed
([#&#8203;8745](DataDog/dd-trace-java#8745) -
[@&#8203;amarziali](https://github.com/amarziali))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 795f347ae34d056efc1194c2f606cee7bca1beea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants