Skip to content

Allow dogstatsd port to be configurable with DD_DOGSTATSD_PORT #8693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

randomanderson
Copy link
Contributor

@randomanderson randomanderson commented Apr 11, 2025

What Does This Do

Currently, the DD_DOGSTATSD_PORT environment variable and dd.dogstatsd.port system property only affect the dogstatsd port used by the embedded JMXFetch client. With this change, the configured port is also used by the tracer's dogstatsd client unless overridden by the agent.

Motivation

With Crashtracking tests, it was impossible to supply another port. Additionally, respecting the environment variable makes the tracer more consistent.

Additional Notes

It's impossible to test this change directly because DDAgentStatsDClientManager makes heavy use of static fields and methods. It's tested indirectly in #8685

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Apr 11, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master landerson/dd-dogstatsd-port
git_commit_date 1744296074 1744390810
git_commit_sha b304f4b 450d5a5
release_version 1.49.0-SNAPSHOT~b304f4bd62 1.49.0-SNAPSHOT~450d5a5e43
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1744394123 1744394123
ci_job_id 893374647 893374647
ci_pipeline_id 61927326 61927326
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-8hvecla2-project-304-concurrent-0-fbnmwar3 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-8hvecla2-project-304-concurrent-0-fbnmwar3 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~450d5a5e43, baseline=1.49.0-SNAPSHOT~b304f4bd62

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064043
Total [baseline] (8.719 s) : 0, 8718565
Agent [candidate] (1.057 s) : 0, 1057187
Total [candidate] (8.664 s) : 0, 8663829
section iast
Agent [baseline] (1.185 s) : 0, 1184930
Total [baseline] (9.272 s) : 0, 9271563
Agent [candidate] (1.193 s) : 0, 1192709
Total [candidate] (9.284 s) : 0, 9284273
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.187 s) : 0, 1187006
Total [baseline] (9.239 s) : 0, 9239082
Agent [candidate] (1.196 s) : 0, 1195614
Total [candidate] (9.268 s) : 0, 9267702
section iast_TELEMETRY_OFF
Agent [baseline] (1.181 s) : 0, 1181216
Total [baseline] (9.244 s) : 0, 9243661
Agent [candidate] (1.182 s) : 0, 1181829
Total [candidate] (9.234 s) : 0, 9233730
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.185 s 120.887 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.187 s 122.963 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.181 s 117.173 ms (11.0%)
Total tracing 8.719 s -
Total iast 9.272 s 552.997 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.239 s 520.517 ms (6.0%)
Total iast_TELEMETRY_OFF 9.244 s 525.096 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.193 s 135.522 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.196 s 138.427 ms (13.1%)
Agent iast_TELEMETRY_OFF 1.182 s 124.642 ms (11.8%)
Total tracing 8.664 s -
Total iast 9.284 s 620.444 ms (7.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.268 s 603.873 ms (7.0%)
Total iast_TELEMETRY_OFF 9.234 s 569.901 ms (6.6%)
gantt
    title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~450d5a5e43, baseline=1.49.0-SNAPSHOT~b304f4bd62

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (725.434 ms) : 0, 725434
BytebuddyAgent [candidate] (720.584 ms) : 0, 720584
GlobalTracer [baseline] (241.097 ms) : 0, 241097
GlobalTracer [candidate] (239.513 ms) : 0, 239513
AppSec [baseline] (56.159 ms) : 0, 56159
AppSec [candidate] (56.73 ms) : 0, 56730
Debugger [baseline] (5.166 ms) : 0, 5166
Debugger [candidate] (4.369 ms) : 0, 4369
Remote Config [baseline] (2.811 ms) : 0, 2811
Remote Config [candidate] (1.402 ms) : 0, 1402
Telemetry [baseline] (9.881 ms) : 0, 9881
Telemetry [candidate] (11.296 ms) : 0, 11296
section iast
BytebuddyAgent [baseline] (839.399 ms) : 0, 839399
BytebuddyAgent [candidate] (844.679 ms) : 0, 844679
GlobalTracer [baseline] (229.814 ms) : 0, 229814
GlobalTracer [candidate] (231.391 ms) : 0, 231391
IAST [baseline] (23.024 ms) : 0, 23024
IAST [candidate] (24.677 ms) : 0, 24677
AppSec [baseline] (55.916 ms) : 0, 55916
AppSec [candidate] (54.728 ms) : 0, 54728
Debugger [baseline] (4.186 ms) : 0, 4186
Debugger [candidate] (4.319 ms) : 0, 4319
Remote Config [baseline] (601.706 µs) : 0, 602
Remote Config [candidate] (629.321 µs) : 0, 629
Telemetry [baseline] (8.638 ms) : 0, 8638
Telemetry [candidate] (8.749 ms) : 0, 8749
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (841.054 ms) : 0, 841054
BytebuddyAgent [candidate] (847.866 ms) : 0, 847866
GlobalTracer [baseline] (230.29 ms) : 0, 230290
GlobalTracer [candidate] (231.161 ms) : 0, 231161
IAST [baseline] (23.673 ms) : 0, 23673
IAST [candidate] (23.826 ms) : 0, 23826
AppSec [baseline] (55.013 ms) : 0, 55013
AppSec [candidate] (55.468 ms) : 0, 55468
Debugger [baseline] (4.226 ms) : 0, 4226
Debugger [candidate] (4.264 ms) : 0, 4264
Remote Config [baseline] (609.495 µs) : 0, 609
Remote Config [candidate] (617.001 µs) : 0, 617
Telemetry [baseline] (8.68 ms) : 0, 8680
Telemetry [candidate] (8.803 ms) : 0, 8803
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (836.336 ms) : 0, 836336
BytebuddyAgent [candidate] (837.439 ms) : 0, 837439
GlobalTracer [baseline] (229.826 ms) : 0, 229826
GlobalTracer [candidate] (229.524 ms) : 0, 229524
IAST [baseline] (22.477 ms) : 0, 22477
IAST [candidate] (22.314 ms) : 0, 22314
AppSec [baseline] (55.749 ms) : 0, 55749
AppSec [candidate] (55.775 ms) : 0, 55775
Debugger [baseline] (4.145 ms) : 0, 4145
Debugger [candidate] (4.149 ms) : 0, 4149
Remote Config [baseline] (629.145 µs) : 0, 629
Remote Config [candidate] (611.679 µs) : 0, 612
Telemetry [baseline] (8.668 ms) : 0, 8668
Telemetry [candidate] (8.573 ms) : 0, 8573
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~450d5a5e43, baseline=1.49.0-SNAPSHOT~b304f4bd62

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055311
Total [baseline] (10.469 s) : 0, 10469473
Agent [candidate] (1.058 s) : 0, 1057795
Total [candidate] (10.464 s) : 0, 10463972
section appsec
Agent [baseline] (1.197 s) : 0, 1197184
Total [baseline] (10.811 s) : 0, 10810631
Agent [candidate] (1.196 s) : 0, 1195777
Total [candidate] (10.807 s) : 0, 10806578
section iast
Agent [baseline] (1.184 s) : 0, 1184429
Total [baseline] (11.023 s) : 0, 11022676
Agent [candidate] (1.188 s) : 0, 1188362
Total [candidate] (11.096 s) : 0, 11095913
section profiling
Agent [baseline] (1.293 s) : 0, 1292615
Total [baseline] (10.931 s) : 0, 10930940
Agent [candidate] (1.294 s) : 0, 1294484
Total [candidate] (10.929 s) : 0, 10928952
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.197 s 141.873 ms (13.4%)
Agent iast 1.184 s 129.118 ms (12.2%)
Agent profiling 1.293 s 237.304 ms (22.5%)
Total tracing 10.469 s -
Total appsec 10.811 s 341.158 ms (3.3%)
Total iast 11.023 s 553.203 ms (5.3%)
Total profiling 10.931 s 461.467 ms (4.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.196 s 137.982 ms (13.0%)
Agent iast 1.188 s 130.567 ms (12.3%)
Agent profiling 1.294 s 236.689 ms (22.4%)
Total tracing 10.464 s -
Total appsec 10.807 s 342.606 ms (3.3%)
Total iast 11.096 s 631.941 ms (6.0%)
Total profiling 10.929 s 464.98 ms (4.4%)
gantt
    title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~450d5a5e43, baseline=1.49.0-SNAPSHOT~b304f4bd62

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.973 ms) : 0, 720973
BytebuddyAgent [candidate] (720.354 ms) : 0, 720354
GlobalTracer [baseline] (238.812 ms) : 0, 238812
GlobalTracer [candidate] (239.26 ms) : 0, 239260
AppSec [baseline] (55.788 ms) : 0, 55788
AppSec [candidate] (57.24 ms) : 0, 57240
Debugger [baseline] (4.368 ms) : 0, 4368
Debugger [candidate] (4.338 ms) : 0, 4338
Remote Config [baseline] (692.696 µs) : 0, 693
Remote Config [candidate] (677.335 µs) : 0, 677
Telemetry [baseline] (11.319 ms) : 0, 11319
Telemetry [candidate] (12.511 ms) : 0, 12511
section appsec
BytebuddyAgent [baseline] (738.19 ms) : 0, 738190
BytebuddyAgent [candidate] (737.567 ms) : 0, 737567
GlobalTracer [baseline] (236.511 ms) : 0, 236511
GlobalTracer [candidate] (235.43 ms) : 0, 235430
AppSec [baseline] (175.125 ms) : 0, 175125
AppSec [candidate] (175.133 ms) : 0, 175133
Debugger [baseline] (4.224 ms) : 0, 4224
Debugger [candidate] (4.566 ms) : 0, 4566
Remote Config [baseline] (637.232 µs) : 0, 637
Remote Config [candidate] (628.451 µs) : 0, 628
Telemetry [baseline] (8.206 ms) : 0, 8206
Telemetry [candidate] (8.198 ms) : 0, 8198
IAST [baseline] (21.851 ms) : 0, 21851
IAST [candidate] (21.781 ms) : 0, 21781
section iast
BytebuddyAgent [baseline] (838.76 ms) : 0, 838760
BytebuddyAgent [candidate] (841.669 ms) : 0, 841669
GlobalTracer [baseline] (230.03 ms) : 0, 230030
GlobalTracer [candidate] (230.745 ms) : 0, 230745
AppSec [baseline] (54.337 ms) : 0, 54337
AppSec [candidate] (55.267 ms) : 0, 55267
Debugger [baseline] (4.215 ms) : 0, 4215
Debugger [candidate] (4.23 ms) : 0, 4230
Remote Config [baseline] (607.427 µs) : 0, 607
Remote Config [candidate] (604.698 µs) : 0, 605
Telemetry [baseline] (8.666 ms) : 0, 8666
Telemetry [candidate] (8.724 ms) : 0, 8724
IAST [baseline] (24.376 ms) : 0, 24376
IAST [candidate] (23.628 ms) : 0, 23628
section profiling
BytebuddyAgent [baseline] (711.641 ms) : 0, 711641
BytebuddyAgent [candidate] (712.737 ms) : 0, 712737
GlobalTracer [baseline] (361.182 ms) : 0, 361182
GlobalTracer [candidate] (361.767 ms) : 0, 361767
AppSec [baseline] (54.175 ms) : 0, 54175
AppSec [candidate] (53.601 ms) : 0, 53601
Debugger [baseline] (4.407 ms) : 0, 4407
Debugger [candidate] (4.442 ms) : 0, 4442
Remote Config [baseline] (662.941 µs) : 0, 663
Remote Config [candidate] (664.82 µs) : 0, 665
Telemetry [baseline] (9.006 ms) : 0, 9006
Telemetry [candidate] (9.044 ms) : 0, 9044
ProfilingAgent [baseline] (101.215 ms) : 0, 101215
ProfilingAgent [candidate] (101.899 ms) : 0, 101899
Profiling [baseline] (101.241 ms) : 0, 101241
Profiling [candidate] (101.924 ms) : 0, 101924
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-04-11T17:25:35 2025-04-11T17:33:19
git_branch master landerson/dd-dogstatsd-port
git_commit_date 1744296074 1744390810
git_commit_sha b304f4b 450d5a5
release_version 1.49.0-SNAPSHOT~b304f4bd62 1.49.0-SNAPSHOT~450d5a5e43
start_time 2025-04-11T17:25:20 2025-04-11T17:33:05
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1744393198 1744393198
ci_job_id 893374648 893374648
ci_pipeline_id 61927326 61927326
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-oax-dvoh-project-304-concurrent-0-abxbdykv 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-oax-dvoh-project-304-concurrent-0-abxbdykv 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~450d5a5e43, baseline=1.49.0-SNAPSHOT~b304f4bd62
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.05 µs) : 357, 400
.   : milestone, 378,
iast (517.716 µs) : 495, 540
.   : milestone, 518,
iast_FULL (727.244 µs) : 705, 749
.   : milestone, 727,
iast_GLOBAL (560.988 µs) : 539, 583
.   : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (515.569 µs) : 494, 537
.   : milestone, 516,
iast_INACTIVE (462.482 µs) : 441, 484
.   : milestone, 462,
iast_TELEMETRY_OFF (503.263 µs) : 481, 525
.   : milestone, 503,
tracing (459.621 µs) : 439, 481
.   : milestone, 460,
section candidate
no_agent (378.506 µs) : 359, 398
.   : milestone, 379,
iast (512.216 µs) : 491, 534
.   : milestone, 512,
iast_FULL (730.683 µs) : 709, 753
.   : milestone, 731,
iast_GLOBAL (568.592 µs) : 545, 592
.   : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (514.965 µs) : 493, 537
.   : milestone, 515,
iast_INACTIVE (466.099 µs) : 445, 488
.   : milestone, 466,
iast_TELEMETRY_OFF (499.354 µs) : 478, 521
.   : milestone, 499,
tracing (459.899 µs) : 439, 481
.   : milestone, 460,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.05 µs [356.573 µs, 399.528 µs] -
iast 517.716 µs [494.944 µs, 540.488 µs] 139.666 µs (36.9%)
iast_FULL 727.244 µs [705.192 µs, 749.296 µs] 349.194 µs (92.4%)
iast_GLOBAL 560.988 µs [538.892 µs, 583.084 µs] 182.938 µs (48.4%)
iast_HARDCODED_SECRET_DISABLED 515.569 µs [493.666 µs, 537.472 µs] 137.519 µs (36.4%)
iast_INACTIVE 462.482 µs [440.763 µs, 484.201 µs] 84.432 µs (22.3%)
iast_TELEMETRY_OFF 503.263 µs [481.277 µs, 525.249 µs] 125.212 µs (33.1%)
tracing 459.621 µs [438.697 µs, 480.545 µs] 81.571 µs (21.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.506 µs [358.829 µs, 398.184 µs] -
iast 512.216 µs [490.556 µs, 533.875 µs] 133.71 µs (35.3%)
iast_FULL 730.683 µs [708.506 µs, 752.86 µs] 352.177 µs (93.0%)
iast_GLOBAL 568.592 µs [545.353 µs, 591.83 µs] 190.085 µs (50.2%)
iast_HARDCODED_SECRET_DISABLED 514.965 µs [493.151 µs, 536.779 µs] 136.458 µs (36.1%)
iast_INACTIVE 466.099 µs [444.695 µs, 487.504 µs] 87.593 µs (23.1%)
iast_TELEMETRY_OFF 499.354 µs [477.791 µs, 520.916 µs] 120.847 µs (31.9%)
tracing 459.899 µs [438.857 µs, 480.94 µs] 81.392 µs (21.5%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~450d5a5e43, baseline=1.49.0-SNAPSHOT~b304f4bd62
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.357 ms) : 1337, 1378
.   : milestone, 1357,
appsec (1.756 ms) : 1733, 1779
.   : milestone, 1756,
appsec_no_iast (1.737 ms) : 1712, 1761
.   : milestone, 1737,
code_origins (1.689 ms) : 1663, 1716
.   : milestone, 1689,
iast (1.509 ms) : 1485, 1533
.   : milestone, 1509,
profiling (1.507 ms) : 1482, 1531
.   : milestone, 1507,
tracing (1.497 ms) : 1472, 1521
.   : milestone, 1497,
section candidate
no_agent (1.357 ms) : 1338, 1377
.   : milestone, 1357,
appsec (1.746 ms) : 1722, 1769
.   : milestone, 1746,
appsec_no_iast (1.741 ms) : 1717, 1765
.   : milestone, 1741,
code_origins (1.702 ms) : 1674, 1729
.   : milestone, 1702,
iast (1.542 ms) : 1516, 1567
.   : milestone, 1542,
profiling (1.51 ms) : 1487, 1533
.   : milestone, 1510,
tracing (1.499 ms) : 1475, 1523
.   : milestone, 1499,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.337 ms, 1.378 ms] -
appsec 1.756 ms [1.733 ms, 1.779 ms] 398.577 µs (29.4%)
appsec_no_iast 1.737 ms [1.712 ms, 1.761 ms] 379.093 µs (27.9%)
code_origins 1.689 ms [1.663 ms, 1.716 ms] 332.007 µs (24.5%)
iast 1.509 ms [1.485 ms, 1.533 ms] 151.636 µs (11.2%)
profiling 1.507 ms [1.482 ms, 1.531 ms] 149.048 µs (11.0%)
tracing 1.497 ms [1.472 ms, 1.521 ms] 139.065 µs (10.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.338 ms, 1.377 ms] -
appsec 1.746 ms [1.722 ms, 1.769 ms] 388.285 µs (28.6%)
appsec_no_iast 1.741 ms [1.717 ms, 1.765 ms] 383.329 µs (28.2%)
code_origins 1.702 ms [1.674 ms, 1.729 ms] 344.076 µs (25.3%)
iast 1.542 ms [1.516 ms, 1.567 ms] 184.091 µs (13.6%)
profiling 1.51 ms [1.487 ms, 1.533 ms] 152.22 µs (11.2%)
tracing 1.499 ms [1.475 ms, 1.523 ms] 141.75 µs (10.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master landerson/dd-dogstatsd-port
git_commit_date 1744296074 1744390810
git_commit_sha b304f4b 450d5a5
release_version 1.49.0-SNAPSHOT~b304f4bd62 1.49.0-SNAPSHOT~450d5a5e43
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1744393825 1744393825
ci_job_id 893374649 893374649
ci_pipeline_id 61927326 61927326
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-oax-dvoh-project-304-concurrent-1-hn71whch 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-oax-dvoh-project-304-concurrent-1-hn71whch 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~450d5a5e43, baseline=1.49.0-SNAPSHOT~b304f4bd62
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.927 s) : 14927000, 14927000
.   : milestone, 14927000,
appsec (14.761 s) : 14761000, 14761000
.   : milestone, 14761000,
iast (18.666 s) : 18666000, 18666000
.   : milestone, 18666000,
iast_GLOBAL (18.122 s) : 18122000, 18122000
.   : milestone, 18122000,
profiling (14.874 s) : 14874000, 14874000
.   : milestone, 14874000,
tracing (14.594 s) : 14594000, 14594000
.   : milestone, 14594000,
section candidate
no_agent (15.479 s) : 15479000, 15479000
.   : milestone, 15479000,
appsec (14.984 s) : 14984000, 14984000
.   : milestone, 14984000,
iast (18.27 s) : 18270000, 18270000
.   : milestone, 18270000,
iast_GLOBAL (18.156 s) : 18156000, 18156000
.   : milestone, 18156000,
profiling (15.795 s) : 15795000, 15795000
.   : milestone, 15795000,
tracing (14.884 s) : 14884000, 14884000
.   : milestone, 14884000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.927 s [14.927 s, 14.927 s] -
appsec 14.761 s [14.761 s, 14.761 s] -166.0 ms (-1.1%)
iast 18.666 s [18.666 s, 18.666 s] 3.739 s (25.0%)
iast_GLOBAL 18.122 s [18.122 s, 18.122 s] 3.195 s (21.4%)
profiling 14.874 s [14.874 s, 14.874 s] -53.0 ms (-0.4%)
tracing 14.594 s [14.594 s, 14.594 s] -333.0 ms (-2.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.479 s [15.479 s, 15.479 s] -
appsec 14.984 s [14.984 s, 14.984 s] -495.0 ms (-3.2%)
iast 18.27 s [18.27 s, 18.27 s] 2.791 s (18.0%)
iast_GLOBAL 18.156 s [18.156 s, 18.156 s] 2.677 s (17.3%)
profiling 15.795 s [15.795 s, 15.795 s] 316.0 ms (2.0%)
tracing 14.884 s [14.884 s, 14.884 s] -595.0 ms (-3.8%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~450d5a5e43, baseline=1.49.0-SNAPSHOT~b304f4bd62
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1492
.   : milestone, 1480,
appsec (2.392 ms) : 2345, 2439
.   : milestone, 2392,
iast (2.17 ms) : 2111, 2229
.   : milestone, 2170,
iast_GLOBAL (2.219 ms) : 2160, 2278
.   : milestone, 2219,
profiling (2.491 ms) : 2310, 2671
.   : milestone, 2491,
tracing (1.999 ms) : 1954, 2044
.   : milestone, 1999,
section candidate
no_agent (1.486 ms) : 1475, 1498
.   : milestone, 1486,
appsec (2.386 ms) : 2339, 2433
.   : milestone, 2386,
iast (2.164 ms) : 2106, 2223
.   : milestone, 2164,
iast_GLOBAL (2.206 ms) : 2147, 2266
.   : milestone, 2206,
profiling (2.004 ms) : 1958, 2051
.   : milestone, 2004,
tracing (2.0 ms) : 1954, 2045
.   : milestone, 2000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.48 ms [1.468 ms, 1.492 ms] -
appsec 2.392 ms [2.345 ms, 2.439 ms] 912.261 µs (61.6%)
iast 2.17 ms [2.111 ms, 2.229 ms] 689.774 µs (46.6%)
iast_GLOBAL 2.219 ms [2.16 ms, 2.278 ms] 738.969 µs (49.9%)
profiling 2.491 ms [2.31 ms, 2.671 ms] 1.011 ms (68.3%)
tracing 1.999 ms [1.954 ms, 2.044 ms] 519.008 µs (35.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.486 ms [1.475 ms, 1.498 ms] -
appsec 2.386 ms [2.339 ms, 2.433 ms] 899.52 µs (60.5%)
iast 2.164 ms [2.106 ms, 2.223 ms] 678.146 µs (45.6%)
iast_GLOBAL 2.206 ms [2.147 ms, 2.266 ms] 720.19 µs (48.5%)
profiling 2.004 ms [1.958 ms, 2.051 ms] 518.177 µs (34.9%)
tracing 2.0 ms [1.954 ms, 2.045 ms] 513.619 µs (34.6%)

@randomanderson randomanderson enabled auto-merge (squash) April 11, 2025 18:21
@randomanderson randomanderson merged commit b00c24e into master Apr 14, 2025
253 checks passed
@randomanderson randomanderson deleted the landerson/dd-dogstatsd-port branch April 14, 2025 06:31
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 14, 2025
amarziali pushed a commit that referenced this pull request Apr 17, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request May 7, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`3.22.2` -> `3.22.3` |
|
[com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.28.0` -> `2.28.1` |
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.48.2` -> `1.49.0` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |

---

### Release Notes

<details>
<summary>googleapis/java-logging
(com.google.cloud:google-cloud-logging)</summary>

###
[`v3.22.3`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3223-2025-05-06)

##### Bug Fixes

- **deps:** Update the Java code generator (gapic-generator-java) to
2.56.3
([844f4fa](googleapis/java-logging@844f4fa))

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.46.3
([#&#8203;1801](googleapis/java-logging#1801))
([d7aa7bc](googleapis/java-logging@d7aa7bc))
- Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0
([#&#8203;1803](googleapis/java-logging#1803))
([5967ffe](googleapis/java-logging@5967ffe))
- Update googleapis/sdk-platform-java action to v2.57.0
([#&#8203;1804](googleapis/java-logging#1804))
([e9a27ec](googleapis/java-logging@e9a27ec))

</details>

<details>
<summary>googleapis/java-datastore
(com.google.cloud:google-cloud-datastore)</summary>

###
[`v2.28.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2281-2025-05-06)

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0
([#&#8203;1841](googleapis/java-datastore#1841))
([ac393e6](googleapis/java-datastore@ac393e6))
- Update googleapis/sdk-platform-java action to v2.57.0
([#&#8203;1842](googleapis/java-datastore#1842))
([0745906](googleapis/java-datastore@0745906))

</details>

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.49.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.49.0):
1.49.0

### Components

#### Configuration at Runtime

- ✨ Add process tags as list to remote config payload
([#&#8203;8705](DataDog/dd-trace-java#8705) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Continuous Integration Visibility

- 🐛 Add span propagation for Pekko scheduled tasks
([#&#8203;8765](DataDog/dd-trace-java#8765) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Update test.retry_reason to use full name of the feature
([#&#8203;8689](DataDog/dd-trace-java#8689) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- 🧹 Remove unused TestEventsHandler methods
([#&#8203;8674](DataDog/dd-trace-java#8674) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))

#### Dynamic Instrumentation

- 🐛 Fix exclude identifiers normalization
([#&#8203;8742](DataDog/dd-trace-java#8742) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Make source file tracking asynchronous
([#&#8203;8684](DataDog/dd-trace-java#8684) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add scope filtering for symbol extraction
([#&#8203;8676](DataDog/dd-trace-java#8676) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add support for [@&#8203;key](https://github.com/key) and
[@&#8203;value](https://github.com/value) for Map filtering
([#&#8203;8669](DataDog/dd-trace-java#8669) -
[@&#8203;jpbempel](https://github.com/jpbempel))

#### Library Injection

- ✨ Add system property to force injection of the tracing
library even though multiple javaagents have been detected
([#&#8203;8697](DataDog/dd-trace-java#8697) -
[@&#8203;cecile75](https://github.com/cecile75))

#### Metrics

- ✨ Allow dogstatsd port to be configurable with
DD_DOGSTATSD_PORT
([#&#8203;8693](DataDog/dd-trace-java#8693) -
[@&#8203;randomanderson](https://github.com/randomanderson))

#### Profiling

- ✨ Bump ddprof-java to 1.25.1
([#&#8203;8750](DataDog/dd-trace-java#8750) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- 🐛 Remove cleanup-on-shutdown for temporary files
([#&#8203;8746](DataDog/dd-trace-java#8746) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨⚡ Replace a regex-based SMAP parser with a hand-crafted
one
([#&#8203;8730](DataDog/dd-trace-java#8730) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Improve error reporting on profiler startup
([#&#8203;8714](DataDog/dd-trace-java#8714) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Exclude ProxyLeakTask exception from exception profiling
([#&#8203;8666](DataDog/dd-trace-java#8666) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Use jvmstat for JDKs 9+ programmatically
([#&#8203;8641](DataDog/dd-trace-java#8641) -
[@&#8203;MattAlp](https://github.com/MattAlp))

#### Telemetry

- ✨ Allow dogstatsd port to be configurable with
DD_DOGSTATSD_PORT
([#&#8203;8693](DataDog/dd-trace-java#8693) -
[@&#8203;randomanderson](https://github.com/randomanderson))
- 🐛 Fix appsec.waf.requests telemetry metric
([#&#8203;8644](DataDog/dd-trace-java#8644) -
[@&#8203;jandro996](https://github.com/jandro996))

#### Tracer core

- ✨ Exclude jackson afterburner dynamic classes from
instrumentation
([#&#8203;8747](DataDog/dd-trace-java#8747) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Introduce Java 8 bytecode bridge for instrumentation API
([#&#8203;8736](DataDog/dd-trace-java#8736) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- ⚡🧹 Use byte-buddy classes optimized for Java8+
([#&#8203;8735](DataDog/dd-trace-java#8735) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🐛 Do not set the hibernate or datanucleus span service name when
disabled
([#&#8203;8727](DataDog/dd-trace-java#8727) -
[@&#8203;ygree](https://github.com/ygree))
- ✨ Update bytebuddy and ASM to support JDK 24
([#&#8203;8720](DataDog/dd-trace-java#8720) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))
- 🐛 Turn off JDK socket support by default
([#&#8203;8715](DataDog/dd-trace-java#8715) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🐛 Log warning when trace buffer overflow occurs
([#&#8203;8712](DataDog/dd-trace-java#8712) -
[@&#8203;ygree](https://github.com/ygree))
- ✨🧪 Introducing an internal integration name
([#&#8203;8708](DataDog/dd-trace-java#8708) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Add process tags to client stats payload
([#&#8203;8704](DataDog/dd-trace-java#8704) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Collect process tags for tracing
([#&#8203;8698](DataDog/dd-trace-java#8698) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Stable Config file: target system properties in
process_arguments and support template variables in YamlParser
([#&#8203;8690](DataDog/dd-trace-java#8690) -
[@&#8203;mtoffl01](https://github.com/mtoffl01))
- ✨⚡ Use prefix trie for proxy ignores
([#&#8203;8678](DataDog/dd-trace-java#8678) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Allow agent to be automatically injected when running aside
Log4J patch agent
([#&#8203;8648](DataDog/dd-trace-java#8648) -
[@&#8203;paullegranddc](https://github.com/paullegranddc))
- ✨ Use jvmstat for JDKs 9+ programmatically
([#&#8203;8641](DataDog/dd-trace-java#8641) -
[@&#8203;MattAlp](https://github.com/MattAlp))

#### Tracer internal logging

- 🐛 Delete print line
([#&#8203;8686](DataDog/dd-trace-java#8686) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))

### Instrumentations

#### Akka instrumentation

- 🐛 Handle reentrant scope cleanup in Akka/Pekko actor
instrumentations
([#&#8203;8722](DataDog/dd-trace-java#8722) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Apache Spark instrumentation

- ✨ Use OpenLineage root parent information to generate trace
id ([#&#8203;8726](DataDog/dd-trace-java#8726)
- [@&#8203;mobuchowski](https://github.com/mobuchowski))
- ✨ Spark job cancellation no longer marks application as
failed
([#&#8203;8701](DataDog/dd-trace-java#8701) -
[@&#8203;paul-laffon-dd](https://github.com/paul-laffon-dd))

#### JDBC instrumentation

- 💡 Add support for sybase tds jdbc driver
([#&#8203;8764](DataDog/dd-trace-java#8764) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Kotlin instrumentation

- 🐛 Take defensive copy of parent scope stack when closing nested
coroutines
([#&#8203;8749](DataDog/dd-trace-java#8749) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Reactor instrumentation

- ✨⚡ Do not inspect reactor context when not needed
([#&#8203;8745](DataDog/dd-trace-java#8745) -
[@&#8203;amarziali](https://github.com/amarziali))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 795f347ae34d056efc1194c2f606cee7bca1beea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants