Skip to content

Forms : Consume latest api #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 12, 2024
Merged

Forms : Consume latest api #506

merged 7 commits into from
Jul 12, 2024

Conversation

kaushikrw
Copy link
Collaborator

@kaushikrw kaushikrw commented Jul 10, 2024 •
edited
Loading

Related to issue: #

Description:

Consumes the latest api from core. Also adds minor improvements to the usability.

Summary of changes:

  • The toolkit now uses addAttachmentOrNull().
  • The toolkit now uses sdk impl of FormAttachment.createThumbnail.
  • The default sorting order of attachments has been refactored internally. The list has to be reversed initially so that the newest attachments are on the left, which is specified in the toolkit design.
  • Deleting an attachment displays a Toast message showing a confirmation. This also helps since the lazy list animations are currently experimental.
  • If an attachment is already loaded as indicated by FormAttachment.isLocal, then the attachment is loaded automatically when the form is closed and re-opened.
  • Fixes a bug with new attachment names where the extension of the file was not included in the comparison between existing file names.
  • Fixes a bug where the result of applyEdits on form submission wasn't being displayed in case of failure.

Pre-merge Checklist

  • a vTest Job for this PR has been run
    • link:
  • Unit and/or integration tests have been added to exercise this PR's logic, and the tests are passing:
    • Yes
    • No

@kaushikrw kaushikrw changed the base branch from v.next to feature-branches/forms July 10, 2024 21:37
@kaushikrw kaushikrw self-assigned this Jul 10, 2024
@kaushikrw kaushikrw marked this pull request as ready for review July 11, 2024 16:17
@kaushikrw kaushikrw requested a review from sorenoid July 11, 2024 16:17
@kaushikrw kaushikrw merged commit 9d44cad into feature-branches/forms Jul 12, 2024
@kaushikrw kaushikrw deleted the kaushik/forms/consume-latest-api branch July 12, 2024 23:05
kaushikrw added a commit that referenced this pull request Jul 18, 2024
@kaushikrw
Merge Feature branches/forms into v.next (#520)
780ba20 
* added horizontal scrollbar (#473)

* `Forms` : Add attachment tests (#480)

* `Forms` : Refactor tests (#488)

* Update CorePrototypes.kt (#494)

* `Forms` : handle empty attachments (#498)

* restrict download and viewing attachments of 0 size

* show error along with load

* ignore non-default formattachmentelement (#499)

* `Forms` : Fix strings (#500)

* `Forms` : Micro-app update oauth credentials (#507)

* refactor generating new attachment names (#505)

* `Form` : Attachment theming (#490)

* `Forms` : Consume latest api (#506)

* make thumbnails part of the state object (#514)

* add attachment size restrictions for loading (#518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenoid sorenoid sorenoid approved these changes

Assignees

@kaushikrw kaushikrw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaushikrw @sorenoid