Forms : fix thumbnails mismatch
#514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenoid
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Is it not possible to inject something unique into the FormAttachmentState at creation time, like a UUID, then use that as the name of the file on disk?
There was a problem hiding this comment.
That UUID would need be the same every time to re-fetch the thumbnail on the next launch of the Form. Otherwise, it would end up creating the thumbnail many times as the form is closed and re-opened.
sorenoid
approved these changes
Jul 16, 2024
3 tasks
kaushikrw
added a commit
that referenced
this pull request
Jul 18, 2024
* added horizontal scrollbar (#473) * `Forms` : Add attachment tests (#480) * `Forms` : Refactor tests (#488) * Update CorePrototypes.kt (#494) * `Forms` : handle empty attachments (#498) * restrict download and viewing attachments of 0 size * show error along with load * ignore non-default formattachmentelement (#499) * `Forms` : Fix strings (#500) * `Forms` : Micro-app update oauth credentials (#507) * refactor generating new attachment names (#505) * `Form` : Attachment theming (#490) * `Forms` : Consume latest api (#506) * make thumbnails part of the state object (#514) * add attachment size restrictions for loading (#518)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: #apollo/781
Description:
Fixes an issue where thumbnails for a
FormAttachmentare re-used. This PR refactors the thumbnail creation logic to fix the issue.Summary of changes:
FormAttachmentState.Attachment.idproperty is not unique when the attachment has just been added and is not yet synced with the service. Hence there is no unique property available to name the thumbnail file.Pre-merge Checklist