Forms : Attachment size based functionality restrictions
#518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenoid
approved these changes
Jul 18, 2024
kaushikrw
added a commit
that referenced
this pull request
Jul 18, 2024
* added horizontal scrollbar (#473) * `Forms` : Add attachment tests (#480) * `Forms` : Refactor tests (#488) * Update CorePrototypes.kt (#494) * `Forms` : handle empty attachments (#498) * restrict download and viewing attachments of 0 size * show error along with load * ignore non-default formattachmentelement (#499) * `Forms` : Fix strings (#500) * `Forms` : Micro-app update oauth credentials (#507) * refactor generating new attachment names (#505) * `Form` : Attachment theming (#490) * `Forms` : Consume latest api (#506) * make thumbnails part of the state object (#514) * add attachment size restrictions for loading (#518)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: #apollo/775, #apollo/768
Description:
Restricts rename/delete for empty attachment. This is because rename/delete on an 0 sized attachment will result in error when
applyEdits()is called.Blocks download and rename of large attachments of > 50 MB. This is because renaming an attachment will load the attachment into memory which we are trying to avoid
Summary of changes:
FormAttachmentState.maxAttachmentSizespecifies the max allowed attachment size that can be loaded. This is 50 MB currently.FormAttachmentState.AttachmentSizeLimitExceededException- indicates attachment size exceeds the maximum limit.EmptyAttachmentException- indicates attachment size is 0.AttachmentTilecan now collect on theFormAttachmentState.loadStatusto listen to failures and display a toast accordingly.FormAttachmentState.maxAttachmentSizePre-merge Checklist