-
Notifications
You must be signed in to change notification settings - Fork 28
Move all openapi specs to api/specs #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
pcrespov
added a commit
that referenced
this issue
Nov 15, 2018
Moving openapi specs of webserver to apihub/specs - cleanup config of subsystems. Every subsystem injects config schema (see _config.py submodules) - cleanup webserver skeleton - rest subsystem loads specs from file or url - fix openapi envelopes - fix servicelib auto-routing - connected to #309 ------ * Split sockets subsystem into setup and handlers Added s3 subsystem * Removed application_keys.py * Upgrade requests to version 2.20.0 to solve vulnerability alarm * Added custom variables (OSPARC_SIMCORE_REPO_ROOTDIR) for the config file Fixes config folder key * Fixes enveloped schemas to have null error. Modifies the test_conventions... to adapt to new criteria * Replaced main.disable_services by "enabled" flags in every service * Fixes login tests. Added new variable in config * Enhances auto routing in servicelib - separation of concerns to allow filtering - added strict/non-strict checks * Synced openapi versions and conventions with basepath Added testing and done some fixes * Removes dynamic creation of openapi server specs. Now path-only server definition overcomes all validation specs issues * Changes after merging storage PR - converted storage_settings into storage_config - injected storage_config.schema into application_config.schema - merged login.settings into login.cfg - moved new oas3 api models and paths to api/specs Changes to be committed: modified: ../../../api/specs/shared/schemas/error.yaml modified: ../../../api/specs/shared/schemas/running_service.yaml renamed: src/simcore_service_webserver/oas3/v0/components/schemas/files.yaml -> ../../../api/specs/webserver/v0/components/schemas/files.yaml renamed: src/simcore_service_webserver/oas3/v0/components/schemas/locations.yaml -> ../../../api/specs/webserver/v0/components/schemas/locations.yaml renamed: src/simcore_service_webserver/oas3/v0/components/schemas/responses.yaml -> ../../../api/specs/webserver/v0/components/schemas/presigned_link.yaml modified: ../../../api/specs/webserver/v0/openapi.yaml modified: src/simcore_service_webserver/application_config.py * Recovered POSTGRES_HOST/PORT environ-devel variables so dev can point to dev db in masu Fixes config tests
pcrespov
added a commit
that referenced
this issue
Nov 27, 2018
Moves storage service openapi specs into ``api/specs``. It is the last service, so closes #309 * Fixes typos in client after bad merge * Moved oas3/v0 -> api/specs/storage/v0 Removed reference to oas3 in setup.py Added config rest section to set the remote or local location of apispecs repo rest.py loads oas doc, validates and proceeds with setup as before Oas3 is not anymore a resource. Removed all references as a resource Cleanup - removed cyclic dependency in settings - renamed settings_config as config_schema * servicelib: Added some utils to find repo dirs * storage/tests/test_config passes - Adds workspace variables in config-files - Update config files with new section - Adds APIHUB_HOST, _PORT in storage docker-compose - Fixes duplication of docker-compose storage service * Fixes pytest-asyncio loop issue in storage Copied changes in storage files from PR #355 - commit ff814d9 * Fixes openapi servers in specs adapting tests: - Adds new environ variables in tests fixtures - adds new config section * tests cleanup: with pytest-aiohttp no need to mark async tests * Fixes node_ports tests. Adds apihub+storage in the fixtures * Cleanup director/tests - Added loop dependency (might help in windows version) - cleanup tests_registry_proxy.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 situatios:
a) developing in the host and service has a filepath to api/specs
b) served via apihub (add config)
The text was updated successfully, but these errors were encountered: