-
Notifications
You must be signed in to change notification settings - Fork 28
Users subsystem in webserver #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pcrespov
merged 140 commits into
ITISFoundation:master
from
pcrespov:is239+304+188/users
Nov 23, 2018
Merged
Users subsystem in webserver #355
pcrespov
merged 140 commits into
ITISFoundation:master
from
pcrespov:is239+304+188/users
Nov 23, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end for users subsystem in webserver
Origin seems an incompatibility between pytest-asyncio and pytest-aiohttp plugins: See pytest-dev/pytest-asyncio#76. Disabled the former.
…ore into is239+304+188/users
Removed pytest.mark.asyncio decorators. no need with pytest-aiohttp
mguidon
approved these changes
Nov 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice. I like the tests.
modification on front-end
pcrespov
pushed a commit
to pcrespov/osparc-simcore
that referenced
this pull request
Nov 23, 2018
Copied changes in storage files from PR ITISFoundation#355 - commit ff814d9
odeimaiz
approved these changes
Nov 23, 2018
pcrespov
added a commit
that referenced
this pull request
Nov 27, 2018
Moves storage service openapi specs into ``api/specs``. It is the last service, so closes #309 * Fixes typos in client after bad merge * Moved oas3/v0 -> api/specs/storage/v0 Removed reference to oas3 in setup.py Added config rest section to set the remote or local location of apispecs repo rest.py loads oas doc, validates and proceeds with setup as before Oas3 is not anymore a resource. Removed all references as a resource Cleanup - removed cyclic dependency in settings - renamed settings_config as config_schema * servicelib: Added some utils to find repo dirs * storage/tests/test_config passes - Adds workspace variables in config-files - Update config files with new section - Adds APIHUB_HOST, _PORT in storage docker-compose - Fixes duplication of docker-compose storage service * Fixes pytest-asyncio loop issue in storage Copied changes in storage files from PR #355 - commit ff814d9 * Fixes openapi servers in specs adapting tests: - Adds new environ variables in tests fixtures - adds new config section * tests cleanup: with pytest-aiohttp no need to mark async tests * Fixes node_ports tests. Adds apihub+storage in the fixtures * Cleanup director/tests - Added loop dependency (might help in windows version) - cleanup tests_registry_proxy.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Implements users subsystem in webserver
Related issue number
connected to #239 , closes #239
connected to #188
Checklist