Skip to content

Users subsystem in webserver #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 140 commits into from
Nov 23, 2018

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 21, 2018

What do these changes do?

Implements users subsystem in webserver

  • implements API to get profile and CRUD to tokens
  • updated tokens db tables
  • implements front-end ui for user profile and tokens
  • removes pytest-asyncio due to incompatible loops with pytest-aiohttp. Changes the way async fixtures are implemented (they need to depend on the pytest-aiohttp loop). Tests of storage, director and webserver were modified

Related issue number

connected to #239 , closes #239
connected to #188

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

Pedro Crespo and others added 30 commits July 6, 2018 14:34
@ghost ghost assigned odeimaiz Nov 22, 2018
Pedro Crespo added 5 commits November 22, 2018 10:27
Origin seems an incompatibility between pytest-asyncio and pytest-aiohttp plugins:
See pytest-dev/pytest-asyncio#76. Disabled the former.
Removed pytest.mark.asyncio decorators. no need with pytest-aiohttp
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. I like the tests.

@pcrespov pcrespov changed the title WIP: users subsystem in webserver Users subsystem in webserver Nov 23, 2018
@pcrespov pcrespov added this to the Sagittaron milestone Nov 23, 2018
pcrespov pushed a commit to pcrespov/osparc-simcore that referenced this pull request Nov 23, 2018
Copied changes in storage files from PR ITISFoundation#355 - commit ff814d9
@pcrespov pcrespov merged commit 6e0f326 into ITISFoundation:master Nov 23, 2018
@ghost ghost removed the review label Nov 23, 2018
@pcrespov pcrespov deleted the is239+304+188/users branch November 23, 2018 21:53
pcrespov added a commit that referenced this pull request Nov 27, 2018
Moves storage service openapi specs into ``api/specs``. It is the last service, so closes #309 

* Fixes typos in client after bad merge

* Moved oas3/v0 -> api/specs/storage/v0
Removed reference to oas3 in setup.py
Added config rest section to set the remote or local location of apispecs repo
rest.py loads oas doc, validates and proceeds with setup as before
Oas3 is not anymore a resource. Removed all references as a resource
Cleanup
 - removed cyclic dependency in settings
 - renamed settings_config as config_schema

* servicelib: Added some utils to find repo dirs

* storage/tests/test_config passes
- Adds workspace variables in config-files
- Update config files with new section
- Adds APIHUB_HOST, _PORT in storage docker-compose
- Fixes duplication of docker-compose storage service

* Fixes pytest-asyncio loop issue in storage
Copied changes in storage files from PR #355 - commit ff814d9

* Fixes openapi servers in specs
adapting tests:
 - Adds new environ variables in tests fixtures
 - adds new config section

* tests cleanup: with pytest-aiohttp no need to mark async tests

* Fixes node_ports tests.
Adds apihub+storage in the fixtures

* Cleanup director/tests
- Added loop dependency (might help in windows version)
- cleanup tests_registry_proxy.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User settings with tokens
3 participants