-
Notifications
You must be signed in to change notification settings - Fork 29
[maintenance] black-formatted packages/services and new common.Makefile #1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b388370
to
8397ee4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
=========================================
Coverage ? 72.75%
=========================================
Files ? 201
Lines ? 8356
Branches ? 937
=========================================
Hits ? 6079
Misses ? 2005
Partials ? 272
Continue to review full report at Codecov.
|
ade02b5
to
cd567bc
Compare
services/web/server/src/simcore_service_webserver/projects/projects_api.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/resource_manager/websocket_manager.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some things need to be reviewed in pair
@sanderegg did you see the FIXME: PC->SAN?? comments. Perhaps we can discuss them tomorrow? |
@mguidon could you please help fixing the issues reported in storage, please? https://codeclimate.com/github/ITISFoundation/osparc-simcore/pull/1342 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very pretty!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh boy. Beware of the robots. Go ahead and merge.
@mguidon I was expecting whether you could expect some time helping me fixing https://codeclimate.com/github/ITISFoundation/osparc-simcore/pull/1342 |
I see, sorry missed that one. |
Let me know when you have time |
Failure in CI while building images is fixed in PR #1353. Once that PR is in, this shall follow |
What do these changes do?
scripts/common.Makefile
collects common recipes: see how services and packages Makefiles are now simplifiedpprint
in the logsHINTS on Unhandled exceptions in tasks
Added some hints and logs on possible source of this problem:
and
engineio/async_drivers/aiohttp.py:114
shows thatIOError = OSError
is raised when received data is corrupted!!And see web-sockets memory allocation!