Skip to content

Fix "Save as template" #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 11, 2020

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 8, 2020

What do these changes do?

  • Allow USERs to crud templates
  • Fix "Save as template" with organizations

@odeimaiz odeimaiz self-assigned this May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #1493 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1493      +/-   ##
==========================================
- Coverage   71.69%   71.66%   -0.04%     
==========================================
  Files         245      245              
  Lines        9804     9804              
  Branches     1076     1076              
==========================================
- Hits         7029     7026       -3     
- Misses       2469     2473       +4     
+ Partials      306      305       -1     
Flag Coverage Δ
#integrationtests 58.36% <100.00%> (ø)
#unittests 63.59% <100.00%> (-0.04%) ⬇️
Impacted Files Coverage Δ
...er/src/simcore_service_webserver/security_roles.py 100.00% <ø> (ø)
...re_service_webserver/projects/projects_handlers.py 87.78% <100.00%> (-0.46%) ⬇️
.../director/src/simcore_service_director/producer.py 65.90% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 618c5f3...ab4f5af. Read the comment docs.

@odeimaiz odeimaiz requested a review from sanderegg May 8, 2020 13:05
@odeimaiz odeimaiz requested review from pcrespov, ignapas, GitHK and mguidon May 8, 2020 14:07
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@odeimaiz odeimaiz merged commit 48d8102 into ITISFoundation:master May 11, 2020
@odeimaiz odeimaiz deleted the feature/fix-save-as-template branch May 11, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants