-
Notifications
You must be signed in to change notification settings - Fork 28
garbage collector system overhaul and extras #1724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GitHK
merged 68 commits into
ITISFoundation:master
from
GitHK:gc-remove-guests-with-no-projects
Sep 15, 2020
Merged
garbage collector system overhaul and extras #1724
GitHK
merged 68 commits into
ITISFoundation:master
from
GitHK:gc-remove-guests-with-no-projects
Sep 15, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1724 +/- ##
========================================
+ Coverage 70.2% 72.4% +2.1%
========================================
Files 305 306 +1
Lines 11778 11886 +108
Branches 1272 1285 +13
========================================
+ Hits 8274 8608 +334
+ Misses 3179 2928 -251
- Partials 325 350 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
requested changes
Aug 20, 2020
services/web/server/src/simcore_service_webserver/resource_manager/garbage_collector.py
Outdated
Show resolved
Hide resolved
5 tasks
Closed
- fixed a bug - added 2 tests
pcrespov
requested changes
Sep 10, 2020
sanderegg
reviewed
Sep 11, 2020
services/web/server/src/simcore_service_webserver/projects/projects_db.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/users_to_groups_api.py
Show resolved
Hide resolved
services/web/server/tests/integration/test_garbage_collection.py
Outdated
Show resolved
Hide resolved
sanderegg
reviewed
Sep 13, 2020
sanderegg
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pcrespov
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a:webserver
issue related to the webserver service
t:enhancement
Improvement or request on an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes overview
This is a massive overhaul of the Garbage Collector code, which was outdated.
Due to its complexity, comments on its internal workings were added in the garbage_collector.py module
What do these changes do?
Bonus changes:
-vvv
and-s
nvidia/cuda:10.0-base
container used by the sidecar is now removed after usageRelated issue number
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)