Skip to content

WIP: Maintenance/cleanup webserver test fixtures #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pcrespov
Copy link
Member

What do these changes do?

Review and cleanup of fixtures in webserver tests :

  • reduce redundancy (reuse helpers from pytest-simcore)
  • classify fixtures
  • share common fixtures

to fulfill needs of #1724: tests for garbage collector

  • a User with more then 2 projects
  • a user without projects
  • a user with just 1 project

The user can be:

  • connected via browser (websocket connection is up)
  • disconnected (no websocket connection)

Related issue number

follows from needs of #1724

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@pcrespov pcrespov changed the title Maintenance/cleanup webserver test fixtures WIP: Maintenance/cleanup webserver test fixtures Aug 21, 2020
@pcrespov pcrespov self-assigned this Aug 21, 2020
@pcrespov pcrespov added a:webserver issue related to the webserver service t:maintenance Some planned maintenance work labels Aug 21, 2020
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #1731 into master will decrease coverage by 1.9%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1731     +/-   ##
========================================
- Coverage    72.5%   70.6%   -2.0%     
========================================
  Files         279     279             
  Lines       11267   11267             
  Branches     1238    1238             
========================================
- Hits         8175    7960    -215     
- Misses       2756    2983    +227     
+ Partials      336     324     -12     
Flag Coverage Δ
#integrationtests 56.2% <ø> (-1.0%) ⬇️
#unittests 66.4% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/sidecar/src/simcore_service_sidecar/executor.py 23.9% <0.0%> (-59.4%) ⬇️
...rvices/sidecar/src/simcore_service_sidecar/core.py 26.7% <0.0%> (-47.7%) ⬇️
services/sidecar/src/simcore_service_sidecar/db.py 52.0% <0.0%> (-40.0%) ⬇️
...vices/sidecar/src/simcore_service_sidecar/utils.py 57.7% <0.0%> (-32.4%) ⬇️
...ervices/sidecar/src/simcore_service_sidecar/cli.py 48.4% <0.0%> (-18.2%) ⬇️
.../sidecar/src/simcore_service_sidecar/log_parser.py 73.8% <0.0%> (-13.9%) ⬇️
...es/sidecar/src/simcore_service_sidecar/rabbitmq.py 88.2% <0.0%> (-1.5%) ⬇️
.../director/src/simcore_service_director/producer.py 60.1% <0.0%> (-0.3%) ⬇️

@pcrespov pcrespov added this to the Da Jia milestone Aug 21, 2020
@pcrespov
Copy link
Member Author

Adds in #1741

@pcrespov pcrespov closed this Aug 25, 2020
@pcrespov pcrespov deleted the maintenance/cleanup-test-fixtures branch August 25, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant