Skip to content

Delayed diagnostics startup and maintenance upgrades #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Aug 26, 2020

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 24, 2020

What do these changes do?

  • upgrades package requirements
  • enable postgres-database CI testing
  • Fixes on new linter error: raise-missing-from and super-with-arguments
  • review and cleanup of fixtures in webserver tests :
    • reduce redundancy (reuse helpers from pytest-simcore)
    • classify fixtures
    • share common fixtures
  • enhance servicelib.logged_gathered and added testing
  • webserver delays activation of diagnosis. This will avoid restarting due to delays produced upon startup (default delay set to 1 min)

Related issue number

follows from needs of #1724

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #1741 into master will decrease coverage by 0.6%.
The diff coverage is 47.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1741     +/-   ##
========================================
- Coverage    72.5%   71.9%   -0.7%     
========================================
  Files         279     302     +23     
  Lines       11336   11691    +355     
  Branches     1249    1266     +17     
========================================
+ Hits         8225    8407    +182     
- Misses       2767    2942    +175     
+ Partials      344     342      -2     
Flag Coverage Δ
#integrationtests 57.0% <14.2%> (+<0.1%) ⬆️
#unittests 66.0% <45.0%> (-0.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/service-library/src/servicelib/monitoring.py 0.0% <ø> (ø)
...ckages/service-library/src/servicelib/resources.py 0.0% <0.0%> (ø)
...src/simcore_service_api_server/api/routes/users.py 48.0% <0.0%> (ø)
...imcore_service_api_server/services/remote_debug.py 50.0% <0.0%> (ø)
...src/simcore_service_catalog/api/routes/services.py 26.0% <0.0%> (ø)
...talog/src/simcore_service_catalog/core/settings.py 93.3% <0.0%> (ø)
...src/simcore_service_catalog/models/domain/group.py 100.0% <ø> (ø)
...c/simcore_service_catalog/services/remote_debug.py 37.5% <0.0%> (ø)
.../director/src/simcore_service_director/producer.py 60.1% <0.0%> (-0.3%) ⬇️
...rc/simcore_service_director/rest/node_validator.py 72.0% <0.0%> (ø)
... and 51 more

@pcrespov pcrespov changed the title WIP: Fixes/master e2e WIP: weekly maintenance Aug 26, 2020
@pcrespov pcrespov changed the title WIP: weekly maintenance weekly maintenance Aug 26, 2020
@pcrespov pcrespov marked this pull request as ready for review August 26, 2020 09:55
@pcrespov pcrespov requested a review from sanderegg August 26, 2020 09:58
@pcrespov pcrespov requested review from odeimaiz, sanderegg and mguidon and removed request for sanderegg and odeimaiz August 26, 2020 09:58
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please go in

@pcrespov pcrespov merged commit 39817ee into ITISFoundation:master Aug 26, 2020
@pcrespov pcrespov deleted the fixes/master-e2e branch August 26, 2020 21:26
@pcrespov pcrespov self-assigned this Aug 27, 2020
@pcrespov pcrespov changed the title weekly maintenance Delayed diagnostics startup and maintenance upgrades Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants