Skip to content

Frontend privileges. 2nd iteration #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 10, 2019

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 9, 2019

What do these changes do?

  • Hide nodeId from NodesTree to User and Anonymous
  • Hide Debug Level from Logger to User and Anonymous
  • Tester, Moderator and Admin are able to lower their role from the Profile Settings. Very cool.

Bonus:

  • Typo in UX_improvemnts
  • Help action points to itisfoundation.github.io

permissions

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

@odeimaiz odeimaiz requested a review from pcrespov May 9, 2019 15:21
@ghost
Copy link

ghost commented May 9, 2019

DeepCode analyzed this pull request.
There are no new issues. 1 info report was fixed.

Click to see more details.

@odeimaiz odeimaiz requested review from ignapas and oetiker May 9, 2019 15:21
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loving it ... :-)

@codecov-io
Copy link

codecov-io commented May 9, 2019

Codecov Report

Merging #753 into master will increase coverage by 2.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #753      +/-   ##
=========================================
+ Coverage   65.24%   67.9%   +2.65%     
=========================================
  Files         120      66      -54     
  Lines        4785    2371    -2414     
=========================================
- Hits         3122    1610    -1512     
+ Misses       1663     761     -902
Impacted Files Coverage Δ
...r/rest/generated_code/models/inline_response201.py
.../rest/generated_code/models/inline_response2001.py
...ctor/src/simcore_service_director/rest/handlers.py
...storage/src/simcore_service_storage/rest_config.py
...s/storage/src/simcore_service_storage/db_tokens.py
...orage/src/simcore_service_storage/config_schema.py
api/tests/conftest.py
...r/rest/generated_code/models/inline_response200.py
...rc/simcore_service_director/rest/node_validator.py
...ices/director/src/simcore_service_director/main.py
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c704a...ba553da. Read the comment docs.

@odeimaiz odeimaiz merged commit cfc73c1 into ITISFoundation:master May 10, 2019
@odeimaiz odeimaiz deleted the feature/hide-uuids-to-user branch May 21, 2019 09:37
sanderegg added a commit that referenced this pull request May 22, 2019
* Delete settings.json

* Fixes for alpha tester (#748)

* fake-template-projects.json created. 2 templates moved here
* Kember use case added
* MattWard use case added
* 4x CC 0D added
* Provide a way to refetch data from DataManager
* connect the kember-model to the kember-viewer
* moved null handler to node_ports package
* set node ports log level to same as sidecar
* removed Unused import logging
* New issue: add UX_improvemnts label and asign it to oSPARC Product Backlog project

* Permission policies (#731)

* LinkButton and LinkLabel moved
* Project -> Study
* default hardcoded permissions added
* Added some restrictions
* Link -> Edge
* Moved permission checks to data level
* Set Default Role
* more permission checks
* token permission checks
* datcore read permission check
* study.node.data.* permission check
* study.node.rename permission check
* services.filtered.read permission check
* fixed plotly minor bug
* Test permissions
* Moved some removeNode code to Workbench
* Moved removeEdge code to Workbench
* test edge create/delete
* test node rename
* deserializeNodes and deserializeEdges added
* deserializeEdges fixed for 'outputNode's
* got rid of canStart
* Typo: presgined -> presigned
* do not allow anonymous users to add/delete tokens
* do not allow anonymous users to update user profile

* Frontend privileges. 2nd iteration (#753)

* help points to our itisfoundation.github.io
* typo
* Do not show Debug level in logger to User and Anon
* Do not show nodeIds in NodesTree to User and Anon
* Tester and higher level roles can switch their role to a lower one

* Is730/serve studies (#747)

Implements a first prototype for issue #730 

Adds new subsystem ``services/web/server/src/simcore_service_webserver/studies_access.py``
 - Open services/web/server/tests/sandbox/*.md and click any link
 - If user is logged in, it copies the project and displays it
 - if anonymous, it creates a temporary user and does the previous step
 - Merges changes from PR #734 that contains the UI part.
   - queries id in url and opens page with specified study
   - fixes log out
   - preview of permissions (client-side only)

Next step will incorporate privileges and user roles on the server side.

* Quick fixes (#742)

A couple of iframe bugs fixed:

Maximizing an iframe now works.
We can now resize a SidePanel over an iframe
Other bugs:

File picker bug fixed. #741

* Update study_access_demo.md

Added link to actual emulator [skip travis-ci]

* Logger context dependant (#754)

* replace label by nodeId in logger
* Bring back the update page alert window
* added link to version/commit to login page
* startInteractiveNode out from populateNodeData
* Log message changes when label is changed
* Logger node context dependant

* Is234/compile requirements (#733)

Implements #234 : normalizes dependencies for python packages in osparc-simcore repository

- documented (see ``docs/python-dependencies.md``) new workflow with python requirements
- updates ``packages`` and ``services`` 
- updates ``ops\travis`` CI
   - moves out a part of unittest ``simcore-sdk`` into a new unit-test for ``service-library``
   - installation is always performed as ``pip install -r requirements/ci.txt ``
   -  @mguidon,  sidecar as NO tests (created ``ops\tracis`` but disabled)!

* Fixed makefile for all OS
* Fixing storage tests:
 - downgraded aiopg until bug is fixed
* Fixes overlapping port
* Enhaces doc
* Downgraded aio-pika
 - avoid test-errors in webserver integration!
 - cleanup

* Fix input node's title (#771)

* fix #770

* Improve CI/CD for simcore and add staging/production stages (#738)

build docker images once and push to dockerhub
pull from dockerhub for testing
implement release workflow

* Is788/allow different stack name (#789)

* director/sidecar independant of stack name using SWARM_STACK_NAME
* allow choosing port where simcore platform is available

* fixed link to image

* Maintenance/update requirements (#792)

* Upstead api/tests requirements
* Updates travis system-testing requirements
* Updated s3wrapper requirements
* update servicelib requirements
* Updates simcore-sdk requirements and with this all packages requirements
* Updates apihub/tests requirements
* Fixes missing ops/travis requirements
* Updates director
* Updates sidecar
* updated storage

* Fix: 2 file management bugs (#782)

* getLowerRoles fixed
* CopyFile returns true/false if request sent + test
* DeleteFile returns true/false if request sent + test
* getChildrenRoles by checking inheritance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants