Is788/allow different stack name #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidecar/director need to access docker volume/network that are defined by that name
mguidon
requested changes
May 17, 2019
ignapas
approved these changes
May 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #789 +/- ##
==========================================
- Coverage 70.15% 60.99% -9.17%
==========================================
Files 121 92 -29
Lines 4936 3694 -1242
==========================================
- Hits 3463 2253 -1210
+ Misses 1473 1441 -32
Continue to review full report at Codecov.
|
sanderegg
added a commit
that referenced
this pull request
May 22, 2019
* Delete settings.json * Fixes for alpha tester (#748) * fake-template-projects.json created. 2 templates moved here * Kember use case added * MattWard use case added * 4x CC 0D added * Provide a way to refetch data from DataManager * connect the kember-model to the kember-viewer * moved null handler to node_ports package * set node ports log level to same as sidecar * removed Unused import logging * New issue: add UX_improvemnts label and asign it to oSPARC Product Backlog project * Permission policies (#731) * LinkButton and LinkLabel moved * Project -> Study * default hardcoded permissions added * Added some restrictions * Link -> Edge * Moved permission checks to data level * Set Default Role * more permission checks * token permission checks * datcore read permission check * study.node.data.* permission check * study.node.rename permission check * services.filtered.read permission check * fixed plotly minor bug * Test permissions * Moved some removeNode code to Workbench * Moved removeEdge code to Workbench * test edge create/delete * test node rename * deserializeNodes and deserializeEdges added * deserializeEdges fixed for 'outputNode's * got rid of canStart * Typo: presgined -> presigned * do not allow anonymous users to add/delete tokens * do not allow anonymous users to update user profile * Frontend privileges. 2nd iteration (#753) * help points to our itisfoundation.github.io * typo * Do not show Debug level in logger to User and Anon * Do not show nodeIds in NodesTree to User and Anon * Tester and higher level roles can switch their role to a lower one * Is730/serve studies (#747) Implements a first prototype for issue #730 Adds new subsystem ``services/web/server/src/simcore_service_webserver/studies_access.py`` - Open services/web/server/tests/sandbox/*.md and click any link - If user is logged in, it copies the project and displays it - if anonymous, it creates a temporary user and does the previous step - Merges changes from PR #734 that contains the UI part. - queries id in url and opens page with specified study - fixes log out - preview of permissions (client-side only) Next step will incorporate privileges and user roles on the server side. * Quick fixes (#742) A couple of iframe bugs fixed: Maximizing an iframe now works. We can now resize a SidePanel over an iframe Other bugs: File picker bug fixed. #741 * Update study_access_demo.md Added link to actual emulator [skip travis-ci] * Logger context dependant (#754) * replace label by nodeId in logger * Bring back the update page alert window * added link to version/commit to login page * startInteractiveNode out from populateNodeData * Log message changes when label is changed * Logger node context dependant * Is234/compile requirements (#733) Implements #234 : normalizes dependencies for python packages in osparc-simcore repository - documented (see ``docs/python-dependencies.md``) new workflow with python requirements - updates ``packages`` and ``services`` - updates ``ops\travis`` CI - moves out a part of unittest ``simcore-sdk`` into a new unit-test for ``service-library`` - installation is always performed as ``pip install -r requirements/ci.txt `` - @mguidon, sidecar as NO tests (created ``ops\tracis`` but disabled)! * Fixed makefile for all OS * Fixing storage tests: - downgraded aiopg until bug is fixed * Fixes overlapping port * Enhaces doc * Downgraded aio-pika - avoid test-errors in webserver integration! - cleanup * Fix input node's title (#771) * fix #770 * Improve CI/CD for simcore and add staging/production stages (#738) build docker images once and push to dockerhub pull from dockerhub for testing implement release workflow * Is788/allow different stack name (#789) * director/sidecar independant of stack name using SWARM_STACK_NAME * allow choosing port where simcore platform is available * fixed link to image * Maintenance/update requirements (#792) * Upstead api/tests requirements * Updates travis system-testing requirements * Updated s3wrapper requirements * update servicelib requirements * Updates simcore-sdk requirements and with this all packages requirements * Updates apihub/tests requirements * Fixes missing ops/travis requirements * Updates director * Updates sidecar * updated storage * Fix: 2 file management bugs (#782) * getLowerRoles fixed * CopyFile returns true/false if request sent + test * DeleteFile returns true/false if request sent + test * getChildrenRoles by checking inheritance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Bonus:
This allows the director and sidecar to find the corresponding docker network and docker volume respectively.
Related issue number
fixes #788
Checklist