Fix input node's title #771

odeimaiz · 2019-05-14T11:01:18Z

What do these changes do?

Fixes the bug related to the node label in the NodePorts

Related issue number

closes #770

Checklist

I think the code is well written
Unit tests for the changes exist
Documentation reflects the changes
Runs in the swarm
If you design a new module, add your user to .github/CODEOWNERS

Feature/permission policies

…icies Revert "Feature/permission policies"

ignapas

hehe oupsie. thanks!

codecov-io · 2019-05-14T11:33:39Z

Codecov Report

Merging #771 into master will increase coverage by 1.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
+ Coverage   64.64%   66.61%   +1.96%     
==========================================
  Files         121       67      -54     
  Lines        4936     2516    -2420     
==========================================
- Hits         3191     1676    -1515     
+ Misses       1745      840     -905

Impacted Files	Coverage Δ
...r/rest/generated_code/models/inline_response201.py
.../rest/generated_code/models/inline_response2001.py
...ctor/src/simcore_service_director/rest/handlers.py
...storage/src/simcore_service_storage/rest_config.py
...s/storage/src/simcore_service_storage/db_tokens.py
...orage/src/simcore_service_storage/config_schema.py
api/tests/conftest.py
...r/rest/generated_code/models/inline_response200.py
...rc/simcore_service_director/rest/node_validator.py
...ices/director/src/simcore_service_director/main.py
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c746e...d1843f3. Read the comment docs.

oetiker · 2019-05-14T11:58:53Z

services/web/client/source/class/qxapp/component/widget/NodePorts.js


    const nodeUIPorts = this.__nodeUIPorts = new qx.ui.container.Composite(new qx.ui.layout.VBox()).set({
      appearance: "node-ports"
    });

-    this.setIsInputModel(isInputModel);
-    this.setNode(node);
+    this.base(arguments, node.getLabel(), nodeUIPorts);


calling the super class 'in the middle' indicates quite a lot of knowledge about the way the superclass constructoir is implemented :) is this necessary?

I wouldn't say it is necessary, I did it to test the reusability of the PanelView, and it worked first go so we left it like that. The superclass constructor is our code, so we really know how it's implemented. There is probably room for a small refactor here, but this is out of the scope of this PR, I think.

@mguidon

* Delete settings.json * Fixes for alpha tester (#748) * fake-template-projects.json created. 2 templates moved here * Kember use case added * MattWard use case added * 4x CC 0D added * Provide a way to refetch data from DataManager * connect the kember-model to the kember-viewer * moved null handler to node_ports package * set node ports log level to same as sidecar * removed Unused import logging * New issue: add UX_improvemnts label and asign it to oSPARC Product Backlog project * Permission policies (#731) * LinkButton and LinkLabel moved * Project -> Study * default hardcoded permissions added * Added some restrictions * Link -> Edge * Moved permission checks to data level * Set Default Role * more permission checks * token permission checks * datcore read permission check * study.node.data.* permission check * study.node.rename permission check * services.filtered.read permission check * fixed plotly minor bug * Test permissions * Moved some removeNode code to Workbench * Moved removeEdge code to Workbench * test edge create/delete * test node rename * deserializeNodes and deserializeEdges added * deserializeEdges fixed for 'outputNode's * got rid of canStart * Typo: presgined -> presigned * do not allow anonymous users to add/delete tokens * do not allow anonymous users to update user profile * Frontend privileges. 2nd iteration (#753) * help points to our itisfoundation.github.io * typo * Do not show Debug level in logger to User and Anon * Do not show nodeIds in NodesTree to User and Anon * Tester and higher level roles can switch their role to a lower one * Is730/serve studies (#747) Implements a first prototype for issue #730 Adds new subsystem ``services/web/server/src/simcore_service_webserver/studies_access.py`` - Open services/web/server/tests/sandbox/*.md and click any link - If user is logged in, it copies the project and displays it - if anonymous, it creates a temporary user and does the previous step - Merges changes from PR #734 that contains the UI part. - queries id in url and opens page with specified study - fixes log out - preview of permissions (client-side only) Next step will incorporate privileges and user roles on the server side. * Quick fixes (#742) A couple of iframe bugs fixed: Maximizing an iframe now works. We can now resize a SidePanel over an iframe Other bugs: File picker bug fixed. #741 * Update study_access_demo.md Added link to actual emulator [skip travis-ci] * Logger context dependant (#754) * replace label by nodeId in logger * Bring back the update page alert window * added link to version/commit to login page * startInteractiveNode out from populateNodeData * Log message changes when label is changed * Logger node context dependant * Is234/compile requirements (#733) Implements #234 : normalizes dependencies for python packages in osparc-simcore repository - documented (see ``docs/python-dependencies.md``) new workflow with python requirements - updates ``packages`` and ``services`` - updates ``ops\travis`` CI - moves out a part of unittest ``simcore-sdk`` into a new unit-test for ``service-library`` - installation is always performed as ``pip install -r requirements/ci.txt `` - @mguidon, sidecar as NO tests (created ``ops\tracis`` but disabled)! * Fixed makefile for all OS * Fixing storage tests: - downgraded aiopg until bug is fixed * Fixes overlapping port * Enhaces doc * Downgraded aio-pika - avoid test-errors in webserver integration! - cleanup * Fix input node's title (#771) * fix #770 * Improve CI/CD for simcore and add staging/production stages (#738) build docker images once and push to dockerhub pull from dockerhub for testing implement release workflow * Is788/allow different stack name (#789) * director/sidecar independant of stack name using SWARM_STACK_NAME * allow choosing port where simcore platform is available * fixed link to image * Maintenance/update requirements (#792) * Upstead api/tests requirements * Updates travis system-testing requirements * Updated s3wrapper requirements * update servicelib requirements * Updates simcore-sdk requirements and with this all packages requirements * Updates apihub/tests requirements * Fixes missing ops/travis requirements * Updates director * Updates sidecar * updated storage * Fix: 2 file management bugs (#782) * getLowerRoles fixed * CopyFile returns true/false if request sent + test * DeleteFile returns true/false if request sent + test * getChildrenRoles by checking inheritance

odeimaiz and others added 15 commits April 25, 2019 11:46

default hardcoded permissions added

8e26fe9

Added some restrictions

32ee5e9

minor

bbd3a1b

Merge branch 'master' into feature/permission-policies

828af9f

Moved permission checks to data level

5e2f8a5

Merge pull request #35 from odeimaiz/feature/permission-policies

e327ab7

Feature/permission policies

Revert "Feature/permission policies"

1a39d59

Merge pull request #36 from odeimaiz/revert-35-feature/permission-pol…

c05110f

…icies Revert "Feature/permission policies"

Merge remote-tracking branch 'upstream/master'

0c1128d

Merge remote-tracking branch 'upstream/master'

e1858a3

Merge remote-tracking branch 'upstream/master'

52a35d6

Merge remote-tracking branch 'upstream/master'

56ae9d1

Merge remote-tracking branch 'upstream/master'

3980276

Merge remote-tracking branch 'upstream/master'

4a39b8e

fix ITISFoundation#770

011cf17

odeimaiz requested review from ignapas, oetiker, pcrespov and sanderegg May 14, 2019 11:01

odeimaiz changed the title ~~Fix/input node label~~ Fix input node's title May 14, 2019

ignapas approved these changes May 14, 2019

View reviewed changes

pcrespov approved these changes May 14, 2019

View reviewed changes

oetiker reviewed May 14, 2019

View reviewed changes

oetiker approved these changes May 14, 2019

View reviewed changes

odeimaiz added 2 commits May 14, 2019 14:06

Merge branch 'master' into fix/input-node-label

419b772

Merge branch 'master' into fix/input-node-label

d1843f3

odeimaiz merged commit f60c460 into ITISFoundation:master May 14, 2019

odeimaiz deleted the fix/input-node-label branch May 21, 2019 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix input node's title #771

Fix input node's title #771

odeimaiz commented May 14, 2019

ignapas left a comment

codecov-io commented May 14, 2019 •

edited

Loading

oetiker May 14, 2019

ignapas May 14, 2019 •

edited

Loading

Fix input node's title #771

Fix input node's title #771

Conversation

odeimaiz commented May 14, 2019

What do these changes do?

Related issue number

Checklist

ignapas left a comment

Choose a reason for hiding this comment

codecov-io commented May 14, 2019 • edited Loading

Codecov Report

oetiker May 14, 2019

Choose a reason for hiding this comment

ignapas May 14, 2019 • edited Loading

Choose a reason for hiding this comment

codecov-io commented May 14, 2019 •

edited

Loading

ignapas May 14, 2019 •

edited

Loading