-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Feature: Fail setup more gracefully for branch protections on private, non-Pro repos #401
Closed
3 tasks done
Labels
status: accepting prs
Please, send a pull request to resolve this!
type: feature
New enhancement or request
Comments
2 tasks
On it |
JoshuaKGoldberg
pushed a commit
that referenced
this issue
May 12, 2023
<!-- 👋 Hi, thanks for sending a PR to template-typescript-node-package! 💖. Please fill out all fields below and make sure each item is true and [x] checked. Otherwise we may not be able to review your PR. --> ## PR Checklist - [x] Addresses an existing open issue: fixes #401 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Fail gracefully for branch protection settings for private repos (non-Pro). - Added `warnText` field to the "withSpinner" options - `withSpinner` will now store its callback return value, and will show `warnText` in case the value is `false` Bonus: I changed all the `catch (err)` to `catch (error)` just for consistency (git blame on me) I'm honestly not so excited about this solution, but submitting it anyway to hear your thoughts
🎉 This is included in version v1.27.80 🎉 The release is available on: Cheers! 📦🚀 |
1 similar comment
🎉 This is included in version v1.27.80 🎉 The release is available on: Cheers! 📦🚀 |
This was referenced May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: accepting prs
Please, send a pull request to resolve this!
type: feature
New enhancement or request
Bug Report Checklist
main
branch of the repository.Overview
Forking from #398: apparently you must have GitHub Pro to set branch protections on a private repo. TIL. Right now the setup script fails with:
...so much noise! And there's really no need to cancel the rest of setup & mark the whole thing as failed.
Instead, let's mention the error and continue gracefully. How about something like...
(that's just a starting suggestion I haven't put much thought into - please improve it if you have any ideas!)
Additional Info
To get this complaint:
pnpm install
pnpm run setup
The text was updated successfully, but these errors were encountered: