Skip to content

removed the use of apt-spy2 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eringerli
Copy link
Contributor

@eringerli eringerli commented Apr 30, 2022

I'm honest, I have no idea what apt-spy2 does, a quick recherche says something about keeping the /etc/sources.list current and the log shows a lot of mirrors which aparently get tested. Shouldn't that be the responsibility of github by having quick download mirrors already configured in their images? Also even using the slowest mirror is faster than the two minutes this test takes.

Here are two runs: This commit lowers the runtime of pre-install from 2:31 minutes to 17 seconds, which is 888% faster.
Screenshot_20220429_085028
Screenshot_20220430_185038

@eringerli eringerli changed the title removed the ue of apt-spy2 removed the use of apt-spy2 Apr 30, 2022
I cannot see, what good the testing the mirrors every single time does. So
I removed it. This saves more than a minute execution time with no apparent
down side.
@ladyada
Copy link
Member

ladyada commented May 1, 2022

we had a lot of failures before we searched each time.

@ladyada ladyada closed this May 1, 2022
@eringerli
Copy link
Contributor Author

It seems to be solved: actions/runner-images#675. The workaround is to call apt-get update before installing stuff and collect all installing into one call to apt-get install.

@eringerli
Copy link
Contributor Author

eringerli commented May 1, 2022

I ran a stresstest by letting it run 50 times without apt-spy2, it worked flawlessly: https://github.com/eringerli/Adafruit_LSM6DS/actions
I also deactivated the compilation test, as the problem would be in actions_install.sh/Install the prerequisites and I don't want to use up my execution time.

I used the code

for i in {0..50}; do 
  git commit --amend -m "github actions test for eringerli/ci-arduino #$i"; 
  git push --set-upstream origin github-actions-test --force; 
done

to create a lot of commits and trigger the action runs in quick succesion. This should let them run on different hosts, so if something would go wrong, it does.

@ladyada
Copy link
Member

ladyada commented May 2, 2022

its not an issue now but for a few days a couple months ago actions had a bad default apt mirror - really this was the best solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants