Only install clang-format if it is really missing #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the default image already has v10, v11 (default) and v12 installed, you don't have to install v8 and don't even use it. This removes the need for a long (most of the time 2 minutes) mirror search or even call 'apt-get install' in the first place. This shortens the time spent in actions_install.sh from about 2:30min to 6s, which is 25x faster.
eringerli
force-pushed
the
remove-unneded-apg-get-install
branch
from
f9fea72 to
a4b6ff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the default image already has v10, v11 (default) and v12 installed, you don't have to install v8 and don't even use it. This removes the need for a long (most of the time 2 minutes) mirror search or even call
apt-get installin the first place. This shortens the time spent inactions_install.shfrom about 2:30min to 6s, which is 25x faster.This is similar to PR #135, but wraps it in a conditional: if the search for
/usr/bin/clang-formatfails, install it. This should be fully backwards compatible.This is the output of
clang-format --versionwith this change:This as it was before:
There is no difference, as both times the defaut
clang-formatgets used.