reordered the actions, so clang-format and doxygen are run first #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
requested changes
May 1, 2022
eringerli
force-pushed
the
actions-reorder
branch
3 times, most recently
from
0f591f8 to
2c9772c
Compare
|
According to this: actions/runner-images#675 (comment), all calls to |
|
I set prettier names for the individual steps |
This change reorders the actions so the least expensive and most failing actions are run first. On a typical run, doxygen and clang-format take each about 2s (plus 7s install), the complete building on all the supported platforms 10 minutes. In my experience, the most fails I get are from formatting and documentation errors, not from compilation problems. This gives the users a much faster feedback on needed changes in their commits and PRs and shaves off a lot of execution time.
|
I moved the changes in Here is a small snippet to batch patch, commit and push to github for many repos: for repo in repo1 repo2; do
pushd "$repo"
curl https://patch-diff.githubusercontent.com/raw/adafruit/ci-arduino/pull/134.patch | patch -p2 -u -F 10 --merge .github/workflows/githubci.yml
git add .github/workflows/githubci.yml
git commit -m "updated github workflow"
git push origin
popd
done |
ladyada
approved these changes
May 2, 2022
|
thanks! |
This was referenced May 2, 2022
eringerli
added a commit
to eringerli/Adafruit_RA8875
that referenced
this pull request
Jun 5, 2022
eringerli
added a commit
to eringerli/Adafruit_RA8875
that referenced
this pull request
Jun 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reorders the actions so the least expensive and most failing actions are run first. On a typical run, doxygen and clang-format take each about 2s, the complete building on all the supported platforms 10 minutes. In my experience, the most fails I get are from formatting and documentation errors, not from compilation problems. This gives the users a much faster feedback on needed changes in their commits and PRs and shaves off a lot of execution time.
If you also consider accepting PR #135, this gives the user feedback on formatting and documentation in under 30s, compared to before after 13 minutes.
