Skip to content

feat: enable runscript for CoreService #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 14, 2025
Merged

Conversation

jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Mar 12, 2025

Description

run_discovery_script_file() is now available on CoreService backend. Includes .py, .scscript, and .dscript - along with smart variable support.

Issue linked

#1155

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb self-assigned this Mar 12, 2025
@jonahrb jonahrb requested a review from a team as a code owner March 12, 2025 14:59
@jonahrb
Copy link
Contributor Author

jonahrb commented Mar 12, 2025

waiting on new ApiServer image

@jonahrb jonahrb changed the title feat: enable runscript for CoreService backend feat: enable runscript for CoreService Mar 12, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Mar 12, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can't wait!

@RobPasMue RobPasMue changed the base branch from main to blitz March 12, 2025 15:04
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.51%. Comparing base (6339ea8) to head (59fa8f2).
Report is 1 commits behind head on blitz.

Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1821      +/-   ##
==========================================
+ Coverage   90.31%   90.51%   +0.19%     
==========================================
  Files          92       92              
  Lines        8727     8727              
==========================================
+ Hits         7882     7899      +17     
+ Misses        845      828      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonahrb jonahrb merged commit 04ffd1b into blitz Mar 14, 2025
24 of 25 checks passed
@jonahrb jonahrb deleted the feat/run-script-core-service branch March 14, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants