Skip to content

Python 3.9 mypy failures #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnttompkins opened this issue Nov 13, 2020 · 2 comments · Fixed by #206
Closed

Python 3.9 mypy failures #139

johnttompkins opened this issue Nov 13, 2020 · 2 comments · Fixed by #206
Assignees
@kddejong
Labels
enhancement New feature or request

Comments

@johnttompkins
Copy link
Contributor

Following errors are thrown from MyPI when checking the support lib on python 3.9. To get this functional for 3.9 need to address:

mypy.....................................................................Failed
- hook id: mypy
- exit code: 2

src/cloudformation_cli_python_lib/interface.py:12: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:61: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:75: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:80: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:81: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:90: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:92: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:94: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:95: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:96: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:98: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:122: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:131: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:132: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:133: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:134: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:135: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:136: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:137: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:138: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:139: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:140: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:141: error: syntax error in type comment
src/cloudformation_cli_python_lib/interface.py:142: error: syntax error in type comment
@johnttompkins johnttompkins changed the title Python 3.9 MyPI Python 3.9 MyPI Failures Nov 13, 2020
@johnttompkins johnttompkins added bug Something isn't working enhancement New feature or request labels Nov 13, 2020
@PatMyron
Copy link
Contributor

PatMyron commented Nov 30, 2020 •
edited
Loading

maybe related to python/mypy#8614?
we need to update this at least:

cloudformation-cli-python-plugin/.pre-commit-config.yaml

Lines 51 to 52 in ae8533f

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.711

@johnttompkins johnttompkins removed the bug Something isn't working label Nov 30, 2020
@PatMyron PatMyron mentioned this issue Dec 7, 2020
Merged
@PatMyron PatMyron changed the title Python 3.9 MyPI Failures Python 3.9 mypy failures Dec 7, 2020
PatMyron added a commit that referenced this issue Dec 7, 2020
@PatMyron
testing Python 3.9
6cedb1d 
fixes #139
python/mypy#8614
https://github.com/python/mypy/releases
https://github.com/pre-commit/mirrors-mypy/releases
@PatMyron PatMyron mentioned this issue Dec 7, 2020
Closed
This was referenced Dec 22, 2020
Merged
Merged
PatMyron added a commit that referenced this issue Mar 24, 2021
@PatMyron
testing Python 3.9
3fc09d6 
fixes #139
python/mypy#8614
https://github.com/python/mypy/releases
https://github.com/pre-commit/mirrors-mypy/releases
@mmaeng mmaeng linked a pull request Nov 1, 2022 that will close this issue
chore(tests): Update precommit config yaml file to newest versions #206
Merged
@mmaeng
Copy link
Contributor

mmaeng commented Nov 1, 2022

#206 looks to resolve the mypy errors on Python 3.9 and 3.10

@mmaeng mmaeng closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kddejong kddejong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@PatMyron @kddejong @johnttompkins @mmaeng