-
Notifications
You must be signed in to change notification settings - Fork 167
Move CI from TravisCI to GitHub Actions #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CI from TravisCI to GitHub Actions #654
Conversation
ae2d417
to
f4c734a
Compare
f4c734a
to
29fc8db
Compare
Can we remove |
Removed it in the last commit. Checks will show as incomplete since we require a travis success in the repo settings and there isn't one in this PR now. Will remove requirement once this is approved. |
AWS_DEFAULT_REGION: us-east-1 | ||
strategy: | ||
matrix: | ||
python: [3.6, 3.7, 3.8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably currently stuck on pylint
support like the plugin, but we should eventually run this for Python 3.9 as well:
python: [3.6, 3.7, 3.8] | |
python: [3.6, 3.7, 3.8, 3.9] |
Co-authored-by: Pat Myron <[email protected]>
env: | ||
AWS_DEFAULT_REGION: us-east-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this environment variable used for anything btw?
env: | |
AWS_DEFAULT_REGION: us-east-1 |
* Add GitHub actions equivalent CI * Remove travis spec to show parity Co-authored-by: Pat Myron <[email protected]>
* Add GitHub actions equivalent CI * Remove travis spec to show parity Co-authored-by: Pat Myron <[email protected]>
* Add GitHub actions equivalent CI * Remove travis spec to show parity Co-authored-by: Pat Myron <[email protected]>
* Add GitHub actions equivalent CI * Remove travis spec to show parity Co-authored-by: Pat Myron <[email protected]>
Issue #, if available:
Description of changes: Adds CI job that achieves parity with the current travis PR run (runs pre-commit). The other file also handles releasing to PyPI. There is a scoped token that we have uploaded as a github secret that we can use to publish to our PyPI repo. Tested on my repo with a test token and test repository:
Very similar to aws-cloudformation/cloudformation-cli-python-plugin#138
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.