Move CI from TravisCI to GitHub Actions #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnttompkins
changed the title
PatMyron
reviewed
Nov 12, 2020
johnttompkins
force-pushed
the
jotompki-patch-1
branch
from
0a97ecd to
fa69080
Compare
|
Python 3.9 fails with these errors from MyPI: Going to remove and file an issue to address whenever we want to support python3.9 |
ammokhov
approved these changes
Nov 16, 2020
| build: | ||
| env: | ||
| AWS_DEFAULT_REGION: us-east-1 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
curious if we should use centos?
There was a problem hiding this comment.
@ammokhov don't think that's an option yet for GitHub Actions' hosted runners:
https://github.com/actions/virtual-environments#available-environments
https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-runners-and-hardware-resources
https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idruns-on
There was a problem hiding this comment.
we should test on macos-latest and windows-latest as well though
PatMyron
reviewed
Nov 20, 2020
PatMyron
approved these changes
Nov 20, 2020
Co-authored-by: Pat Myron <[email protected]>
PatMyron
reviewed
Dec 23, 2020
Comment on lines
+14
to
+15
| env: | ||
| AWS_DEFAULT_REGION: us-east-1 |
There was a problem hiding this comment.
Is this environment variable used for anything btw?
Suggested change
| env: | |
| AWS_DEFAULT_REGION: us-east-1 |
|
Could get rid of the Travis badge: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to slowly migrate away from travis CI. testing this as a proof of concept to see how portable our workflows are. Going to keep travisCI until we are confident in this and can port the release workflow as well.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.