Continue Lambda type annotations #1782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1767) Based on discussion in cucumber/cucumber-eclipse#373 ticket, added a brief note under 4.5.0 release.
With the introduction of JPMS modules need to declare their dependencies. Additionally they need to declare which transitive modules their consumers have to depend on via require transitive. To keep this structure simple we should remove the need to end users to depend on `cucumber-core`. Closes #1760
* Fix typo in vis.min.js. Use long (millis since epoch) instead of Instant, which results in a JSON representation that the formatter cannot handle. * Upgrade to jQuery 3.4.1. Fixes #1759. * Upgrade to chosen 1.8.7 * Deprecate timeline formatter * Remove deprecation warning
* Detect JavaDoc errors * Fix JavaDoc errors * Removed unused properties
JUnit 5 tests and test classes can be package private. The public modifier simply adds nothing but ceremony. Cleaning this up will remove a large number of inspection warnings.
Replace internal utility class with lambda.
Snippet is an interface and defined as part of the backend.
All glue definition classes implemented a `getLocation(boolean detail)` method. This would provide a long form method description. However in practice this method was always invoked with true. Removing the parameter cleans up the API. This also revealed that `Invoker` is only used for the `timeout` in `cucumber-java8`. This means that class can be moved to `cucumber-java` and with that `MethodFormat` can also be moved to `cucumber-java`.
## Summary With the introduction of v5 we will break the plugin API by moving packages from `cucumber.core` to `io.cucumber.core`. We can use this as an opportunity to extract the plugin and event classes to separate modules. This change moves `io.cucumber.core.plugin` to `io.cucumber.plugin` and `io.cucumber.core.event` to `io.cucumber.plugin.event`. While on its own this change provides little value it will allow us in the future to provide better support for plugins. With the introduction of JPMS we will want to expose these classes for plugin developers. However we also want to avoid the use of core by most end users. By moving these classes to their own modules we can avoid the use of core and future proof the introduction of JPMS. Closes #1773.
Cucumber JUnits xml format doesn't pass XSD validation in the Jenkins XUnit plugin because it is missing the errors attribute. Additionally time should be presented using numbers with both decimal and thousands separators. From: https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report-3.0.xsd Via: https://maven.apache.org/surefire/maven-surefire-plugin/ Closes #1777
Introduces the backend module. With this module backend implementations only need to use dependencies from `io.cucumber.core.backend`. This will allow us to introduce the module system later on The implementation is not yet perfect. Classpath scanning and resource loading is located in other modules. Removing this depends on #1526 and removal of type registry configurer which depends on #1768 . Fixes #1386 because steps can now see if an exception came from user code or actual backend. Removes timeout which would close #1695 earlier then expected.
Prints code, name, and native name of supported languages in a three column list. ``` af Afrikaans Afrikaans am Armenian հայերեն ar Arabic العربية ast Asturian asturianu az Azerbaijani Azərbaycanca ...
lambda-type-annotations Conflicts: java8/src/main/java/io/cucumber/java8/Java8Backend.java java8/src/main/java/io/cucumber/java8/LambdaGlue.java java8/src/test/java/io/cucumber/java8/Java8LambdaStepDefinitionMarksCorrectStackElementTest.java java8/src/test/java/io/cucumber/java8/LambdaGlueTest.java
timtebeek
commented
Sep 27, 2019
java8/src/main/java/io/cucumber/java8/Java8ParameterTypeDefinition.java
Outdated
Show resolved
Hide resolved
added 5 commits
September 27, 2019 21:07
added 11 commits
September 27, 2019 21:53
14 tasks
|
Cheers merged it into the other one. This was pretty clean! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1768; kept separately for easier review flow. Fixes #1764