Skip to content

xp.linalg.vecdot should have axis=-1 default #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oleksandr-pavlyk opened this issue May 3, 2024 · 1 comment · Fixed by #880
Closed

xp.linalg.vecdot should have axis=-1 default #804

oleksandr-pavlyk opened this issue May 3, 2024 · 1 comment · Fixed by #880
Labels
Backport Changes involve backporting to previous versions. bug Something isn't working.
Milestone
v2024

Comments

@oleksandr-pavlyk
Copy link
Contributor

xp.linalg.vecdot is documented as alias to xp.vecdot.

However, xp.linalg.vecdot signature uses axis=None default, while xp.vecdot has axis=-1 as the default.

image

image

They should be consistent.
@kgryte
Copy link
Contributor

kgryte commented May 3, 2024

Hmmm...this should have been fixed already: #355. The regression happened during cbbab62. I can work on a fix and backport.

@kgryte kgryte added bug Something isn't working. Backport Changes involve backporting to previous versions. labels May 3, 2024
@kgryte kgryte added this to the v2024 milestone May 3, 2024
kgryte added a commit to kgryte/array-api that referenced this issue Jan 9, 2025
@kgryte
fix: address default value regression for axis kwarg in vecdot
d610848 
Closes: data-apis#804
Ref: data-apis#355
Ref: data-apis#358
Ref: data-apis@cbbab62
@kgryte kgryte mentioned this issue Jan 9, 2025
Merged
@kgryte kgryte closed this as completed in fd6f507 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backport Changes involve backporting to previous versions. bug Something isn't working.
Projects
None yet
Milestone
v2024
Development

Successfully merging a pull request may close this issue.

fix: address default value regression for axis kwarg in vecdot kgryte/array-api
2 participants
@kgryte @oleksandr-pavlyk