Skip to content

Fix signature for linalg.vecdot #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

Fix signature for linalg.vecdot #358

merged 1 commit into from
Jan 5, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Jan 5, 2022

This PR:

@kgryte kgryte added bug Something isn't working. topic: Linear Algebra Linear algebra. labels Jan 5, 2022
@kgryte kgryte changed the title Fix siganture for linalg.vecdot Fix signature for linalg.vecdot Jan 5, 2022
@kgryte kgryte mentioned this pull request Jan 5, 2022
Closed
@kgryte
Copy link
Contributor Author

kgryte commented Jan 5, 2022

As this PR addresses an oversight and the change simply makes consistent linalg.vecdot with vecdot, will go ahead and merge.

@kgryte kgryte merged commit d60fea3 into main Jan 5, 2022
@kgryte kgryte deleted the vecdot-default branch January 5, 2022 09:40
@kgryte kgryte added this to the v2021 milestone Dec 15, 2022
kgryte added a commit to kgryte/array-api that referenced this pull request Jan 9, 2025
@kgryte
fix: address default value regression for axis kwarg in vecdot
d610848 
Closes: data-apis#804
Ref: data-apis#355
Ref: data-apis#358
Ref: data-apis@cbbab62
@kgryte kgryte mentioned this pull request Jan 9, 2025
Merged
kgryte added a commit that referenced this pull request Jan 9, 2025
@kgryte
fix: address default value regression for axis kwarg in vecdot
fd6f507 
PR-URL: #880
Closes: #804
Ref: #355
Ref: #358
Ref: cbbab62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working. topic: Linear Algebra Linear algebra.
Projects
None yet
Milestone
v2021
Development

Successfully merging this pull request may close these issues.

linalg.vecdot and vecdot have (midly) diverging defaults.
1 participant
@kgryte