Skip to content

Style Guide Review #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Style Guide Review #50

wants to merge 13 commits into from

Conversation

jc-berger
Copy link
Contributor

Due to merge conflicts with the previous PR for language review, #39, I've opened this new PR, reflecting all the doc changes while avoiding merge conflicts.

@jc-berger jc-berger added the documentation Improvements or additions to documentation label Apr 13, 2021
@jc-berger jc-berger self-assigned this Apr 13, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jc-berger
Copy link
Contributor Author

I opened this PR hoping to avoid merge conflicts. However, such is not the case. Hence, I'm closing this PR as #51 properly avoids merge conflicts. Anyone please direct your attention there. Thanks!

@jc-berger jc-berger closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants