-
Notifications
You must be signed in to change notification settings - Fork 32
WIP: made migrating docs adhere to style guide #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: made migrating docs adhere to style guide #39
Conversation
I spoke with Robert Kratky. My follow up commit will focus exclusively on a language review. Any structural changes that's seen in this current commit can be addressed in a separate issue, down the line, after I've made these language changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jc-berger A general comment: There is some work required in this migration guide to bring it to cover the entire devfile 2.x spec. The spec has changed since the last review of this documentation. I have talked to @l0rd before and we'll get some help from his team to update the content to this page since migration from devfile 1.0 to devfile 2.x is Che specific. This is a heads up that more changes may be coming in the migration doc.
docs/modules/user-guide/partials/proc_migrating-components.adoc
Outdated
Show resolved
Hide resolved
@@ -1,12 +1,10 @@ | |||
[id="proc_migrating-plug-ins_{context}"] | |||
= Migrating plug-ins | |||
= Migrating plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plugins have been removed from the specification (see devfile/api#333). The editor-specific configuration is taking a different approach. @l0rd This is one of the areas that need work on for the migration guide.
docs/modules/user-guide/partials/proc_refering-to-a-parent-devfile-in-a-devfile.adoc
Show resolved
Hide resolved
New commit is up. No rush to review since PRs #43-46 take priority, given the needed schema updates. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jc-berger The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
.Procedure | ||
|
||
* Replace `apiVersion: 1.0.0` by `schemaVersion: 2.0.0`: | ||
|
||
. To migrate a schema version from devfiles v1.x to devfiles v2.x, replace `apiVersion: 1.0.0` with `schemaVersion: 2.0.0`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do I need to go to replace the schema version? Do you change a section in the devfile? This should be more clear I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I don't know the answer. It's probably something we can tackle in the separate issue for properly structure our procedures: devfile/api#402
docs/modules/user-guide/partials/proc_migrating-schema-version.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_migrating-components.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_refering-to-a-parent-devfile-in-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_refering-to-a-parent-devfile-in-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_refering-to-a-parent-devfile-in-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-event-bindings.adoc
Outdated
Show resolved
Hide resolved
@Eva-Lotte: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…or consistency and style guide
@Eva-Lotte, thanks for the awesome feedback! I've made a new commit, I left these comments unresolved so you can see what you think about holding off on these specific concerns. Please let me know what you think after your second round of review, thanks! |
docs/modules/user-guide/partials/assembly_migrating-to-devfile-v2.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-event-bindings.adoc
Outdated
Show resolved
Hide resolved
…or consistency and style guide
@jc-berger: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #182: Review Migration Guide. I've gone through the migration docs and made them more strictly adhere to the IBM style guide.
Note, I removed a lot of the "procedures" because there weren't actually instructions for user to do anything. We most certainly can include more instructions on how to migrate, but I'm going to need help with developing that content.
We also link a lot to GitHub issues. I'm fine with this, but with all links and GH issues especially, I'm concerned the issues we link to will quickly become outdated and therefore no longer useful.