Made docs adhere to style guide #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 13, 2021
Closed
kowen-rh
reviewed
Apr 13, 2021
docs/modules/user-guide/partials/assembly_migrating-to-devfile-v2.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-event-bindings.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-event-bindings.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_migrating-components.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_refering-to-a-parent-devfile-in-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_refering-to-a-parent-devfile-in-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_refering-to-a-parent-devfile-in-a-devfile.adoc
Outdated
Show resolved
Hide resolved
added 2 commits
April 13, 2021 15:37
|
New commit, "more doc changes" is up, thanks! |
kowen-rh
reviewed
Apr 15, 2021
docs/modules/user-guide/partials/proc_migrating-schema-version.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_referring-to-a-parent-devfile-in-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_referring-to-a-parent-devfile-in-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_migrating-schema-version.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_referring-to-a-parent-devfile-in-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_migrating-components.adoc
Outdated
Show resolved
Hide resolved
kowen-rh
reviewed
Apr 16, 2021
docs/modules/user-guide/partials/proc_migrating-components.adoc
Outdated
Show resolved
Hide resolved
kowen-rh
reviewed
Apr 16, 2021
kowen-rh
reviewed
Apr 16, 2021
docs/modules/user-guide/partials/proc_adding-event-bindings.adoc
Outdated
Show resolved
Hide resolved
kowen-rh
reviewed
Apr 16, 2021
|
@robin-owen: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rkratky
approved these changes
Apr 19, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jc-berger, johnmcollier, rkratky, robin-owen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there were merge conflicts with #39, I've opened this PR instead.
This PR addresses the doc and language concerns while avoiding a merge conflict.