Skip to content

fix(ui_localizations): In the Japanese file, change "login" to "sign and improve translations #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

ywake
Copy link
Contributor

@ywake ywake commented Mar 12, 2024

Description

  • In the Japanese translation file, "Login" and "Sign in" are mixed, so I unified them with "Sign in" to match the English version.
    • There may be some debate as to whether to use "Login" or "Sign In" for this, but I decided to go with the English version.
  • Removed unnatural spaces in Japanese.
  • 日本語翻訳ファイルにおいて、「ログイン」と「サインイン」が混在しているので、英語版に合わせて「サインイン」に統一しました。
    • 「ログイン」と「サインイン」のどちらを使うべきかには議論があるかもしれませんが、英語版に合わせることにしました。
  • 日本語の不自然な空白を削除しました。

Related Issues

none

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley
Copy link
Member

Hey @ywake - is it possible you could get another developer fluent in Japanese to review this PR, please? I don't speak Japanese I'm afraid, but I am happy to get this PR merged providing it is an improvement 😄

@ywake
Copy link
Contributor Author

ywake commented Mar 14, 2024

@KoheiKanagu @keigomichi
Hello, friends.
I saw you in a past pull request, so I was wondering if you could review my pull request?

Copy link
Contributor

@KoheiKanagu KoheiKanagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ywake
Copy link
Contributor Author

ywake commented Mar 15, 2024

@russellwheatley
I received a review 😄

@russellwheatley
Copy link
Member

Thanks @KoheiKanagu & @ywake 🙏

@russellwheatley russellwheatley changed the title fix(ui_localizations): In the Japanese file, change "login" to "sign … fix(ui_localizations): In the Japanese file, change "login" to "sign and improve translations Mar 19, 2024
@russellwheatley russellwheatley merged commit ae01e9f into firebase:main Mar 19, 2024
14 of 17 checks passed
@ywake ywake deleted the unify_login_to_signin_ja branch March 20, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants