Skip to content

firestore::local::MemoryDocumentOverlayCache added. #9330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 14, 2022
Merged

firestore::local::MemoryDocumentOverlayCache added. #9330

merged 4 commits into from
Feb 14, 2022

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Feb 10, 2022 •
edited
Loading

Port MemoryDocumentOverlayCache and its unit tests from the Android SDK.

The following files were ported nearly verbatim, comments and all:

The LevelDbDocumentOverlayCache class is also added in this PR, but without any implementation. The implementation will be added in a future PR.

The unit test parameterization style used in document_overlay_cache_test.h, document_overlay_cache_test.cc, and memory_document_overlay_cache_test.cc was adapted from the style used in mutation_queue_test.h, mutation_queue_test.cc, and memory_mutation_queue_test.cc, respectively.

Googlers see b/210002758 for details.

#no-changelog

@dconeybe dconeybe self-assigned this Feb 10, 2022
@dconeybe dconeybe force-pushed the dconeybe/MemoryDocumentOverlayCache branch from 54eaab9 to 376e8a1 Compare February 10, 2022 15:07
@google-oss-bot
Copy link

google-oss-bot commented Feb 10, 2022 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (4a7a99e)Merge (1892180)Diff
    CocoaPods4.92 MB4.95 MB+35.4 kB (+0.7%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yDZu2XChCO.html

@google-oss-bot
Copy link

google-oss-bot commented Feb 10, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 86.57% (4a7a99e) to 86.56% (1892180) by -0.01%.

    FilenameBase (4a7a99e)Merge (1892180)Diff
    leveldb_document_overlay_cache.cc?0.00%?
    leveldb_persistence.cc88.31%86.08%-2.24%
    memory_document_overlay_cache.cc?100.00%?
    memory_persistence.cc100.00%95.65%-4.35%
    ordered_code.cc93.41%94.15%+0.73%
    serializer.cc87.11%87.65%+0.54%
    task.cc93.04%94.78%+1.74%
    watch_stream.cc90.70%95.35%+4.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OvIp9t9Dmi.html

@dconeybe dconeybe requested a review from wu-hui February 10, 2022 17:12
wu-hui
wu-hui approved these changes Feb 11, 2022
View reviewed changes
@wu-hui wu-hui removed their assignment Feb 11, 2022
@dconeybe dconeybe enabled auto-merge (squash) February 14, 2022 15:34
@dconeybe dconeybe mentioned this pull request Feb 14, 2022
Merged
@dconeybe dconeybe merged commit 37c273f into master Feb 14, 2022
@dconeybe dconeybe deleted the dconeybe/MemoryDocumentOverlayCache branch February 14, 2022 16:12
@dconeybe dconeybe mentioned this pull request Feb 14, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @wu-hui