Combine environment setting steps into one step with shell script #1010

sunmou99 · 2022-06-30T05:51:29Z

Description

Removed some environment setting steps, now we are using the following script to set Integration Test CI environments:
python scripts/gha/install_prereqs.sh - ${platform}

Other experiments :

If the workflow specified a Windows runner, you would use the different syntax for PowerShell, $env:NAME. (source)
While using python scripts, I failed to specify bash.exe as the shell on Windows runner.
Windows git command line can be different. (source)
Need workaround to use Github Action context variables in shell script. (discussion)
lint_commenter raise UnidiffParseError('Unexpected trailing newline character') if the PR change end with a "file name change without file content change". (example)

Testing

See the comment below

Type of Change

Place an x the applicable box:

Bug fix. Add the issue # below if applicable.
New feature. A non-breaking change which adds functionality.
Other, such as a build process or documentation change.

Notes

Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
Read the contribution guidelines CONTRIBUTING.md.
Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

github-actions · 2022-06-30T06:30:47Z

❌ Integration test FAILED

Requested by @sunmou99 on commit 5ccf419
Last updated: Mon Jul 11 15:11 PDT 2022
View integration test log & download artifacts

Failures	Configs
database	[TEST] [ERROR] [Windows] [x64] [openssl]
firestore	(5 items) [TEST] [ERROR] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target] [TEST] [ERROR] [Windows] [x64] [openssl] [TEST] [FAILURE] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target] (2 failed tests) ServerTimestampTest.TestServerTimestampsCanReturnPreviousValueOfDifferentType WriteBatchTest.TestCanWriteTheSameDocumentMultipleTimes [TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: simulator_target] (1 failed tests) NumericTransformsTest.MultipleDoubleIncrements [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target] (1 failed tests) CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

jonsimantov · 2022-07-01T17:00:04Z

.github/workflows/integration_tests.yml

      - uses: actions/checkout@v2
        with:
          ref: ${{needs.check_and_prepare.outputs.github_ref}}
          submodules: true
-      - name: Store git credentials for all git commands


Is this step still happening? It's important for the GitHub runners to store the token for all git commands.

Yes. In the script:
https://github.com/firebase/firebase-cpp-sdk/pull/1010/files#diff-450a17b847bd02ee9b76b1716aa2c85c5a4544dcf46db85496a4cda5c0270893R50

Why it's important, e.g. what will happen if we don't have it? And does step the order matters?

This helps us with the issue where GitHub would throttle anonymous Git requests (requests without a token). It's important when downloading external projects, fetching cocoapods, etc. (#727)

jonsimantov

LGTM - this doesn't affect packaging, right?

sunmou99 · 2022-07-11T17:28:56Z

LGTM - this doesn't affect packaging, right?

Yeah, this only affects the testing part.

…ript (#1010)" This reverts commit 5ccf419. This is a potential fix for the test failures of `test-desktop-windows-latest-x64-openssl`

…shell script (#1010)"" This reverts commit 9330d59.

…ript (#1010)" This reverts commit 5ccf419.

…ript (#1010)" (#1029) This reverts commit 5ccf419.

…shell script (#1010)" (#1029)" This reverts commit 8b7b067.

sunmou99 added 16 commits June 29, 2022 21:15

new shell script

1707dbf

new shell script

f840629

new shell script

42bfe56

new shell script

ad9b308

new shell script

8b89f67

new shell script

4aca351

new shell script

f3e2216

new shell script

246a995

new shell script

4ee4f9a

new shell script

369b832

new shell script

11be665

new shell script

a8a6639

new shell script

9573a9c

new shell script

624a562

new shell script

0cc99d4

new shell script

1c38b62

sunmou99 added the skip-release-notes Skip release notes check label Jun 30, 2022

sunmou99 added 3 commits June 29, 2022 23:06

remove python script

80cfb84

test lint

1b65a59

test lint

d02671e

sunmou99 marked this pull request as ready for review June 30, 2022 06:26

update timeout

4464e40

sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jun 30, 2022

github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 30, 2022

sunmou99 changed the title ~~Feature/it env sh script~~ Combine environment setting steps into one step with shell script Jun 30, 2022

test lint

79f10ac

github-actions bot added the tests: failed This PR's integration tests failed. label Jun 30, 2022

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2022

sunmou99 requested a review from jonsimantov June 30, 2022 16:21

script name more descriptive

0ef83ae

sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jun 30, 2022

github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jun 30, 2022

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 1, 2022

jonsimantov reviewed Jul 1, 2022

View reviewed changes

sunmou99 requested a review from jonsimantov July 1, 2022 18:37

jonsimantov approved these changes Jul 11, 2022

View reviewed changes

sunmou99 removed the tests: failed This PR's integration tests failed. label Jul 11, 2022

sunmou99 enabled auto-merge (squash) July 11, 2022 17:29

fix name

a9c7253

sunmou99 merged commit 5ccf419 into main Jul 11, 2022

github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jul 11, 2022

sunmou99 deleted the feature/it-env-sh-script branch July 11, 2022 21:45

sunmou99 restored the feature/it-env-sh-script branch July 11, 2022 21:55

sunmou99 deleted the feature/it-env-sh-script branch July 11, 2022 21:56

github-actions bot added the tests: failed This PR's integration tests failed. label Jul 11, 2022

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 11, 2022

dconeybe added a commit that referenced this pull request Jul 16, 2022

Revert "Combine environment setting steps into one step with shell sc…

9330d59

…ript (#1010)" This reverts commit 5ccf419. This is a potential fix for the test failures of `test-desktop-windows-latest-x64-openssl`

dconeybe added a commit that referenced this pull request Jul 18, 2022

Revert "Revert "Combine environment setting steps into one step with …

67d645a

…shell script (#1010)"" This reverts commit 9330d59.

dconeybe mentioned this pull request Jul 18, 2022

desktop_tester.py: some random improvements to help with debugging failed runs #1027

Merged

AlmostMatt added a commit that referenced this pull request Jul 18, 2022

Revert "Combine environment setting steps into one step with shell sc…

4c70538

…ript (#1010)" This reverts commit 5ccf419.

AlmostMatt mentioned this pull request Jul 18, 2022

Rollback "Combine environment setting steps into one step with shell sc… #1029

Merged

3 tasks

AlmostMatt added a commit that referenced this pull request Jul 18, 2022

Revert "Combine environment setting steps into one step with shell sc…

8b7b067

…ript (#1010)" (#1029) This reverts commit 5ccf419.

sunmou99 added a commit that referenced this pull request Jul 18, 2022

Revert "Revert "Combine environment setting steps into one step with …

d1c659f

…shell script (#1010)" (#1029)" This reverts commit 8b7b067.

firebase locked and limited conversation to collaborators Aug 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Combine environment setting steps into one step with shell script #1010

Combine environment setting steps into one step with shell script #1010

sunmou99 commented Jun 30, 2022 •

edited

Loading

github-actions bot commented Jun 30, 2022 •

edited

Loading

jonsimantov Jul 1, 2022

sunmou99 Jul 1, 2022

sunmou99 Jul 1, 2022 •

edited

Loading

jonsimantov Jul 1, 2022 •

edited

Loading

jonsimantov left a comment

sunmou99 commented Jul 11, 2022 •

edited

Loading

Combine environment setting steps into one step with shell script #1010

Combine environment setting steps into one step with shell script #1010

Conversation

sunmou99 commented Jun 30, 2022 • edited Loading

Description

Testing

Type of Change

Notes

github-actions bot commented Jun 30, 2022 • edited Loading

❌ Integration test FAILED

jonsimantov Jul 1, 2022

Choose a reason for hiding this comment

sunmou99 Jul 1, 2022

Choose a reason for hiding this comment

sunmou99 Jul 1, 2022 • edited Loading

Choose a reason for hiding this comment

jonsimantov Jul 1, 2022 • edited Loading

Choose a reason for hiding this comment

jonsimantov left a comment

Choose a reason for hiding this comment

sunmou99 commented Jul 11, 2022 • edited Loading

sunmou99 commented Jun 30, 2022 •

edited

Loading

github-actions bot commented Jun 30, 2022 •

edited

Loading

sunmou99 Jul 1, 2022 •

edited

Loading

jonsimantov Jul 1, 2022 •

edited

Loading

sunmou99 commented Jul 11, 2022 •

edited

Loading