Skip to content

Rollback "Combine environment setting steps into one step with shell sc… #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2022
Merged

Rollback "Combine environment setting steps into one step with shell sc… #1029

merged 1 commit into from
Jul 18, 2022

Conversation

AlmostMatt
Copy link
Contributor

…ript (#1010)"

This reverts commit #1010 (Commit 5ccf419)

After that change, test-desktop-windows-latest-x64-openssl is consistently failing, seemingly due to missing dependencies.

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@AlmostMatt AlmostMatt added the tests-requested: quick Trigger a quick set of integration tests. label Jul 18, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 18, 2022
@github-actions
Copy link

github-actions bot commented Jul 18, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @AlmostMatt on commit 8b7b067
Last updated: Mon Jul 18 18:45 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [BUILD] [ERROR] [iOS] [macos]
[TEST] [ERROR] [Android] [2/3 os: macos windows] [1/2 android_device: android_target]
storage [TEST] [FAILURE] [MacOS] [x64] [openssl]
(2 failed tests)  FirebaseStorageTest.TestDeleteWithMaxRetryDuration
  FirebaseStorageTest.TestGetMetadataWithMaxRetryDuration
[TEST] [FAILURE] [Windows] [x64] [openssl]
(1 failed tests)  FirebaseStorageTest.TestDeleteWithMaxRetryDuration

Add flaky tests to go/fpl-cpp-flake-tracker

@dconeybe dconeybe added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. labels Jul 18, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Jul 18, 2022
@AlmostMatt AlmostMatt requested a review from sunmou99 July 18, 2022 19:57
sunmou99
sunmou99 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTLM

@AlmostMatt AlmostMatt enabled auto-merge (squash) July 18, 2022 21:19
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 18, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 18, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 18, 2022
@AlmostMatt AlmostMatt removed the tests: failed This PR's integration tests failed. label Jul 18, 2022
@AlmostMatt AlmostMatt disabled auto-merge July 18, 2022 22:17
@AlmostMatt AlmostMatt enabled auto-merge (squash) July 18, 2022 22:17
@AlmostMatt AlmostMatt merged commit 8b7b067 into main Jul 18, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Jul 18, 2022
sunmou99 added a commit that referenced this pull request Jul 18, 2022
@sunmou99
Revert "Revert "Combine environment setting steps into one step with …
d1c659f 
…shell script (#1010)" (#1029)"

This reverts commit 8b7b067.
@sunmou99 sunmou99 mentioned this pull request Jul 18, 2022
Merged
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 19, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 19, 2022
@firebase firebase locked and limited conversation to collaborators Aug 18, 2022
@AlmostMatt AlmostMatt deleted the rollback-pr-1010 branch October 20, 2022 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sunmou99 sunmou99 sunmou99 approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlmostMatt @sunmou99 @dconeybe