Skip to content

[on fork, easier to review] 3/n Consolidate collective functions - Integrate with TTPs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 28 commits into from
Closed

[on fork, easier to review] 3/n Consolidate collective functions - Integrate with TTPs #1

wants to merge 28 commits into from

Conversation

four4fish
Copy link
Owner

Same as Lightning-AI#9472

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

daniellepintz and others added 20 commits September 9, 2021 20:53
@daniellepintz
Deprecate LightningModule.get_progress_bar_dict (Lightning-AI#8985)
160e7e1 
* Move get_progress_bar_dict from lightning module to progress bar callback
@aphedges
Fix name order in CITATION.cff (Lightning-AI#9423)
58de08d
@ananthsub
[loops] Reset reference to dataloader iterator on run end (Lightning-…
c963bf6 
…AI#9386)

* [loops] Reset reference to dataloader iterator on run end
@kaushikb11 @ananthsub @awaelchli
Add remove_checkpoint to CheckpointIO plugin to simplify ModelCheckpo… (
d028e36 
Lightning-AI#9373)

Co-authored-by: ananthsub <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
@kaushikb11 @Borda
Disable benchmark ci on PRs (Lightning-AI#9430)
3118480 
Co-authored-by: Jirka <[email protected]>
@carmocca
Share the training step output data via ClosureResult (Lightning-AI…
e0f2e04 
…#9349)
@carmocca
Type the Loop base class as generic (Lightning-AI#9418)
4f8c3ba
@kaushikb11 @ethanwharris @pre-commit-ci
feat: Add ModelSummary Callback (Lightning-AI#9344)
d773407 
Co-authored-by: Ethan Harris <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@carmocca
Loop and test restructuring (Lightning-AI#9383)
9eccb31
[docs] Clear up default logging, showing you don't need to pass a log…
81687aa 
…ger (Lightning-AI#9408)
@tchaton
[Refactor] Improve auto-encoder example (Lightning-AI#9402)
ffd275f
@shnela @awaelchli @tchaton
Adapt NeptuneLogger to new neptune-client api (Lightning-AI#6867)
ee37872 
* Initial split to NeptuneLegacyLogger and NeptuneLogger

* Adapt NeptuneLogger to neptune-pytorch-lightning repo version

* Fix stylecheck and tests

* Fix style and PR suggestions

* Expect Run object in NeptuneLogger.init

* Model checkpoint support and restructured tests

* Reformat code - use " instead of '

* Fix logging INTEGRATION_VERSION_KEY

* Update CHANGELOG.md

* Fix stylecheck

* Remove NeptuneLegacyLogger

* updated neptune-related docstrings

* PR suggestions

* update CODEOWERS file
* move import logic to imports.py
* minor neptune.py improvements

* formatting fixes and minor updates

* Fix generation of docs

* formatting fixes and minor updates

* fix

* PR fixes vol. 2

* define return type of _dict_paths method
* bump required version of `neptune-client`

* Enable log_* functions

* Update pytorch_lightning/loggers/neptune.py

Co-authored-by: Adrian Wälchli <[email protected]>

* Revert "Enable log_* functions"

This reverts commit 050a436.

* Make global helper lists internal

* Logger's `name` and `version` methods return proper results

* Initialize Run and its name and id at logger init level

* Make _init_run_instance static

* Add pre-commit hook code changes.

* Fix blacken-docs check

* Fix neptune doctests and test_all

* added docs comment about neptune-specific syntax

* added docs comment about neptune-specific syntax in the loggers.rst

* fix

* Add pickling test

* added myself to neptune codeowners

* Enable some of deprecated log_* functions

* Restore _run_instance for unpickled logger

* Add `step` parameter to log_* functions

* Fix stylecheck

* Fix checkstyle

* Fix checkstyle

* Update pytorch_lightning/loggers/neptune.py

Co-authored-by: thomas chaton <[email protected]>

* Fix tests

* Fix stylecheck

* fixed project name

* Fix windows tests

* Fix stylechecks

* Fix neptune docs tests

* docformatter fixes

* De-duplicate legacy_kwargs_msg

* Update .github/CODEOWNERS

Co-authored-by: Adrian Wälchli <[email protected]>

Co-authored-by: kamil-kaczmarek <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
@awaelchli
Merge pull request Lightning-AI#9438 from PyTorchLightning/feature/ne…
7ca038b 
…ptune-code-owners

add neptune staff as code owners for neptune.py
@awaelchli @justusschock
fix resuming from checkpoint for fault-tolerant in case of no failure (…
6ff43cb 
…Lightning-AI#9371)

Co-authored-by: Justus Schock <[email protected]>
@kaushikb11
Update torch_xla wheels installation link (Lightning-AI#9436)
15434a9
@daniellepintz @pre-commit-ci
@tchaton @ananthsub @awaelchli @Borda
Move add_to_queue/get_from_queue to DDPSpawnPlugin (Lightning-AI#9118)
cc2ac02 

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: tchaton <[email protected]>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
@ananthsub
[bugfix] Revert inference mode support from Lightning-AI#8813 (Lightn…
d2def36 
…ing-AI#9443)

Fixes Lightning-AI#9431
@kaushikb11
Fix type hint for filepath (Lightning-AI#9434)
b294c57
@daniellepintz @awaelchli
Add on_exception hook to documentation (Lightning-AI#9365)
83bff01 
* Small doc fixes

* remove space

* small fix

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <[email protected]>

Co-authored-by: Adrian Wälchli <[email protected]>
@awaelchli
update rank_zero condition for logging summary (Lightning-AI#9461)
8d255b2
@four4fish four4fish closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@four4fish @daniellepintz @aphedges @ananthsub @kaushikb11 @carmocca @tchaton @shnela @awaelchli