Skip to content

feat(expo): Add Expo Support #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Jan 15, 2024
Merged

feat(expo): Add Expo Support #3399

merged 47 commits into from
Jan 15, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Nov 15, 2023 •
edited
Loading

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7499eaa

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 450.06 ms 467.34 ms 17.28 ms
Size 17.73 MiB 19.85 MiB 2.11 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2534337 394.15 ms 415.12 ms 20.97 ms
e2b64fe 316.88 ms 330.23 ms 13.35 ms
12427f4 393.69 ms 414.84 ms 21.14 ms
d361d38 354.10 ms 381.69 ms 27.59 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
abb7058 370.27 ms 389.58 ms 19.31 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
457e29f 398.10 ms 421.39 ms 23.29 ms
22e31b6 396.48 ms 419.64 ms 23.16 ms

App size

Revision Plain With Sentry Diff
2534337 17.73 MiB 19.84 MiB 2.11 MiB
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
12427f4 17.73 MiB 19.85 MiB 2.12 MiB
d361d38 17.73 MiB 19.81 MiB 2.08 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
abb7058 17.73 MiB 19.83 MiB 2.10 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB
22e31b6 17.73 MiB 19.84 MiB 2.10 MiB

Previous results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b 419.25 ms 458.81 ms 39.56 ms

App size

Revision Plain With Sentry Diff
bc4097b 17.73 MiB 19.84 MiB 2.11 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 329.49 ms 359.71 ms 30.22 ms
Size 7.15 MiB 8.11 MiB 990.89 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
12427f4+dirty 379.48 ms 400.92 ms 21.44 ms
5446992+dirty 371.61 ms 390.00 ms 18.39 ms
1d86dd6+dirty 335.76 ms 371.22 ms 35.46 ms
b1e8712+dirty 322.55 ms 331.84 ms 9.29 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
3ffcddd+dirty 244.82 ms 295.47 ms 50.65 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
575f9da+dirty 337.15 ms 370.47 ms 33.32 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
34aba08+dirty 331.79 ms 376.69 ms 44.91 ms

App size

Revision Plain With Sentry Diff
12427f4+dirty 7.15 MiB 8.12 MiB 997.78 KiB
5446992+dirty 7.15 MiB 8.12 MiB 999.45 KiB
1d86dd6+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
b1e8712+dirty 7.15 MiB 8.04 MiB 912.27 KiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
3ffcddd+dirty 7.15 MiB 8.04 MiB 912.17 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
575f9da+dirty 7.15 MiB 8.10 MiB 979.68 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
34aba08+dirty 7.15 MiB 8.07 MiB 946.13 KiB

Previous results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b+dirty 378.29 ms 413.31 ms 35.01 ms

App size

Revision Plain With Sentry Diff
bc4097b+dirty 7.15 MiB 8.11 MiB 988.88 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.82 ms 1232.02 ms 17.20 ms
Size 2.36 MiB 2.88 MiB 526.50 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
1d86dd6+dirty 1249.71 ms 1279.16 ms 29.45 ms
d361d38+dirty 1246.04 ms 1267.12 ms 21.08 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
22e31b6+dirty 1253.62 ms 1265.96 ms 12.34 ms
0677344+dirty 1276.70 ms 1300.07 ms 23.37 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms

App size

Revision Plain With Sentry Diff
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
1d86dd6+dirty 2.36 MiB 2.89 MiB 535.43 KiB
d361d38+dirty 2.36 MiB 2.85 MiB 499.84 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
22e31b6+dirty 2.36 MiB 2.87 MiB 520.67 KiB
0677344+dirty 2.36 MiB 2.85 MiB 496.81 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB

Previous results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b+dirty 1223.67 ms 1230.08 ms 6.41 ms

App size

Revision Plain With Sentry Diff
bc4097b+dirty 2.36 MiB 2.88 MiB 524.45 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2023 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.12 ms 1214.27 ms 0.14 ms
Size 2.92 MiB 3.43 MiB 530.11 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
27ef4ee+dirty 1236.41 ms 1244.90 ms 8.49 ms
6e8584e+dirty 1271.71 ms 1281.26 ms 9.55 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
e5c9b8b+dirty 1276.90 ms 1280.92 ms 4.02 ms

App size

Revision Plain With Sentry Diff
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
27ef4ee+dirty 2.92 MiB 3.41 MiB 503.72 KiB
6e8584e+dirty 2.92 MiB 3.44 MiB 536.52 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
e5c9b8b+dirty 2.92 MiB 3.43 MiB 524.50 KiB

Previous results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b+dirty 1229.02 ms 1235.65 ms 6.63 ms

App size

Revision Plain With Sentry Diff
bc4097b+dirty 2.92 MiB 3.43 MiB 528.75 KiB

krystofwoldrich and others added 23 commits November 29, 2023 10:10
@krystofwoldrich
feat(expo): Add @sentry/react-native/expo export for expo-plugin (#3429)
21d165e
@krystofwoldrich
feat(samples): Add Expo sample application (#3427)
3120e1d
@krystofwoldrich
fix(web): Fix JSX build errors when using Webpack (#3428)
5b207d9
@krystofwoldrich
feat(xcode): Dynamically resolve SDK and CLI package paths (#3431)
62320b4
@krystofwoldrich
Merge remote-tracking branch 'origin/main' into expo
d93ea93
@krystofwoldrich
fix(xcode): Collect modules js path from shell
1bcb0b5
@krystofwoldrich
Merge remote-tracking branch 'origin/release/5.15.0' into expo
f990c2e
@krystofwoldrich
Merge remote-tracking branch 'origin/main' into expo
81563a3
@krystofwoldrich
chore(changelog): Add experimental note to Expo support
de57355
@getsentry-bot
release: 5.16.0-alpha.1
e912ae5
Merge branch 'release/5.16.0-alpha.1' into expo
b85b73a
@krystofwoldrich
chore(expo): Bump Expo min version to SDK 49 (#3453)
6f95f45
@krystofwoldrich
feat(expo): Add withSentryExpoSerializers for easy metro configurat…
817bb8d 
…ion (#3454)
@krystofwoldrich
fix(sample): All Expo native scripts paths are relative to the repo r…
a788595 
…oot (#3461)
@krystofwoldrich
fix(web): Remove all RN internals imports for web builds (#3462)
cae7f34
@krystofwoldrich
fix(sdk): Remove circular dependencies from SDK code (#3464)
f6575dd
@krystofwoldrich
fix(promises): Fix missing RN Promise import waring
d228d68
@krystofwoldrich
Merge branch 'main' into expo
544a858
@getsentry-bot
release: 5.16.0-alpha.2
1bc6744
Merge branch 'release/5.16.0-alpha.2' into expo
1007a35
@krystofwoldrich
Merge branch 'main' into expo
e9bff4c
@krystofwoldrich
chore(internal): Use new DSN after leaked token
4fd5328
@krystofwoldrich
Merge branch 'origin/main' into expo
0179309
krystofwoldrich and others added 22 commits January 8, 2024 11:45
@krystofwoldrich
Add 5.15.2 fixes info to the changelog
2593f66
@krystofwoldrich
chore(sample): Update Expo sample to SDK 50 beta 0 (#3463)
337cd67
@krystofwoldrich
chore(sample): Update DSN
1e7038e
@quinlanj
feat(expo): Add support to inject debug module before serialization (#…
e5538c1 
…3477)
@krystofwoldrich
chore(sdk): Bump Expo to 50.0.0-preview.8 (#3500)
1fa5bbc
@krystofwoldrich
feat(expo): More universal getSentryExpoConfig (#3501)
2e40f57
@quinlanj
feat(expo): Add source maps upload script (#3491)
6bd18dc
@krystofwoldrich
fix(expo): Fix expo upload source maps script lint (#3508)
55fe14c
@krystofwoldrich
feat(expo): Dynamically resolve default integrations based on platform (
dc8966b 
#3465)
@krystofwoldrich
feat(expo): Dynamically resolve sentry-cli path in expo source maps u…
8d8a8a4 
…pload script (#3507)
@krystofwoldrich
Merge remote-tracking branch 'origin/main' into expo
a48c9b5
@krystofwoldrich
feat(expo): Add Expo Modules Integration (#3466)
4fb79c3
@krystofwoldrich
feat(expo): Add npx sentry-expo-upload-sourcemaps command (#3510)
0d87adb
@getsentry-bot
release: 5.16.0-alpha.3
3a2721b
Merge branch 'release/5.16.0-alpha.3' into expo
70f6d72
@krystofwoldrich
fix(expo): Make getSentryExpoConfig options param optional (#3514)
2684f2c
@krystofwoldrich
fix(expo): Use @sentry/react-native/expo as plugin name in expo upl…
e9e2c8c 
…oad (#3515)
@krystofwoldrich
Merge branch 'main' into expo
4e64cdd
@getsentry-bot
release: 5.16.0-alpha.4
1423f05
Merge branch 'release/5.16.0-alpha.4' into expo
b51f045
@krystofwoldrich
Merge branch 'main' into expo
e0f5713
@krystofwoldrich
chore(sdk): Add Expo release summary to the changelog (#3522)
7499eaa
@krystofwoldrich krystofwoldrich marked this pull request as ready for review January 15, 2024 15:05
kahest
kahest approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

massive achievement 🚀

@krystofwoldrich krystofwoldrich merged commit ee8c0d1 into main Jan 15, 2024
@krystofwoldrich krystofwoldrich deleted the expo branch January 15, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kahest kahest kahest approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krystofwoldrich @kahest @kbrandwijk @getsentry-bot @quinlanj