Skip to content

Pre-save Rule to prevent name data from being saved in conditions and actions #55112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ceorourke opened this issue Aug 18, 2023 · 0 comments · Fixed by #55091
Closed

Pre-save Rule to prevent name data from being saved in conditions and actions #55112

ceorourke opened this issue Aug 18, 2023 · 0 comments · Fixed by #55091
Assignees
@ceorourke

Comments

@ceorourke
Copy link
Member

ceorourke commented Aug 18, 2023 •
edited
Loading

Despite the work done in #54739 and #54746 we still have an edge case where we're saving name data for sentry.rules.filters.tagged_event.TaggedEventFilter and sentry.rules.filters.level.LevelFilter possibly when duplicating older alerts. Adding a pre_save should prevent this so we can move forward with the data migration.

https://redash.getsentry.net/queries/4772/source
@ceorourke ceorourke self-assigned this Aug 18, 2023
This was referenced Aug 18, 2023
Merged
Closed
ceorourke added a commit that referenced this issue Aug 28, 2023
@ceorourke
ref(rules): Pre-save rules w/o condition names (#55091)
9593038 
Add a `pre_save` signal to `Rule` to hopefully actually prevent any
`name` data being save in the conditions part of rule.data. Everything
should have been covered in
https://github.com/getsentry/sentry/pull/54746/files but looking at
production data since that was deployed shows an edge case where
sometimes it's still being saved that I can't replicate.

Closes #55112
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ceorourke ceorourke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(rules): Pre-save rules w/o condition names getsentry/sentry
1 participant
@ceorourke