Skip to content

ref(alerts): Prevent name data from being saved to db #54746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2023
Merged

ref(alerts): Prevent name data from being saved to db #54746

merged 4 commits into from
Aug 16, 2023

Conversation

ceorourke
Copy link
Member

Backend piece to #54739 to make sure we aren't saving the name field to the Rule table's data column.

@ceorourke ceorourke requested a review from a team as a code owner August 15, 2023 01:07
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 15, 2023
ceorourke
ceorourke commented Aug 15, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #54746 (37dc693) into master (fa748ef) will increase coverage by 0.09%.
Report is 117 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #54746      +/-   ##
==========================================
+ Coverage   79.78%   79.87%   +0.09%     
==========================================
  Files        5000     5025      +25     
  Lines      212248   213814    +1566     
  Branches    36162    36373     +211     
==========================================
+ Hits       169333   170777    +1444     
- Misses      37706    37796      +90     
- Partials     5209     5241      +32
Files Changed Coverage Δ
src/sentry/api/endpoints/project_rule_details.py 85.86% <ø> (-0.45%) ⬇️
src/sentry/monitors/utils.py 94.62% <ø> (ø)
src/sentry/api/serializers/rest_framework/rule.py 68.75% <100.00%> (+1.80%) ⬆️

... and 107 files with indirect coverage changes

@ceorourke ceorourke requested a review from a team as a code owner August 16, 2023 17:30
scttcper
scttcper approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no names

@ceorourke ceorourke merged commit a80af8d into master Aug 16, 2023
@ceorourke ceorourke deleted the ceorourke/rm-name-from-alert-rule branch August 16, 2023 20:37
This was referenced Aug 17, 2023
Merged
Closed
Closed
ceorourke added a commit that referenced this pull request Aug 29, 2023
@ceorourke
ref(rule): Remove name field from all rule.data (#54915)
427037d 
This is a follow up to #54739
and #54746 to normalize the
issue alert rule data to not have the unnecessary "name" field.

We have 1,413,825 rows to check so I'm marking it as dangerous.

Closes #55115
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceorourke @scttcper