Skip to content

Migrate Rule data for consistency #55115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ceorourke opened this issue Aug 18, 2023 · 1 comment · Fixed by #54915
Closed

Migrate Rule data for consistency #55115

ceorourke opened this issue Aug 18, 2023 · 1 comment · Fixed by #54915
Assignees
@ceorourke

Comments

@ceorourke
Copy link
Member

ceorourke commented Aug 18, 2023 •
edited
Loading

We have inconsistent data saved in the conditions and actions fields in Rule's data column because in the past we sometimes added a name field which is a human readable string describing what the rule is doing. This is unnecessary and makes it harder to compare and do analysis on rule data, so we should write a migration to delete all that stuff now that we're not writing that to the db anymore.
@ceorourke ceorourke self-assigned this Aug 18, 2023
@ceorourke ceorourke mentioned this issue Aug 18, 2023
Merged
@ceorourke
Copy link
Member Author

Blocked by #55112 being merged and confirmation that the bad data is no longer being written.

ceorourke added a commit that referenced this issue Aug 29, 2023
@ceorourke
ref(rule): Remove name field from all rule.data (#54915)
427037d 
This is a follow up to #54739
and #54746 to normalize the
issue alert rule data to not have the unnecessary "name" field.

We have 1,413,825 rows to check so I'm marking it as dangerous.

Closes #55115
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ceorourke ceorourke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(rule): Remove name field from all rule.data getsentry/sentry
1 participant
@ceorourke