ref(rule): Remove name field from all rule.data #54915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
-- |
Codecov Report
@@ Coverage Diff @@
## master #54915 +/- ##
=======================================
Coverage 80.01% 80.01%
=======================================
Files 5042 5042
Lines 214964 214964
Branches 36500 36500
=======================================
+ Hits 171994 172005 +11
+ Misses 37689 37678 -11
Partials 5281 5281 |
markstory
reviewed
Aug 17, 2023
Comment on lines
14
to
19
| if action.get("name"): | ||
| del action["name"] | ||
|
|
||
| for condition in rule.data.get("conditions", []): | ||
| if condition.get("name"): | ||
| del condition["name"] |
There was a problem hiding this comment.
Do you care if empty string, 0, or None are left behind?
markstory
approved these changes
Aug 17, 2023
ceorourke
force-pushed
the
ceorourke/rule-data-migration-rm-name
branch
from
b3f694a to
ba11288
Compare
|
This PR has a migration; here is the generated SQL for --
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
-- |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #54739 and #54746 to normalize the issue alert rule data to not have the unnecessary "name" field.
We have 1,413,825 rows to check so I'm marking it as dangerous.
Closes #55115