Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(derived_code_mappings): Do not create object in parametrization section #86188

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Mar 3, 2025

When doing local development I noticed some funkiness due to this.

… section

When doing local development I noticed some funkiness and it was due to this.
@armenzg armenzg requested a review from a team as a code owner March 3, 2025 13:08
@armenzg armenzg self-assigned this Mar 3, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 3, 2025
logger.warning("Investigate if we use this code path in production.")
return [stacktrace]
if "stacktrace" in data:
return [data["stacktrace"]]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unrelated change but I wanted to get it out.

@armenzg armenzg merged commit 3a1cb64 into master Mar 3, 2025
49 checks passed
@armenzg armenzg deleted the ref/tests/derived_code_mapping/armenzg branch March 3, 2025 19:52
jan-auer added a commit that referenced this pull request Mar 4, 2025
* master: (50 commits)
  fix(laravel-insights): fix seconds vs milliseconds in jobs widget (#86273)
  feat(assemble): Implement new query for finding missing chunk (#85614)
  fix(issue-views): Fix buggy dragging  (#86264)
  feat(workflow_engine): Add DELETE Workflow Endpoint (#86246)
  feat(crons): Improve wording for project field in validator (#86158)
  ref(ui): Remove unused images (#86249)
  feat(compare queries): tightened padding, added tooltips, and fixed panel heights (#86227)
  fix(billing): update billing details tab (#86152)
  fix(nav): Show same nav items when user is in org or user settings. (#86161)
  feat(ourlogs): Add alpha js sdk for adding logging (#86239)
  chore(dashboards): Remove chart from Releases drawer (#86237)
  ref(flags): fix audit log table badge style (#86224)
  fix(replay): Remove extra border & padding from replay snippets (#86223)
  ref(insights): remove performance-landing-page-stats-period flag (#86200)
  fix(insights): Filter span samples by environment (#86198)
  ref(insights): Replace usage of `<ReleaseSeries>` in `<InsightsTimeSeriesWidget>` (#86129)
  feat(explore): Hide Confidence footer with 100% sample rate (#86206)
  ref(dashboards): Move unit scaling into `Plottable` (#86116)
  tests(derived_code_mappings): Do not create object in parametrization section (#86188)
  chore: update gsApp CODEOWNERS  (#86222)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants