fix(issue-views): Fix buggy dragging #86264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
approved these changes
Mar 4, 2025
jan-auer
added a commit
that referenced
this pull request
Mar 4, 2025
* master: (50 commits) fix(laravel-insights): fix seconds vs milliseconds in jobs widget (#86273) feat(assemble): Implement new query for finding missing chunk (#85614) fix(issue-views): Fix buggy dragging (#86264) feat(workflow_engine): Add DELETE Workflow Endpoint (#86246) feat(crons): Improve wording for project field in validator (#86158) ref(ui): Remove unused images (#86249) feat(compare queries): tightened padding, added tooltips, and fixed panel heights (#86227) fix(billing): update billing details tab (#86152) fix(nav): Show same nav items when user is in org or user settings. (#86161) feat(ourlogs): Add alpha js sdk for adding logging (#86239) chore(dashboards): Remove chart from Releases drawer (#86237) ref(flags): fix audit log table badge style (#86224) fix(replay): Remove extra border & padding from replay snippets (#86223) ref(insights): remove performance-landing-page-stats-period flag (#86200) fix(insights): Filter span samples by environment (#86198) ref(insights): Replace usage of `<ReleaseSeries>` in `<InsightsTimeSeriesWidget>` (#86129) feat(explore): Hide Confidence footer with 100% sample rate (#86206) ref(dashboards): Move unit scaling into `Plottable` (#86116) tests(derived_code_mappings): Do not create object in parametrization section (#86188) chore: update gsApp CODEOWNERS (#86222) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sigh this PR introduced a regression where the tab dragging is super jank as a result of the styles needed to prevent the jumping behavior.
The fix is to disable the styles while dragging, so we need to bubble the dragging state to above all tabs, rather than per tab.