Add cache for common package queries #22491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KN4CK3R
added
type/enhancement
|
Maybe we can wait #22294 |
GiteaBot
added
the
lgtm/need 2
|
I don't think this is related because this cache should only be valid within one request. If you cache these objects longer than that you may get problems with expired/updated values. |
Yes, it's the same. |
|
Oh, my mistake. I mixed up that PR with the global cache. |
|
I think this could be rewritten since #22294 merged. |
yardenshoham
added
the
outdated/backport/v1.19
yardenshoham
removed
the
outdated/backport/v1.19
techknowlogick
approved these changes
Sep 12, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Apr 13, 2025
GiteaBot
added
lgtm/done
|
I do not think the "context cache" could be used in this case (actually the context cache's design would cause problems in some cases, see the comments) So I made some changes to introduce "EphemeralCache", it should be general enough and could be used to "skips xxx queries in the package queries". |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 14, 2025
* giteaofficial/main: (27 commits) fix github migration error when using multiple tokens (go-gitea#34144) Add package version api endpoints (go-gitea#34173) Fix incorrect file links (go-gitea#34189) Add cache for common package queries (go-gitea#22491) Allow admins and org owners to change org member public status (go-gitea#28294) Fix span svg layout (go-gitea#34185) fix webhook url (go-gitea#34186) Optimize overflow-menu (go-gitea#34183) Move and rename UpdateRepository (go-gitea#34136) Update milestones.tmpl (go-gitea#34184) [skip ci] Updated translations via Crowdin Refactor Git Attribute & performance optimization (go-gitea#34154) [skip ci] Updated translations via Crowdin fix(go-gitea#33711): cross-publish docker images to ghcr.io (go-gitea#34148) refactor organization menu (go-gitea#33928) feat: Add sorting by exclusive labels (issue priority) (go-gitea#33206) Fix vertical centering of file tree icons and use entryIcon for submodules/symlinks (go-gitea#34137) bugfix check for alternate ssh host certificate location (go-gitea#34146) Cache GPG keys, emails and users when list commits (go-gitea#34086) Set MERMAID_MAX_SOURCE_CHARACTERS to 50000 (go-gitea#34152) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a cache for common package queries in
GetPackageDescriptor. Code which needs to process a list of packages benefits from this change. This skips 350 queries in the package integration tests for example.